Infrastructure/verdaccio
0
Fork 0
mirror of https://github.com/verdaccio/verdaccio.git synced 2025-01-20 22:52:46 -05:00
Code Issues Activity

refactor: using async/await over async lib

Browse source
This commit is contained in:
Juan Picado @jotadeveloper 2018-06-09 12:02:56 +02:00
parent 00ec929d95
commit 2208b4ef51
No known key found for this signature in database
GPG key ID: 18AC54485952D158
1 changed files with 28 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

53
src/api/web/endpoint/package.js
View file

@ -3,7 +3,6 @@
import _ from 'lodash'; import _ from 'lodash';
import {addScope, addGravatarSupport, deleteProperties, sortByName, DIST_TAGS} from '../../../lib/utils'; import {addScope, addGravatarSupport, deleteProperties, sortByName, DIST_TAGS} from '../../../lib/utils';
import {allow} from '../../middleware'; import {allow} from '../../middleware';
import async from 'async';
import marked from 'marked'; import marked from 'marked';
import type {Router} from 'express'; import type {Router} from 'express';
import type { import type {
@ -18,35 +17,43 @@ import type {
function addPackageWebApi(route: Router, storage: IStorageHandler, auth: IAuth) { function addPackageWebApi(route: Router, storage: IStorageHandler, auth: IAuth) {
const can = allow(auth); const can = allow(auth);
const checkAllow = (name, remoteUser) => new Promise((resolve, reject) => {
try {
auth.allow_access(name, remoteUser, (err, allowed) => {
if (err) {
resolve(false);
} else {
resolve(allowed);
}
});
} catch (err) {
reject(err);
}
});
// Get list of all visible package // Get list of all visible package
route.get('/packages', function(req: $RequestExtend, res: $ResponseExtend, next: $NextFunctionVer) { route.get('/packages', function(req: $RequestExtend, res: $ResponseExtend, next: $NextFunctionVer) {
storage.getLocalDatabase(function(err, packages) { storage.getLocalDatabase(async function(err, packages) {
if (err) {
// that function shouldn't produce any
throw err;
}
async.filterSeries(
packages,
function(pkg, cb) {
auth.allow_access(pkg.name, req.remote_user, function(err, allowed) {
setImmediate(function() {
if (err) {
cb(null, false);
} else {
cb(err, allowed);
}
});
});
},
function(err, packages) {
if (err) { if (err) {
throw err; throw err;
} }
next(sortByName(packages)); async function processPermissionsPackages(packages) {
const permissions = [];
for (let pkg of packages) {
try {
if (await checkAllow(pkg.name, req.remote_user)) {
permissions.push(pkg);
} }
); } catch (err) {
throw err;
}
}
return permissions;
}
next(sortByName(await processPermissionsPackages(packages)));
}); });
}); });