e2e: npm search and ping commands (#3386)

* chore: rename folders

* chore: add search tests

* chore: remove old files

* Update pnpm-workspace.yaml

* chore: fix ui

* Update e2e-ci.yml

* chore: renovate deps

* fix build

* chore: add tests

.github/workflows/e2e-ci.yml

@@ -25,10 +25,10 @@ jobs:
           NODE_ENV: production
     steps:
     - uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # tag=v3
-    - name: Use Node 16
+    - name: Use Node
       uses: actions/setup-node@2fddd8803e2f5c9604345a0b591c3020ee971a93 # tag=v3
       with:
-        node-version: 16
+        node-version-file: '.nvmrc'
     - name: Install pnpm
       run: npm i pnpm@6.32.15 -g
     - name: set store
@@ -52,7 +52,7 @@ jobs:
       - name: Use Node 16
         uses: actions/setup-node@2fddd8803e2f5c9604345a0b591c3020ee971a93 # tag=v3
         with:
-          node-version: 16
+          node-version-file: '.nvmrc'
       - name: Install pnpm
         run: npm i pnpm@6.32.15 -g
       - uses: actions/cache@fd5de65bc895cf536527842281bea11763fefd77 # tag=v3
@@ -60,7 +60,7 @@ jobs:
           path: ~/.pnpm-store
           key: pnpm-${{ hashFiles('pnpm-lock.yaml') }}
       - name: Install
-        run: pnpm recursive install --offline --frozen-lockfile --reporter=silence --ignore-scripts --registry http://localhost:4873
+        run: pnpm recursive install --frozen-lockfile --reporter=silence --registry http://localhost:4873
       - name: build
         run: pnpm build
       - name: Cache packages
@@ -75,7 +75,7 @@ jobs:
         uses: actions/cache@fd5de65bc895cf536527842281bea11763fefd77 # tag=v3
         id: cache-test
         with:
-          path: ./test/
+          path: ./e2e/
           key: test-${{ hashFiles('pnpm-lock.yaml') }}
           restore-keys: |
             test-
@@ -86,7 +86,7 @@ jobs:
       fail-fast: true
       matrix:
         pkg: [npm6, npm7, npm8, pnpm6, pnpm7, yarn1, yarn2,  yarn3, yarn4]
-    name:  E2E / ${{ matrix.pkg }} / ${{ matrix.os }}
+    name:  ${{ matrix.pkg }} / ${{ matrix.os }}
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # tag=v3
@@ -107,7 +107,7 @@ jobs:
           key: pkg-${{ hashFiles('pnpm-lock.yaml') }}
       - uses: actions/cache@fd5de65bc895cf536527842281bea11763fefd77 # tag=v3
         with:
-          path: ./test/
+          path: ./e2e/
           key: test-${{ hashFiles('pnpm-lock.yaml') }}      
       - name: Test CLI
         run: NODE_ENV=production pnpm test --filter ...@verdaccio/e2e-cli-${{matrix.pkg}}

e2e/cli/README.md

@@ -14,6 +14,12 @@
 | audit     | ✅   | ✅   | ✅   | ✅    | ✅    | ✅    | ✅    | ✅    | ❌    |
 | install   | ✅   | ✅   | ✅   | ✅    | ✅    | ✅    | ✅    | ✅    | ✅    |
 | deprecate | ✅   | ✅   | ✅   | ✅    | ✅    | ⛔    | ⛔    | ⛔    | ⛔    |
+| ping      | ✅   | ✅   | ✅   | ✅    | ✅    | ⛔    | ⛔    | ⛔    | ⛔    |
+| search    | ✅   | ✅   | ✅   | ✅    | ✅    | ⛔    | ⛔    | ⛔    | ⛔    |
+
+> notes:
+>
+> - yarn search exist in modern but do not use the search registry endpoint
 
 ❌ = no tested
 ✅ = tested

e2e/cli/cli-commons/package.json

@@ -6,16 +6,11 @@
   "types": "./build/index.d.ts",
   "dependencies": {
     "debug": "4.3.4",
-    "npm": "6.14.17",
-    "get-port": "5.1.1",
-    "wait-on": "^6.0.0",
     "fs-extra": "10.1.0",
-    "semver": "7.3.7",
     "got": "11.8.5",
     "verdaccio": "workspace:6.0.0-6-next.47",
     "@verdaccio/core": "workspace:6.0.0-6-next.47",
-    "@verdaccio/config": "workspace:6.0.0-6-next.47",
-    "@verdaccio/test-helper": "workspace:1.1.0-6-next.4"
+    "@verdaccio/config": "workspace:6.0.0-6-next.47"
   },
   "scripts": {
     "test": "jest",

e2e/cli/e2e-npm6/ping.spec.ts

@@ -0,0 +1,24 @@
+import { addRegistry, initialSetup } from '@verdaccio/test-cli-commons';
+
+import { npm } from './utils';
+
+describe('ping registry', () => {
+  jest.setTimeout(10000);
+  let registry;
+
+  beforeAll(async () => {
+    const setup = await initialSetup();
+    registry = setup.registry;
+    await registry.init();
+  });
+
+  test('should ping registry', async () => {
+    const resp = await npm({}, 'ping', '--json', ...addRegistry(registry.getRegistryUrl()));
+    const parsedBody = JSON.parse(resp.stdout as string);
+    expect(parsedBody.registry).toEqual(registry.getRegistryUrl() + '/');
+  });
+
+  afterAll(async () => {
+    registry.stop();
+  });
+});

e2e/cli/e2e-npm6/search.spec.ts

@@ -0,0 +1,33 @@
+import { addRegistry, initialSetup } from '@verdaccio/test-cli-commons';
+
+import { npm } from './utils';
+
+describe('search a package', () => {
+  jest.setTimeout(10000);
+  let registry;
+
+  beforeAll(async () => {
+    const setup = await initialSetup();
+    registry = setup.registry;
+    await registry.init();
+  });
+
+  test('should search a package', async () => {
+    const resp = await npm(
+      {},
+      'search',
+      '@verdaccio/cli',
+      '--json',
+      ...addRegistry(registry.getRegistryUrl())
+    );
+    const parsedBody = JSON.parse(resp.stdout as string);
+    const pkgFind = parsedBody.find((item) => {
+      return item.name === '@verdaccio/cli';
+    });
+    expect(pkgFind.name).toEqual('@verdaccio/cli');
+  });
+
+  afterAll(async () => {
+    registry.stop();
+  });
+});

e2e/cli/e2e-npm7/ping.spec.ts

@@ -0,0 +1,24 @@
+import { addRegistry, initialSetup } from '@verdaccio/test-cli-commons';
+
+import { npm } from './utils';
+
+describe('ping registry', () => {
+  jest.setTimeout(10000);
+  let registry;
+
+  beforeAll(async () => {
+    const setup = await initialSetup();
+    registry = setup.registry;
+    await registry.init();
+  });
+
+  test('should ping registry', async () => {
+    const resp = await npm({}, 'ping', '--json', ...addRegistry(registry.getRegistryUrl()));
+    const parsedBody = JSON.parse(resp.stdout as string);
+    expect(parsedBody.registry).toEqual(registry.getRegistryUrl() + '/');
+  });
+
+  afterAll(async () => {
+    registry.stop();
+  });
+});

e2e/cli/e2e-npm7/search.spec.ts

@@ -0,0 +1,33 @@
+import { addRegistry, initialSetup } from '@verdaccio/test-cli-commons';
+
+import { npm } from './utils';
+
+describe('search a package', () => {
+  jest.setTimeout(10000);
+  let registry;
+
+  beforeAll(async () => {
+    const setup = await initialSetup();
+    registry = setup.registry;
+    await registry.init();
+  });
+
+  test('should search a package', async () => {
+    const resp = await npm(
+      {},
+      'search',
+      '@verdaccio/cli',
+      '--json',
+      ...addRegistry(registry.getRegistryUrl())
+    );
+    const parsedBody = JSON.parse(resp.stdout as string);
+    const pkgFind = parsedBody.find((item) => {
+      return item.name === '@verdaccio/cli';
+    });
+    expect(pkgFind.name).toEqual('@verdaccio/cli');
+  });
+
+  afterAll(async () => {
+    registry.stop();
+  });
+});

e2e/cli/e2e-npm8/ping.spec.ts

@@ -0,0 +1,24 @@
+import { addRegistry, initialSetup } from '@verdaccio/test-cli-commons';
+
+import { npm } from './utils';
+
+describe('ping registry', () => {
+  jest.setTimeout(10000);
+  let registry;
+
+  beforeAll(async () => {
+    const setup = await initialSetup();
+    registry = setup.registry;
+    await registry.init();
+  });
+
+  test('should ping registry', async () => {
+    const resp = await npm({}, 'ping', '--json', ...addRegistry(registry.getRegistryUrl()));
+    const parsedBody = JSON.parse(resp.stdout as string);
+    expect(parsedBody.registry).toEqual(registry.getRegistryUrl() + '/');
+  });
+
+  afterAll(async () => {
+    registry.stop();
+  });
+});

e2e/cli/e2e-npm8/search.spec.ts

@@ -0,0 +1,33 @@
+import { addRegistry, initialSetup } from '@verdaccio/test-cli-commons';
+
+import { npm } from './utils';
+
+describe('search a package', () => {
+  jest.setTimeout(10000);
+  let registry;
+
+  beforeAll(async () => {
+    const setup = await initialSetup();
+    registry = setup.registry;
+    await registry.init();
+  });
+
+  test('should search a package', async () => {
+    const resp = await npm(
+      {},
+      'search',
+      '@verdaccio/cli',
+      '--json',
+      ...addRegistry(registry.getRegistryUrl())
+    );
+    const parsedBody = JSON.parse(resp.stdout as string);
+    const pkgFind = parsedBody.find((item) => {
+      return item.name === '@verdaccio/cli';
+    });
+    expect(pkgFind.name).toEqual('@verdaccio/cli');
+  });
+
+  afterAll(async () => {
+    registry.stop();
+  });
+});

e2e/cli/e2e-pnpm6/ping.spec.ts

@@ -0,0 +1,24 @@
+import { addRegistry, initialSetup } from '@verdaccio/test-cli-commons';
+
+import { pnpm } from './utils';
+
+describe('ping registry', () => {
+  jest.setTimeout(10000);
+  let registry;
+
+  beforeAll(async () => {
+    const setup = await initialSetup();
+    registry = setup.registry;
+    await registry.init();
+  });
+
+  test('should ping registry', async () => {
+    const resp = await pnpm({}, 'ping', '--json', ...addRegistry(registry.getRegistryUrl()));
+    const parsedBody = JSON.parse(resp.stdout as string);
+    expect(parsedBody.registry).toEqual(registry.getRegistryUrl() + '/');
+  });
+
+  afterAll(async () => {
+    registry.stop();
+  });
+});

e2e/cli/e2e-pnpm6/search.spec.ts

@@ -0,0 +1,33 @@
+import { addRegistry, initialSetup } from '@verdaccio/test-cli-commons';
+
+import { pnpm } from './utils';
+
+describe('search a package', () => {
+  jest.setTimeout(10000);
+  let registry;
+
+  beforeAll(async () => {
+    const setup = await initialSetup();
+    registry = setup.registry;
+    await registry.init();
+  });
+
+  test('should search a package', async () => {
+    const resp = await pnpm(
+      {},
+      'search',
+      '@verdaccio/cli',
+      '--json',
+      ...addRegistry(registry.getRegistryUrl())
+    );
+    const parsedBody = JSON.parse(resp.stdout as string);
+    const pkgFind = parsedBody.find((item) => {
+      return item.name === '@verdaccio/cli';
+    });
+    expect(pkgFind.name).toEqual('@verdaccio/cli');
+  });
+
+  afterAll(async () => {
+    registry.stop();
+  });
+});

e2e/cli/e2e-pnpm7/ping.spec.ts

@@ -0,0 +1,24 @@
+import { addRegistry, initialSetup } from '@verdaccio/test-cli-commons';
+
+import { pnpm } from './utils';
+
+describe('ping registry', () => {
+  jest.setTimeout(10000);
+  let registry;
+
+  beforeAll(async () => {
+    const setup = await initialSetup();
+    registry = setup.registry;
+    await registry.init();
+  });
+
+  test('should ping registry', async () => {
+    const resp = await pnpm({}, 'ping', '--json', ...addRegistry(registry.getRegistryUrl()));
+    const parsedBody = JSON.parse(resp.stdout as string);
+    expect(parsedBody.registry).toEqual(registry.getRegistryUrl() + '/');
+  });
+
+  afterAll(async () => {
+    registry.stop();
+  });
+});

e2e/cli/e2e-pnpm7/search.spec.ts

@@ -0,0 +1,33 @@
+import { addRegistry, initialSetup } from '@verdaccio/test-cli-commons';
+
+import { pnpm } from './utils';
+
+describe('search a package', () => {
+  jest.setTimeout(10000);
+  let registry;
+
+  beforeAll(async () => {
+    const setup = await initialSetup();
+    registry = setup.registry;
+    await registry.init();
+  });
+
+  test('should search a package', async () => {
+    const resp = await pnpm(
+      {},
+      'search',
+      '@verdaccio/cli',
+      '--json',
+      ...addRegistry(registry.getRegistryUrl())
+    );
+    const parsedBody = JSON.parse(resp.stdout as string);
+    const pkgFind = parsedBody.find((item) => {
+      return item.name === '@verdaccio/cli';
+    });
+    expect(pkgFind.name).toEqual('@verdaccio/cli');
+  });
+
+  afterAll(async () => {
+    registry.stop();
+  });
+});