From 0210752ea5befad5a4124fa9cae5614bf2ad8772 Mon Sep 17 00:00:00 2001
From: Juan Carlos Picado <juanpicado19@gmail.com>
Date: Mon, 5 Dec 2016 08:42:43 +0100
Subject: [PATCH] clean warnings on unit test

---
 lib/auth.js                   | 12 ++++++------
 lib/index-api.js              |  2 +-
 test/functional/lib/server.js |  2 +-
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/lib/auth.js b/lib/auth.js
index c1028e4a9..c7044c9a4 100644
--- a/lib/auth.js
+++ b/lib/auth.js
@@ -195,9 +195,9 @@ Auth.prototype.basic_middleware = function() {
 
     var scheme = parts[0]
     if (scheme === 'Basic') {
-      var credentials = Buffer(parts[1], 'base64').toString()
+      var credentials = new Buffer(parts[1], 'base64').toString()
     } else if (scheme === 'Bearer') {
-      var credentials = self.aes_decrypt(Buffer(parts[1], 'base64')).toString('utf8')
+      var credentials = self.aes_decrypt(new Buffer(parts[1], 'base64')).toString('utf8')
       if (!credentials) return next()
     } else {
       return next()
@@ -286,7 +286,7 @@ Auth.prototype.cookie_middleware = function() {
     req.remote_user = AuthenticatedUser(user.u, user.g)
     req.remote_user.token = token
     next()*/
-    var credentials = self.aes_decrypt(Buffer(token, 'base64')).toString('utf8')
+    var credentials = self.aes_decrypt(new Buffer(token, 'base64')).toString('utf8')
     if (!credentials) return next()
 
     var index = credentials.indexOf(':')
@@ -314,13 +314,13 @@ Auth.prototype.issue_token = function(user) {
     t: ~~(Date.now()/1000),
   }, { indent: false })
 
-  data = Buffer(data, 'utf8')
+  data = new Buffer(data, 'utf8')
   var mac = Crypto.createHmac('sha256', this.secret).update(data).digest()
   return Buffer.concat([ data, mac ]).toString('base64')
 }
 
 Auth.prototype.decode_token = function(str, expire_time) {
-  var buf = Buffer(str, 'base64')
+  var buf = new Buffer(str, 'base64')
   if (buf.length <= 32) throw Error[401]('invalid token')
 
   var data      = buf.slice(0, buf.length - 32)
@@ -355,7 +355,7 @@ Auth.prototype.aes_decrypt = function(buf) {
     var b1 = c.update(buf)
     var b2 = c.final()
   } catch(_) {
-    return Buffer(0)
+    return new Buffer(0)
   }
   return Buffer.concat([ b1, b2 ])
 }
diff --git a/lib/index-api.js b/lib/index-api.js
index 224573fb7..f53d152e1 100644
--- a/lib/index-api.js
+++ b/lib/index-api.js
@@ -364,7 +364,7 @@ module.exports = function(config, auth, storage) {
       })
 
       // this is dumb and memory-consuming, but what choices do we have?
-      stream.end(Buffer(data.data, 'base64'))
+      stream.end(new Buffer(data.data, 'base64'))
       stream.done()
     }
 
diff --git a/test/functional/lib/server.js b/test/functional/lib/server.js
index 4a1af0ef7..0a720b14c 100644
--- a/test/functional/lib/server.js
+++ b/test/functional/lib/server.js
@@ -27,7 +27,7 @@ Server.prototype.request = function(options) {
 }
 
 Server.prototype.auth = function(user, pass) {
-  this.authstr = 'Basic '+(Buffer(user+':'+pass)).toString('base64')
+  this.authstr = 'Basic '+(new Buffer(user+':'+pass)).toString('base64')
   return this.request({
     uri: '/-/user/org.couchdb.user:'+encodeURIComponent(user)+'/-rev/undefined',
     method: 'PUT',