Infrastructure/pingvin-share
0
Fork 0
mirror of https://github.com/stonith404/pingvin-share.git synced 2025-01-22 01:22:32 -05:00
Code Issues Activity

fix: crash on zip download if zip is larger than 4GB (#709)

Browse source
This commit is contained in:
Pak Lam (Billy) Lee 2024-12-28 11:37:58 -05:00 • committed by GitHub
parent 856c54d5d6
commit bfd4049c15
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
backend/src/file/file.controller.ts
View file

@ -54,13 +54,14 @@ export class FileController {
@Res({ passthrough: true }) res: Response,
@Param("shareId") shareId: string,
) {
const zip = await this.fileService.getZip(shareId);
const zipStream = this.fileService.getZip(shareId);
res.set({
"Content-Type": "application/zip",
"Content-Disposition": contentDisposition(`${shareId}.zip`),
});
return new StreamableFile(zip);
return new StreamableFile(zipStream);
}
@Get(":fileId")

2
backend/src/file/file.service.ts
View file

@ -61,7 +61,7 @@ export class FileService {
getZip(shareId: string) {
const storageService = this.getStorageService();
return this.streamToUint8Array(storageService.getZip(shareId) as Readable);
return storageService.getZip(shareId) as Readable;
}
private async streamToUint8Array(stream: Readable): Promise<Uint8Array> {