Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2024-12-16 20:26:19 -05:00
Code Issues Activity

fix(console): highlight current tab in sidebar (#4524)

Browse source
This commit is contained in:
Gao Sun 2023-09-15 21:40:11 +08:00 committed by GitHub
parent d1729d89a9
commit f9322d02dc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/console/src/containers/ConsoleContent/Sidebar/index.tsx
View file

@ -27,7 +27,7 @@ function Sidebar() {
key={title} key={title}
titleKey={title} titleKey={title}
icon={<Icon />} icon={<Icon />}
isActive={match(getPath(title))} isActive={match('/' + getPath(title))}
modal={modal} modal={modal}
externalLink={externalLink} externalLink={externalLink}
/> />

16
packages/integration-tests/src/tests/console/bootstrap.test.ts
View file

@ -7,7 +7,7 @@ import {
consoleUsername, consoleUsername,
logtoConsoleUrl as logtoConsoleUrlString, logtoConsoleUrl as logtoConsoleUrlString,
} from '#src/constants.js'; } from '#src/constants.js';
import { appendPathname, expectNavigation } from '#src/utils.js'; import { appendPathname, cls, dcls, expectNavigation } from '#src/utils.js';
/** /**
* NOTE: This test suite assumes test cases will run sequentially (which is Jest default). * NOTE: This test suite assumes test cases will run sequentially (which is Jest default).
@ -121,4 +121,18 @@ describe('smoke testing for console admin account creation and sign-in', () => {
it('renders SVG correctly with viewbox property', async () => { it('renders SVG correctly with viewbox property', async () => {
await page.waitForSelector('div[class$=topbar] > svg[viewbox][class$=logo]', { visible: true }); await page.waitForSelector('div[class$=topbar] > svg[viewbox][class$=logo]', { visible: true });
}); });
it('can highlight the current tab in the sidebar', async () => {
const activeSelector = [dcls('sidebar'), 'a' + cls('row') + cls('active'), dcls('title')].join(
' '
);
await expect(page).toMatchElement(activeSelector, { text: 'Applications', visible: true });
await expectNavigation(
expect(page).toClick([dcls('sidebar'), 'a' + cls('row')].join(' '), {
text: 'Dashboard',
})
);
await expect(page).toMatchElement(activeSelector, { text: 'Dashboard', visible: true });
});
}); });