Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2025-01-20 21:32:31 -05:00
Code Issues Activity

fix: connector metadata update should be optional (#2666)

Browse source
This commit is contained in:
Darcy Ye 2022-12-15 15:18:49 +08:00 • committed by GitHub
parent bed00c4918
commit f3baaf919f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 53 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/core/src/routes/connector.ts
View file

@ -208,12 +208,14 @@ export default function connectorRoutes<T extends AuthedRouter>(router: T) {
const { type, validateConfig, metadata: originalMetadata } = await getLogtoConnectorById(id);
assertThat(
originalMetadata.isStandard !== true || metadata?.target === originalMetadata.target,
originalMetadata.isStandard !== true ||
!metadata ||
metadata.target === originalMetadata.target,
'connector.can_not_modify_target'
);
assertThat(
originalMetadata.isStandard === true || metadata === undefined,
originalMetadata.isStandard === true || !metadata,
'connector.cannot_overwrite_metadata_for_non_standard_connector'
);

49
packages/core/src/routes/connector.update.test.ts
View file

@ -108,7 +108,54 @@ describe('connector PATCH routes', () => {
expect(response).toHaveProperty('statusCode', 400);
});
it('successfully updates connector configs', async () => {
it('throws when updates non-standard connector metadata', async () => {
getLogtoConnectors.mockResolvedValue([
{
dbEntry: mockConnector,
metadata: { ...mockMetadata },
type: ConnectorType.Social,
...mockLogtoConnector,
},
]);
const response = await connectorRequest.patch('/connectors/id').send({
metadata: {
target: 'connector',
name: { en: 'connector_name', fr: 'connector_name' },
logo: 'new_logo.png',
},
});
expect(response).toHaveProperty('statusCode', 400);
});
it('successfully updates connector config', async () => {
getLogtoConnectors.mockResolvedValue([
{
dbEntry: mockConnector,
metadata: { ...mockMetadata, isStandard: true },
type: ConnectorType.Social,
...mockLogtoConnector,
},
]);
updateConnector.mockResolvedValueOnce({
...mockConnector,
config: { cliend_id: 'client_id', client_secret: 'client_secret' },
});
const response = await connectorRequest.patch('/connectors/id').send({
config: { cliend_id: 'client_id', client_secret: 'client_secret' },
});
expect(response).toHaveProperty('statusCode', 200);
expect(updateConnector).toHaveBeenCalledWith(
expect.objectContaining({
where: { id: 'id' },
set: {
config: { cliend_id: 'client_id', client_secret: 'client_secret' },
},
jsonbMode: 'replace',
})
);
});
it('successfully updates connector config and metadata', async () => {
getLogtoConnectors.mockResolvedValue([
{
dbEntry: mockConnector,

4
packages/integration-tests/src/tests/api/connector.test.ts
View file

@ -77,9 +77,7 @@ test('connector set-up flow', async () => {
connectorId: mockStandardEmailConnectorId,
metadata: { target: 'mock-standard-mail' },
});
await updateConnectorConfig(id, mockStandardEmailConnectorConfig, {
target: 'mock-standard-mail',
});
await updateConnectorConfig(id, mockStandardEmailConnectorConfig);
connectorIdMap.set(mockStandardEmailConnectorId, id);
const currentConnectors = await listConnectors();
expect(