refactor(console,experience,test): decouple isDevFeatureEnabled with isIntegrationTest (#6012)

* refactor(console,experience,test): decouple isDevFeatureEnabled with isIntegrationTest

decouple isDevFeatureEnabled with isIntegrationTest ENV variables

* chore: update environment variable get method

update environment variable get method

.github/workflows/alteration-compatibility-integration-test.yml

@@ -50,6 +50,7 @@ jobs:
     if: ${{needs.check-alteration-changes.outputs.has-alteration-changes == 'true'}}
     env:
       INTEGRATION_TEST: true
+      DEV_FEATURES_ENABLED: true
     steps:
       - uses: logto-io/actions-package-logto-artifact@v2
         with:
@@ -66,6 +67,7 @@ jobs:
     runs-on: ubuntu-latest
     env:
       INTEGRATION_TEST: true
+      DEV_FEATURES_ENABLED: true
       DB_URL: postgres://postgres:postgres@localhost:5432/postgres
 
     steps:

.github/workflows/integration-test.yml

@@ -16,6 +16,7 @@ jobs:
     runs-on: ubuntu-latest
     env:
       INTEGRATION_TEST: true
+      DEV_FEATURES_ENABLED: true
 
     steps:
       - uses: logto-io/actions-package-logto-artifact@v2
@@ -32,6 +33,7 @@ jobs:
     runs-on: ubuntu-latest
     env:
       INTEGRATION_TEST: true
+      DEV_FEATURES_ENABLED: true
       DB_URL: postgres://postgres:postgres@localhost:5432/postgres
 
     steps:

packages/console/src/consts/env.ts

@@ -9,5 +9,4 @@ export const adminEndpoint = process.env.ADMIN_ENDPOINT;
 export const isDevFeaturesEnabled =
   !isProduction ||
   yes(process.env.DEV_FEATURES_ENABLED) ||
-  yes(process.env.INTEGRATION_TEST) ||
   yes(localStorage.getItem(storageKeys.isDevFeaturesEnabled));

packages/experience/src/constants/env.ts

@@ -1,6 +1,4 @@
 import { yes } from '@silverhand/essentials';
 
 export const isDevFeaturesEnabled =
-  process.env.NODE_ENV !== 'production' ||
+  process.env.NODE_ENV !== 'production' || yes(process.env.DEV_FEATURES_ENABLED);
-  yes(process.env.DEV_FEATURES_ENABLED) ||
-  yes(process.env.INTEGRATION_TEST);

packages/integration-tests/src/constants.ts

@@ -1,10 +1,10 @@
 import {
-  type CreateSsoConnector,
   SignInIdentifier,
   SsoProviderName,
   demoAppApplicationId,
+  type CreateSsoConnector,
 } from '@logto/schemas';
-import { appendPath, getEnv } from '@silverhand/essentials';
+import { appendPath, getEnv, yes } from '@silverhand/essentials';
 
 export const logtoUrl = getEnv('INTEGRATION_TESTS_LOGTO_URL', 'http://localhost:3001');
 export const logtoOidcUrl = appendPath(new URL(logtoUrl), 'oidc').toString();
@@ -47,3 +47,5 @@ export const newOidcSsoConnectorPayload = {
     issuer: `${logtoUrl}/oidc`,
   },
 } satisfies Partial<CreateSsoConnector>;
+
+export const isDevFeaturesEnabled = yes(getEnv('DEV_FEATURES_ENABLED'));

packages/integration-tests/src/tests/console/bootstrap.test.ts

@@ -5,6 +5,7 @@ import { authedAdminTenantApi } from '#src/api/api.js';
 import {
   consolePassword,
   consoleUsername,
+  isDevFeaturesEnabled,
   logtoConsoleUrl as logtoConsoleUrlString,
 } from '#src/constants.js';
 import { appendPathname, cls, dcls, expectNavigation, waitFor } from '#src/utils.js';
@@ -135,4 +136,10 @@ describe('smoke testing for console admin account creation and sign-in', () => {
     );
     await expect(page).toMatchElement(activeSelector, { text: 'Dashboard', visible: true });
   });
+
+  it(`should ${isDevFeaturesEnabled ? '' : 'not '}show the dev features label`, async () => {
+    await (isDevFeaturesEnabled
+      ? expect(page).toMatchElement('div', { text: 'Dev features enabled' })
+      : expect(page).not.toMatchElement('div', { text: 'Dev features enabled' }));
+  });
 });

packages/shared/src/node/env/GlobalValues.ts

@@ -7,8 +7,7 @@ export default class GlobalValues {
   public readonly isProduction = getEnv('NODE_ENV') === 'production';
   public readonly isIntegrationTest = yes(getEnv('INTEGRATION_TEST'));
   public readonly isUnitTest = getEnv('NODE_ENV') === 'test';
-  public readonly isDevFeaturesEnabled =
+  public readonly isDevFeaturesEnabled = !this.isProduction || yes(getEnv('DEV_FEATURES_ENABLED'));
-    !this.isProduction || yes(getEnv('DEV_FEATURES_ENABLED')) || this.isIntegrationTest;
 
   public readonly httpsCert = process.env.HTTPS_CERT_PATH;
   public readonly httpsKey = process.env.HTTPS_KEY_PATH;