Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2025-03-24 22:41:28 -05:00
Code Issues Activity

fix(console): catch timeout error when submitting form (#6431)

Browse source
This commit is contained in:
Xiao Yijun 2024-08-11 21:26:59 +08:00 • committed by GitHub
parent 4b01ce7c17
commit ea70e09ad8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
packages/console/src/utils/form.ts
View file

@ -1,9 +1,13 @@
import { HTTPError } from 'ky';
import { HTTPError, TimeoutError } from 'ky';
import { type FieldValues, type SubmitHandler } from 'react-hook-form';
import { toast } from 'react-hot-toast';
/**
* After upgrading the react-hook-form to v7.42.0, the `isSubmitting` flag does not recover when the submit handler throws.
* So we need to catch the error and do nothing if the error is an HTTPError and the status code is not 401 to prevent the `isSubmitting` flag from being stuck.
* So we need to catch the error and do nothing if the error is one of the following to prevent the `isSubmitting` flag from being stuck:
* - HTTPError with a status code that is not 401
* - TimeoutError
*
* Reference: https://github.com/orgs/react-hook-form/discussions/10103#discussioncomment-5927542
*/
export const trySubmitSafe =
@ -13,6 +17,13 @@ export const trySubmitSafe =
await handler(formData, event);
} catch (error) {
if (error instanceof HTTPError && error.response.status !== 401) {
// Returned directly, since the error has been handled by the `use-api` hook.
return;
}
if (error instanceof TimeoutError) {
// Display a toast message for the timeout error.
toast.error(error.message);
return;
}