Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2024-12-16 20:26:19 -05:00
Code Issues Activity

fix(console): only check demo app existence on get-started page

Browse source
This commit is contained in:
Charles Zhao 2022-06-07 18:48:34 +08:00
parent 2ba11215ed
commit e8ef4b650c
No known key found for this signature in database
GPG key ID: 4858774754C92DF2
3 changed files with 19 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/console/src/pages/GetStarted/components/GetStartedProgress/index.tsx
View file

@ -17,7 +17,7 @@ const GetStartedProgress = () => {
} = useUserPreferences(); } = useUserPreferences();
const anchorRef = useRef<HTMLDivElement>(null); const anchorRef = useRef<HTMLDivElement>(null);
const [showDropDown, setShowDropdown] = useState(false); const [showDropDown, setShowDropdown] = useState(false);
const { data, completedCount, totalCount } = useGetStartedMetadata(); const { data, completedCount, totalCount } = useGetStartedMetadata({ checkDemoAppExists: false });
if (hideGetStarted) { if (hideGetStarted) {
return null; return null;

27
packages/console/src/pages/GetStarted/hook.ts
View file

@ -23,17 +23,24 @@ type GetStartedMetadata = {
onClick: () => void; onClick: () => void;
}; };
const useGetStartedMetadata = () => { type Props = {
const { settings, updateSettings } = useSettings(); checkDemoAppExists: boolean;
const { data: demoApp, error } = useSWR<Application, RequestError>('/api/applications/demo_app', { };
shouldRetryOnError: (error: unknown) => {
if (error instanceof RequestError) {
return error.status !== 404;
}
return true; const useGetStartedMetadata = ({ checkDemoAppExists }: Props) => {
}, const { settings, updateSettings } = useSettings();
}); const { data: demoApp, error } = useSWR<Application, RequestError>(
checkDemoAppExists && '/api/applications/demo_app',
{
shouldRetryOnError: (error: unknown) => {
if (error instanceof RequestError) {
return error.status !== 404;
}
return true;
},
}
);
const navigate = useNavigate(); const navigate = useNavigate();
const isLoadingDemoApp = !demoApp && !error; const isLoadingDemoApp = !demoApp && !error;
const hideDemo = error?.status === 404; const hideDemo = error?.status === 404;

2
packages/console/src/pages/GetStarted/index.tsx
View file

@ -16,7 +16,7 @@ import * as styles from './index.module.scss';
const GetStarted = () => { const GetStarted = () => {
const { t } = useTranslation(undefined, { keyPrefix: 'admin_console' }); const { t } = useTranslation(undefined, { keyPrefix: 'admin_console' });
const navigate = useNavigate(); const navigate = useNavigate();
const { data, isLoading } = useGetStartedMetadata(); const { data, isLoading } = useGetStartedMetadata({ checkDemoAppExists: true });
const { update } = useUserPreferences(); const { update } = useUserPreferences();
const [showConfirmModal, setShowConfirmModal] = useState(false); const [showConfirmModal, setShowConfirmModal] = useState(false);