Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2025-01-20 21:32:31 -05:00
Code Issues Activity

fix(core): register with social should not ask for password (#2793)

Browse source
This commit is contained in:
simeng-li 2022-12-31 09:30:07 +08:00 • committed by GitHub
parent 51e39eeb3b
commit d8deb0285f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
packages/core/src/routes/interaction/verifications/mandatory-user-profile-validation.test.ts
View file

@ -64,6 +64,18 @@ describe('validateMandatoryUserProfile', () => {
await expect(validateMandatoryUserProfile(baseCtx, interaction)).resolves.not.toThrow(); await expect(validateMandatoryUserProfile(baseCtx, interaction)).resolves.not.toThrow();
}); });
it('register user has social profile', async () => {
await expect(
validateMandatoryUserProfile(baseCtx, {
event: InteractionEvent.Register,
profile: {
username: 'foo',
connectorId: 'logto',
},
})
).resolves.not.toThrow();
});
it('email missing but required', async () => { it('email missing but required', async () => {
const ctx = { const ctx = {
...baseCtx, ...baseCtx,

8
packages/core/src/routes/interaction/verifications/mandatory-user-profile-validation.ts
View file

@ -23,7 +23,13 @@ const getMissingProfileBySignUpIdentifiers = ({
}) => { }) => {
const missingProfile = new Set<MissingProfile>(); const missingProfile = new Set<MissingProfile>();
if (signUp.password && !(user && isUserPasswordSet(user)) && !profile?.password) { if (
signUp.password &&
!(user && isUserPasswordSet(user)) &&
!profile?.password &&
// Social identities can take place the role of password
!profile?.connectorId
) {
missingProfile.add(MissingProfile.password); missingProfile.add(MissingProfile.password);
} }