From d80e3a7ed28b2be18c48831f8e5a95acfbb063b9 Mon Sep 17 00:00:00 2001 From: Darcy Ye Date: Fri, 19 Aug 2022 02:35:06 +0800 Subject: [PATCH] refactor(connector): remove unnecessary assertions --- packages/connector-aliyun-dm/src/index.ts | 4 ---- packages/connector-aliyun-sms/src/index.ts | 4 ---- packages/connector-mock-email/src/index.ts | 4 ---- packages/connector-mock-sms/src/index.ts | 4 ---- packages/connector-sendgrid-mail/src/index.ts | 4 ---- packages/connector-smtp/src/index.ts | 4 ---- packages/connector-twilio-sms/src/index.ts | 4 ---- 7 files changed, 28 deletions(-) diff --git a/packages/connector-aliyun-dm/src/index.ts b/packages/connector-aliyun-dm/src/index.ts index 067f498dc..3b848eaf2 100644 --- a/packages/connector-aliyun-dm/src/index.ts +++ b/packages/connector-aliyun-dm/src/index.ts @@ -38,16 +38,12 @@ export default class AliyunDmConnector extends LogtoConnector { const config = await this.getConfig(this.metadata.id); this.validateConfig(config); - assert(this.sendMessageBy, new ConnectorError(ConnectorErrorCodes.NotImplemented)); - return this.sendMessageBy({ to, type, payload }, config); }; public sendTestMessage: SendMessageFunction = async ({ to, type, payload }, config) => { this.validateConfig(config); - assert(this.sendMessageBy, new ConnectorError(ConnectorErrorCodes.NotImplemented)); - return this.sendMessageBy({ to, type, payload }, config); }; diff --git a/packages/connector-aliyun-sms/src/index.ts b/packages/connector-aliyun-sms/src/index.ts index c0e6f0797..14bbec2a0 100644 --- a/packages/connector-aliyun-sms/src/index.ts +++ b/packages/connector-aliyun-sms/src/index.ts @@ -33,16 +33,12 @@ export default class AliyunSmsConnector extends LogtoConnector const config = await this.getConfig(this.metadata.id); this.validateConfig(config); - assert(this.sendMessageBy, new ConnectorError(ConnectorErrorCodes.NotImplemented)); - return this.sendMessageBy({ to, type, payload }, config); }; public sendTestMessage: SendMessageFunction = async ({ to, type, payload }, config) => { this.validateConfig(config); - assert(this.sendMessageBy, new ConnectorError(ConnectorErrorCodes.NotImplemented)); - return this.sendMessageBy({ to, type, payload }, config); }; diff --git a/packages/connector-mock-email/src/index.ts b/packages/connector-mock-email/src/index.ts index 2ce40abba..43c29d805 100644 --- a/packages/connector-mock-email/src/index.ts +++ b/packages/connector-mock-email/src/index.ts @@ -34,16 +34,12 @@ export default class MockMailConnector extends LogtoConnector { const config = await this.getConfig(this.metadata.id); this.validateConfig(config); - assert(this.sendMessageBy, new ConnectorError(ConnectorErrorCodes.NotImplemented)); - return this.sendMessageBy({ to, type, payload }, config); }; public sendTestMessage: SendMessageFunction = async ({ to, type, payload }, config) => { this.validateConfig(config); - assert(this.sendMessageBy, new ConnectorError(ConnectorErrorCodes.NotImplemented)); - return this.sendMessageBy({ to, type, payload }, config); }; diff --git a/packages/connector-mock-sms/src/index.ts b/packages/connector-mock-sms/src/index.ts index a56b6139d..12a4940e0 100644 --- a/packages/connector-mock-sms/src/index.ts +++ b/packages/connector-mock-sms/src/index.ts @@ -34,16 +34,12 @@ export default class MockLogtoConnector extends LogtoConnector { const config = await this.getConfig(this.metadata.id); this.validateConfig(config); - assert(this.sendMessageBy, new ConnectorError(ConnectorErrorCodes.NotImplemented)); - return this.sendMessageBy({ to, type, payload }, config); }; public sendTestMessage: SendMessageFunction = async ({ to, type, payload }, config) => { this.validateConfig(config); - assert(this.sendMessageBy, new ConnectorError(ConnectorErrorCodes.NotImplemented)); - return this.sendMessageBy({ to, type, payload }, config); }; diff --git a/packages/connector-sendgrid-mail/src/index.ts b/packages/connector-sendgrid-mail/src/index.ts index efab17f40..61e5f0536 100644 --- a/packages/connector-sendgrid-mail/src/index.ts +++ b/packages/connector-sendgrid-mail/src/index.ts @@ -39,16 +39,12 @@ export default class SendGridMailConnector extends LogtoConnector { this.validateConfig(config); - assert(this.sendMessageBy, new ConnectorError(ConnectorErrorCodes.NotImplemented)); - return this.sendMessageBy({ to, type, payload }, config); }; diff --git a/packages/connector-smtp/src/index.ts b/packages/connector-smtp/src/index.ts index 0f2e8daf0..9ea52be60 100644 --- a/packages/connector-smtp/src/index.ts +++ b/packages/connector-smtp/src/index.ts @@ -33,16 +33,12 @@ export default class SmtpConnector extends LogtoConnector { const config = await this.getConfig(this.metadata.id); this.validateConfig(config); - assert(this.sendMessageBy, new ConnectorError(ConnectorErrorCodes.NotImplemented)); - return this.sendMessageBy({ to, type, payload }, config); }; public sendTestMessage: SendMessageFunction = async ({ to, type, payload }, config) => { this.validateConfig(config); - assert(this.sendMessageBy, new ConnectorError(ConnectorErrorCodes.NotImplemented)); - return this.sendMessageBy({ to, type, payload }, config); }; diff --git a/packages/connector-twilio-sms/src/index.ts b/packages/connector-twilio-sms/src/index.ts index dae802c5d..6abf68168 100644 --- a/packages/connector-twilio-sms/src/index.ts +++ b/packages/connector-twilio-sms/src/index.ts @@ -32,16 +32,12 @@ export default class TwilioSmsConnector extends LogtoConnector const config = await this.getConfig(this.metadata.id); this.validateConfig(config); - assert(this.sendMessageBy, new ConnectorError(ConnectorErrorCodes.NotImplemented)); - return this.sendMessageBy({ to, type, payload }, config); }; public sendTestMessage: SendMessageFunction = async ({ to, type, payload }, config) => { this.validateConfig(config); - assert(this.sendMessageBy, new ConnectorError(ConnectorErrorCodes.NotImplemented)); - return this.sendMessageBy({ to, type, payload }, config); };