Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2025-03-31 22:51:25 -05:00
Code Issues Activity

refactor(console): do not allow spaces in the permission name (#2935)

Browse source
This commit is contained in:
Xiao Yijun 2023-01-13 12:37:33 +08:00 • committed by GitHub
parent ef795ac592
commit cce723d12a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
10 changed files with 20 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
packages/console/src/pages/ApiResourceDetails/ApiResourcePermissions/components/CreatePermissionModal/index.tsx
View file

@ -1,3 +1,4 @@
import { noSpaceRegEx } from '@logto/core-kit';
import type { Scope } from '@logto/schemas';
import { useForm } from 'react-hook-form';
import { useTranslation } from 'react-i18next';
@ -22,7 +23,7 @@ const CreatePermissionModal = ({ resourceId, onClose }: Props) => {
const {
handleSubmit,
register,
formState: { isSubmitting },
formState: { isSubmitting, errors },
} = useForm<CreatePermissionFormData>();
const api = useApi();
@ -70,7 +71,15 @@ const CreatePermissionModal = ({ resourceId, onClose }: Props) => {
// eslint-disable-next-line jsx-a11y/no-autofocus
autoFocus
placeholder={t('api_resource_details.permission.name_placeholder')}
{...register('name', { required: true })}
{...register('name', {
required: true,
pattern: {
value: noSpaceRegEx,
message: t('api_resource_details.permission.forbidden_space_in_name'),
},
})}
hasError={Boolean(errors.name)}
errorMessage={errors.name?.message}
/>
</FormField>
<FormField title="api_resource_details.permission.description">

1
packages/phrases/src/locales/de/translation/admin-console/api-resource-details.ts
View file

@ -18,6 +18,7 @@ const api_resource_details = {
confirm_create: 'Create permission', // UNTRANSLATED
name: 'Permission name', // UNTRANSLATED
name_placeholder: 'Read:Resources', // UNTRANSLATED
forbidden_space_in_name: 'The permission name must not contain any spaces.', // UNTRANSLATED
description: 'Description', // UNTRANSLATED
description_placeholder: 'Able to read the resources', // UNTRANSLATED
permission_created: 'The permission {{name}} has been successfully created', // UNTRANSLATED

1
packages/phrases/src/locales/en/translation/admin-console/api-resource-details.ts
View file

@ -18,6 +18,7 @@ const api_resource_details = {
confirm_create: 'Create permission',
name: 'Permission name',
name_placeholder: 'Read:Resources',
forbidden_space_in_name: 'The permission name must not contain any spaces.',
description: 'Description',
description_placeholder: 'Able to read the resources',
permission_created: 'The permission {{name}} has been successfully created',

1
packages/phrases/src/locales/fr/translation/admin-console/api-resource-details.ts
View file

@ -18,6 +18,7 @@ const api_resource_details = {
confirm_create: 'Create permission', // UNTRANSLATED
name: 'Permission name', // UNTRANSLATED
name_placeholder: 'Read:Resources', // UNTRANSLATED
forbidden_space_in_name: 'The permission name must not contain any spaces.', // UNTRANSLATED
description: 'Description', // UNTRANSLATED
description_placeholder: 'Able to read the resources', // UNTRANSLATED
permission_created: 'The permission {{name}} has been successfully created', // UNTRANSLATED

1
packages/phrases/src/locales/ko/translation/admin-console/api-resource-details.ts
View file

@ -18,6 +18,7 @@ const api_resource_details = {
confirm_create: 'Create permission', // UNTRANSLATED
name: 'Permission name', // UNTRANSLATED
name_placeholder: 'Read:Resources', // UNTRANSLATED
forbidden_space_in_name: 'The permission name must not contain any spaces.', // UNTRANSLATED
description: 'Description', // UNTRANSLATED
description_placeholder: 'Able to read the resources', // UNTRANSLATED
permission_created: 'The permission {{name}} has been successfully created', // UNTRANSLATED

1
packages/phrases/src/locales/pt-br/translation/admin-console/api-resource-details.ts
View file

@ -18,6 +18,7 @@ const api_resource_details = {
confirm_create: 'Create permission', // UNTRANSLATED
name: 'Permission name', // UNTRANSLATED
name_placeholder: 'Read:Resources', // UNTRANSLATED
forbidden_space_in_name: 'The permission name must not contain any spaces.', // UNTRANSLATED
description: 'Description', // UNTRANSLATED
description_placeholder: 'Able to read the resources', // UNTRANSLATED
permission_created: 'The permission {{name}} has been successfully created', // UNTRANSLATED

1
packages/phrases/src/locales/pt-pt/translation/admin-console/api-resource-details.ts
View file

@ -18,6 +18,7 @@ const api_resource_details = {
confirm_create: 'Create permission', // UNTRANSLATED
name: 'Permission name', // UNTRANSLATED
name_placeholder: 'Read:Resources', // UNTRANSLATED
forbidden_space_in_name: 'The permission name must not contain any spaces.', // UNTRANSLATED
description: 'Description', // UNTRANSLATED
description_placeholder: 'Able to read the resources', // UNTRANSLATED
permission_created: 'The permission {{name}} has been successfully created', // UNTRANSLATED

1
packages/phrases/src/locales/tr-tr/translation/admin-console/api-resource-details.ts
View file

@ -18,6 +18,7 @@ const api_resource_details = {
confirm_create: 'Create permission', // UNTRANSLATED
name: 'Permission name', // UNTRANSLATED
name_placeholder: 'Read:Resources', // UNTRANSLATED
forbidden_space_in_name: 'The permission name must not contain any spaces.', // UNTRANSLATED
description: 'Description', // UNTRANSLATED
description_placeholder: 'Able to read the resources', // UNTRANSLATED
permission_created: 'The permission {{name}} has been successfully created', // UNTRANSLATED

1
packages/phrases/src/locales/zh-cn/translation/admin-console/api-resource-details.ts
View file

@ -18,6 +18,7 @@ const api_resource_details = {
confirm_create: 'Create permission', // UNTRANSLATED
name: 'Permission name', // UNTRANSLATED
name_placeholder: 'Read:Resources', // UNTRANSLATED
forbidden_space_in_name: 'The permission name must not contain any spaces.', // UNTRANSLATED
description: 'Description', // UNTRANSLATED
description_placeholder: 'Able to read the resources', // UNTRANSLATED
permission_created: 'The permission {{name}} has been successfully created', // UNTRANSLATED

1
packages/toolkit/core-kit/src/regex.ts
View file

@ -6,3 +6,4 @@ export const webRedirectUriProtocolRegEx = /^https?:$/;
export const mobileUriSchemeProtocolRegEx = /^[a-z][\d_a-z]*(\.[\d_a-z]+)+:$/;
export const hexColorRegEx = /^#[\da-f]{3}([\da-f]{3})?$/i;
export const dateRegex = /^\d{4}(-\d{2}){2}/;
export const noSpaceRegEx = /^\S+$/;