Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2025-01-27 21:39:16 -05:00
Code Issues Activity

refactor(core): refine webhook log payload (#3973)

Browse source 
rename log payload field `json` -> `hookRequest.body`
This commit is contained in:
Gao Sun 2023-06-05 23:46:36 +08:00 • committed by GitHub
parent 032b7f9d07
commit c54b8bb629
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
packages/core/src/libraries/hook/index.test.ts
View file

@ -100,10 +100,13 @@ describe('triggerInteractionHooks()', () => {
expect(calledPayload).toHaveProperty('key', 'TriggerHook.' + HookEvent.PostSignIn);
expect(calledPayload).toHaveProperty('payload.result', LogResult.Success);
expect(calledPayload).toHaveProperty('payload.hookId', 'foo');
expect(calledPayload).toHaveProperty('payload.json.event', HookEvent.PostSignIn);
expect(calledPayload).toHaveProperty('payload.json.interactionEvent', InteractionEvent.SignIn);
expect(calledPayload).toHaveProperty('payload.json.hookId', 'foo');
expect(calledPayload).toHaveProperty('payload.json.userId', '123');
expect(calledPayload).toHaveProperty('payload.hookRequest.body.event', HookEvent.PostSignIn);
expect(calledPayload).toHaveProperty(
'payload.hookRequest.body.interactionEvent',
InteractionEvent.SignIn
);
expect(calledPayload).toHaveProperty('payload.hookRequest.body.hookId', 'foo');
expect(calledPayload).toHaveProperty('payload.hookRequest.body.userId', '123');
expect(calledPayload).toHaveProperty('payload.response.statusCode', 200);
expect(calledPayload).toHaveProperty('payload.response.body.message', 'ok');
jest.useRealTimers();

2
packages/core/src/libraries/hook/index.ts
View file

@ -95,7 +95,7 @@ export const createHookLibrary = (queries: Queries) => {
const json: HookEventPayload = { hookId: id, ...payload };
const logEntry = new LogEntry(`TriggerHook.${hookEvent}`);
logEntry.append({ json, hookId: id });
logEntry.append({ hookId: id, hookRequest: { body: json } });
// Trigger web hook and log response
await sendWebhookRequest({