Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2025-02-03 21:48:55 -05:00
Code Issues Activity

refactor(core): rename sign-in-experience api paths from sign-in-ex to sign-in-exp (#392)

Browse source
This commit is contained in:
IceHe.xyz 2022-03-16 15:25:26 +08:00 • committed by GitHub
parent bff4a9860d
commit b288e8eb6c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
packages/core/src/routes/sign-in-experience.test.ts
View file

@ -18,13 +18,13 @@ jest.mock('@/queries/sign-in-experience', () => ({
describe('signInExperiences routes', () => { describe('signInExperiences routes', () => {
const signInExperienceRequester = createRequester({ authedRoutes: signInExperiencesRoutes }); const signInExperienceRequester = createRequester({ authedRoutes: signInExperiencesRoutes });
it('GET /sign-in-ex', async () => { it('GET /sign-in-exp', async () => {
const response = await signInExperienceRequester.get('/sign-in-ex'); const response = await signInExperienceRequester.get('/sign-in-exp');
expect(response.status).toEqual(200); expect(response.status).toEqual(200);
expect(response.body).toEqual(mockSignInExperience); expect(response.body).toEqual(mockSignInExperience);
}); });
it('PATCH /sign-in-ex/:id', async () => { it('PATCH /sign-in-exp/:id', async () => {
const branding: Branding = { const branding: Branding = {
primaryColor: '#000', primaryColor: '#000',
backgroundColor: '#fff', backgroundColor: '#fff',
@ -38,7 +38,7 @@ describe('signInExperiences routes', () => {
const socialSignInConnectorIds = ['abc', 'def']; const socialSignInConnectorIds = ['abc', 'def'];
const response = await signInExperienceRequester.patch('/sign-in-ex/default').send({ const response = await signInExperienceRequester.patch('/sign-in-exp/default').send({
branding, branding,
socialSignInConnectorIds, socialSignInConnectorIds,
}); });
@ -51,10 +51,10 @@ describe('signInExperiences routes', () => {
}); });
}); });
it('PATCH /sign-in-ex/:id should throw with invalid inputs', async () => { it('PATCH /sign-in-exp/:id should throw with invalid inputs', async () => {
const socialSignInConnectorIds = [123, 456]; const socialSignInConnectorIds = [123, 456];
const response = await signInExperienceRequester.patch('/sign-in-ex/default').send({ const response = await signInExperienceRequester.patch('/sign-in-exp/default').send({
socialSignInConnectorIds, socialSignInConnectorIds,
}); });
expect(response.status).toEqual(400); expect(response.status).toEqual(400);

6
packages/core/src/routes/sign-in-experience.ts
View file

@ -12,9 +12,9 @@ import { AuthedRouter } from './types';
export default function signInExperiencesRoutes<T extends AuthedRouter>(router: T) { export default function signInExperiencesRoutes<T extends AuthedRouter>(router: T) {
/** /**
* As we only support single signInExperience settings for V1 * As we only support single signInExperience settings for V1
* always return the default settings in DB for the /sign-in-ex get method * always return the default settings in DB for the /sign-in-exp get method
*/ */
router.get('/sign-in-ex', async (ctx, next) => { router.get('/sign-in-exp', async (ctx, next) => {
const signInExperience = await findDefaultSignInExperience(); const signInExperience = await findDefaultSignInExperience();
ctx.body = signInExperience; ctx.body = signInExperience;
@ -23,7 +23,7 @@ export default function signInExperiencesRoutes<T extends AuthedRouter>(router:
// TODO: LOG-1403 need to find a way to validate SignInMethod input // TODO: LOG-1403 need to find a way to validate SignInMethod input
router.patch( router.patch(
'/sign-in-ex/:id', '/sign-in-exp/:id',
koaGuard({ koaGuard({
params: object({ id: string().min(1) }), params: object({ id: string().min(1) }),
body: SignInExperiences.createGuard.omit({ id: true }).partial(), body: SignInExperiences.createGuard.omit({ id: true }).partial(),