Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2025-01-20 21:32:31 -05:00
Code Issues Activity

refactor(core,cloud): add ApplicationInsights URL to CSP directive (#3710)

Browse source
This commit is contained in:
Gao Sun 2023-04-19 13:48:20 +08:00 • committed by GitHub
parent 3e5b8dd796
commit afdbcb39d6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
packages/cloud/src/middleware/with-security-headers.ts
View file

@ -1,6 +1,7 @@
import type { IncomingMessage, ServerResponse } from 'node:http'; import type { IncomingMessage, ServerResponse } from 'node:http';
import { promisify } from 'node:util'; import { promisify } from 'node:util';
import { conditionalArray } from '@silverhand/essentials';
import type { NextFunction, HttpContext, RequestContext } from '@withtyped/server'; import type { NextFunction, HttpContext, RequestContext } from '@withtyped/server';
import helmet, { type HelmetOptions } from 'helmet'; import helmet, { type HelmetOptions } from 'helmet';
@ -34,7 +35,8 @@ export default function withSecurityHeaders<InputContext extends RequestContext>
const adminOrigins = adminUrlSet.origins; const adminOrigins = adminUrlSet.origins;
const cloudOrigins = cloudUrlSet.origins; const cloudOrigins = cloudUrlSet.origins;
const urlSetOrigins = urlSet.origins; const urlSetOrigins = urlSet.origins;
const developmentOrigins = isProduction ? [] : ['ws:']; const developmentOrigins = conditionalArray(!isProduction && 'ws:');
const appInsightsOrigins = ['https://*.applicationinsights.azure.com'];
return async ( return async (
context: InputContext, context: InputContext,
@ -96,6 +98,7 @@ export default function withSecurityHeaders<InputContext extends RequestContext>
...cloudOrigins, ...cloudOrigins,
...urlSetOrigins, ...urlSetOrigins,
...developmentOrigins, ...developmentOrigins,
...appInsightsOrigins,
], ],
frameSrc: ["'self'", ...urlSetOrigins], frameSrc: ["'self'", ...urlSetOrigins],
}, },

14
packages/core/src/middleware/koa-security-headers.ts
View file

@ -2,6 +2,7 @@ import { type IncomingMessage, type ServerResponse } from 'node:http';
import { promisify } from 'node:util'; import { promisify } from 'node:util';
import { defaultTenantId } from '@logto/schemas'; import { defaultTenantId } from '@logto/schemas';
import { conditionalArray } from '@silverhand/essentials';
import helmet, { type HelmetOptions } from 'helmet'; import helmet, { type HelmetOptions } from 'helmet';
import type { MiddlewareType } from 'koa'; import type { MiddlewareType } from 'koa';
@ -33,12 +34,13 @@ export default function koaSecurityHeaders<StateT, ContextT, ResponseBodyT>(
const { isProduction, isCloud, isMultiTenancy, adminUrlSet, cloudUrlSet } = EnvSet.values; const { isProduction, isCloud, isMultiTenancy, adminUrlSet, cloudUrlSet } = EnvSet.values;
const adminOrigins = adminUrlSet.origins; const adminOrigins = adminUrlSet.origins;
const cloudOrigins = isCloud ? cloudUrlSet.origins : []; const cloudOrigins = conditionalArray(isCloud && cloudUrlSet.origins);
const tenantEndpointOrigin = getTenantEndpoint( const tenantEndpointOrigin = getTenantEndpoint(
isMultiTenancy ? tenantId : defaultTenantId, isMultiTenancy ? tenantId : defaultTenantId,
EnvSet.values EnvSet.values
).origin; ).origin;
const developmentOrigins = isProduction ? [] : ['ws:']; const developmentOrigins = conditionalArray(!isProduction && 'ws:');
const appInsightsOrigins = ['https://*.applicationinsights.azure.com'];
/** /**
* Default Applied rules: * Default Applied rules:
@ -80,7 +82,13 @@ export default function koaSecurityHeaders<StateT, ContextT, ResponseBodyT>(
'upgrade-insecure-requests': null, 'upgrade-insecure-requests': null,
imgSrc: ["'self'", 'data:', 'https:'], imgSrc: ["'self'", 'data:', 'https:'],
scriptSrc: ["'self'", "'unsafe-eval'", "'unsafe-inline'"], scriptSrc: ["'self'", "'unsafe-eval'", "'unsafe-inline'"],
connectSrc: ["'self'", ...adminOrigins, ...cloudOrigins, ...developmentOrigins], connectSrc: [
"'self'",
...adminOrigins,
...cloudOrigins,
...developmentOrigins,
...appInsightsOrigins,
],
// WARNING: high risk Need to allow self hosted terms of use page loaded in an iframe // WARNING: high risk Need to allow self hosted terms of use page loaded in an iframe
frameSrc: ["'self'", 'https:'], frameSrc: ["'self'", 'https:'],
// Alow loaded by console preview iframe // Alow loaded by console preview iframe