diff --git a/.changeset/heavy-sloths-enjoy.md b/.changeset/heavy-sloths-enjoy.md new file mode 100644 index 000000000..9aa1915d7 --- /dev/null +++ b/.changeset/heavy-sloths-enjoy.md @@ -0,0 +1,5 @@ +--- +"@logto/console": patch +--- + +Should ignore empty number input box when parsing connector config form. diff --git a/.changeset/lemon-bears-reply.md b/.changeset/lemon-bears-reply.md new file mode 100644 index 000000000..c2796a553 --- /dev/null +++ b/.changeset/lemon-bears-reply.md @@ -0,0 +1,5 @@ +--- +"@logto/connector-saml": patch +--- + +Should use placeholder instead of default value. diff --git a/packages/connectors/connector-saml/src/constant.ts b/packages/connectors/connector-saml/src/constant.ts index 83534539b..f52e8cd7b 100644 --- a/packages/connectors/connector-saml/src/constant.ts +++ b/packages/connectors/connector-saml/src/constant.ts @@ -145,7 +145,7 @@ export const formItems: ConnectorConfigFormItem[] = [ type: ConnectorConfigFormItemType.Number, label: 'Timeout', key: 'timeout', - defaultValue: 5000, + placeholder: '5000', }, { type: ConnectorConfigFormItemType.Json, diff --git a/packages/console/src/pages/Connectors/components/ConnectorForm/utils.ts b/packages/console/src/pages/Connectors/components/ConnectorForm/utils.ts index 2cfdefac2..49344a5ef 100644 --- a/packages/console/src/pages/Connectors/components/ConnectorForm/utils.ts +++ b/packages/console/src/pages/Connectors/components/ConnectorForm/utils.ts @@ -38,8 +38,13 @@ export const parseFormConfig = (data: ConnectorFormType, formItems: ConnectorCon } if (formItem.type === ConnectorConfigFormItemType.Number) { + /** + * When set ReactHookForm valueAsNumber to true, the number input field + * will return number value. If the input can not be properly converted + * to number value, it will return NaN instead. + */ // The number input my return string value. - return [key, Number(value)]; + return Number.isNaN(value) ? null : [key, Number(value)]; } if (formItem.type === ConnectorConfigFormItemType.Json) {