fix(console): update user data (#1184)

packages/console/src/pages/UserDetails/index.tsx

@@ -69,7 +69,7 @@ const UserDetails = () => {
 
   const {
     field: { onChange, value },
-  } = useController({ name: 'customData', control, rules: { required: true } });
+  } = useController({ name: 'customData', control });
   const api = useApi();
 
   useEffect(() => {
@@ -87,7 +87,9 @@ const UserDetails = () => {
       return;
     }
 
-    const customData = safeParseJson(formData.customData);
+    const { customData: inputtedCustomData, name, avatar, roleNames } = formData;
+
+    const customData = inputtedCustomData ? safeParseJson(inputtedCustomData) : {};
 
     if (!customData) {
       toast.error(t('user_details.custom_data_invalid'));
@@ -96,9 +98,9 @@ const UserDetails = () => {
     }
 
     const payload: Partial<User> = {
-      name: formData.name,
+      name,
-      avatar: formData.avatar,
+      avatar,
-      roleNames: formData.roleNames,
+      roleNames,
       customData,
     };
 

packages/core/src/routes/admin-user.test.ts

@@ -162,6 +162,19 @@ describe('adminUserRoutes', () => {
     });
   });
 
+  it('PATCH /users/:userId should allow updated with empty avatar', async () => {
+    const name = 'Micheal';
+    const avatar = '';
+
+    const response = await userRequest.patch('/users/foo').send({ name, avatar });
+    expect(response.status).toEqual(200);
+    expect(response.body).toEqual({
+      ...mockUserResponse,
+      name,
+      avatar,
+    });
+  });
+
   it('PATCH /users/:userId should updated with one field if the other is undefined', async () => {
     const name = 'Micheal';
 

packages/core/src/routes/admin-user.ts

@@ -112,7 +112,7 @@ export default function adminUserRoutes<T extends AuthedRouter>(router: T) {
       params: object({ userId: string() }),
       body: object({
         name: string().nullable().optional(),
-        avatar: string().url().nullable().optional(),
+        avatar: string().url().or(literal('')).nullable().optional(),
         customData: arbitraryObjectGuard.optional(),
         roleNames: string().array().optional(),
       }),