From 9bcb11a2d80c5f5cc1f55692510d0f4974755bd5 Mon Sep 17 00:00:00 2001
From: Xiao Yijun <xiaoyijun@silverhand.io>
Date: Mon, 16 Jan 2023 15:12:06 +0800
Subject: [PATCH] refactor(console): make descriptions of the role and
 permission required (#2952)

---
 .../components/CreatePermissionModal/index.tsx             | 4 ++--
 .../console/src/pages/RoleDetails/RoleSettings/index.tsx   | 7 +++++--
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/packages/console/src/pages/ApiResourceDetails/ApiResourcePermissions/components/CreatePermissionModal/index.tsx b/packages/console/src/pages/ApiResourceDetails/ApiResourcePermissions/components/CreatePermissionModal/index.tsx
index a78febb5c..4a0a09632 100644
--- a/packages/console/src/pages/ApiResourceDetails/ApiResourcePermissions/components/CreatePermissionModal/index.tsx
+++ b/packages/console/src/pages/ApiResourceDetails/ApiResourcePermissions/components/CreatePermissionModal/index.tsx
@@ -82,10 +82,10 @@ const CreatePermissionModal = ({ resourceId, onClose }: Props) => {
               errorMessage={errors.name?.message}
             />
           </FormField>
-          <FormField title="api_resource_details.permission.description">
+          <FormField isRequired title="api_resource_details.permission.description">
             <TextInput
               placeholder={t('api_resource_details.permission.description_placeholder')}
-              {...register('description')}
+              {...register('description', { required: true })}
             />
           </FormField>
         </form>
diff --git a/packages/console/src/pages/RoleDetails/RoleSettings/index.tsx b/packages/console/src/pages/RoleDetails/RoleSettings/index.tsx
index 6de6d5302..824b99034 100644
--- a/packages/console/src/pages/RoleDetails/RoleSettings/index.tsx
+++ b/packages/console/src/pages/RoleDetails/RoleSettings/index.tsx
@@ -50,8 +50,11 @@ const RoleSettings = () => {
           <FormField isRequired title="role_details.field_name">
             <TextInput {...register('name', { required: true })} hasError={Boolean(errors.name)} />
           </FormField>
-          <FormField title="role_details.field_description">
-            <TextInput {...register('description')} hasError={Boolean(errors.description)} />
+          <FormField isRequired title="role_details.field_description">
+            <TextInput
+              {...register('description', { required: true })}
+              hasError={Boolean(errors.description)}
+            />
           </FormField>
         </FormCard>
       </DetailsForm>