Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2025-04-07 23:01:25 -05:00
Code Issues Activity

fix(console): fix disable sign-in password settings bug (#7199)

Browse source 
* fix(console): fix disable sign-in password settings bug

fix disabled sign-in password settings can not be saved bug

* fix(console): remove dummy code

remove dummy code
This commit is contained in:
simeng-li 2025-03-31 11:00:35 +08:00 • committed by GitHub
parent d9e51d1cec
commit 93a52df81a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 14 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
packages/console/src/pages/SignInExperience/PageContent/SignUpAndSignIn/SignUpForm/use-sign-up-password-listeners.ts
View file

@ -24,6 +24,15 @@ const useSignUpPasswordListeners = () => {
const signUpPassword = useWatch({ control, name: 'signUp.password' });
// We create a ref to store the submit count
// to avoid the password update effect to be triggered by the submit count change.
const submitCountRef = useRef(submitCount);
useEffect(() => {
// eslint-disable-next-line @silverhand/fp/no-mutation
submitCountRef.current = submitCount;
}, [submitCount]);
useEffect(() => {
// Only sync the password settings on updates (skip the first mount)
if (isFirstMount.current) {
@ -31,7 +40,6 @@ const useSignUpPasswordListeners = () => {
isFirstMount.current = false;
return;
}
const signInMethods = getValues('signIn.methods');
setValue(
@ -57,13 +65,16 @@ const useSignUpPasswordListeners = () => {
}
);
if (submitCount) {
// By default, the react-hook-form triggers validation only after the first submit.
// To keep the form validation behavior consistent, we trigger the validation manually
// if the form has been submitted at least once.
if (submitCountRef.current > 0) {
// Wait for the form re-render before validating the new data.
setTimeout(() => {
void trigger('signIn.methods');
}, 0);
}
}, [getValues, setValue, signUpPassword, submitCount, trigger]);
}, [getValues, setValue, signUpPassword, trigger]);
};
export default useSignUpPasswordListeners;