Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2024-12-16 20:26:19 -05:00
Code Issues Activity

chore(console): keep app description input field (#5283)

Browse source 
keep description input field for the third-party app
This commit is contained in:
simeng-li 2024-01-23 22:10:40 +08:00 committed by GitHub
parent 12fc67a039
commit 8eba064199
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
packages/console/src/pages/ApplicationDetails/ApplicationDetailsContent/Settings.tsx
View file

@ -6,7 +6,6 @@ import { Trans, useTranslation } from 'react-i18next';
import FormCard from '@/components/FormCard'; import FormCard from '@/components/FormCard';
import MultiTextInputField from '@/components/MultiTextInputField'; import MultiTextInputField from '@/components/MultiTextInputField';
import { isDevFeaturesEnabled } from '@/consts/env';
import FormField from '@/ds-components/FormField'; import FormField from '@/ds-components/FormField';
import type { MultiTextInputRule } from '@/ds-components/MultiTextInput/types'; import type { MultiTextInputRule } from '@/ds-components/MultiTextInput/types';
import { import {
@ -63,16 +62,12 @@ function Settings({ data }: Props) {
placeholder={t('application_details.application_name_placeholder')} placeholder={t('application_details.application_name_placeholder')}
/> />
</FormField> </FormField>
{/* Hide description field in third-party application's form. @simeng-li FIXME: remove isDevFeatureEnabled flag */} <FormField title="application_details.description">
{(!isDevFeaturesEnabled || !isThirdParty) && ( <TextInput
<FormField title="application_details.description"> {...register('description')}
<TextInput placeholder={t('application_details.description_placeholder')}
{...register('description')} />
placeholder={t('application_details.description_placeholder')} </FormField>
/>
</FormField>
)}
{applicationType !== ApplicationType.MachineToMachine && ( {applicationType !== ApplicationType.MachineToMachine && (
<Controller <Controller
name="oidcClientMetadata.redirectUris" name="oidcClientMetadata.redirectUris"