Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2025-01-27 21:39:16 -05:00
Code Issues Activity

refactor(console): optimize placeholder (#1353)

Browse source
This commit is contained in:
Gao Sun 2022-07-01 21:12:11 +08:00 • committed by GitHub
parent f6c5094a52
commit 8d664effc5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 17 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
packages/console/src/pages/ApplicationDetails/components/Settings.tsx
View file

@ -1,4 +1,4 @@
import { Application, SnakeCaseOidcConfig } from '@logto/schemas';
import { Application, ApplicationType, SnakeCaseOidcConfig } from '@logto/schemas';
import React from 'react';
import { Controller, useFormContext } from 'react-hook-form';
import { useTranslation } from 'react-i18next';
@ -14,10 +14,11 @@ import { uriOriginValidator, uriValidator } from '@/utilities/validator';
import * as styles from '../index.module.scss';
type Props = {
applicationType: ApplicationType;
oidcConfig: SnakeCaseOidcConfig;
};
const Settings = ({ oidcConfig }: Props) => {
const Settings = ({ applicationType, oidcConfig }: Props) => {
const {
control,
register,
@ -81,7 +82,11 @@ const Settings = ({ oidcConfig }: Props) => {
title="admin_console.application_details.redirect_uri"
value={value}
error={convertRhfErrorMessage(error?.message)}
placeholder={t('application_details.redirect_uri_placeholder')}
placeholder={
applicationType === ApplicationType.Native
? t('application_details.redirect_uri_placeholder_native')
: t('application_details.redirect_uri_placeholder')
}
onChange={onChange}
/>
)}

2
packages/console/src/pages/ApplicationDetails/index.tsx
View file

@ -180,7 +180,7 @@ const ApplicationDetails = () => {
{isAdvancedSettings ? (
<AdvancedSettings oidcConfig={oidcConfig} />
) : (
<Settings oidcConfig={oidcConfig} />
<Settings applicationType={data.type} oidcConfig={oidcConfig} />
)}
</div>
<div className={detailsStyles.footer}>

7
packages/phrases/src/locales/en.ts
View file

@ -126,11 +126,12 @@ const translation = {
description_placeholder: 'Enter your application description',
authorization_endpoint: 'Authorization endpoint',
redirect_uri: 'Redirect URIs',
redirect_uri_placeholder: 'https://myapp.com/sign-in',
redirect_uri_placeholder: 'https://your.website.com/app',
redirect_uri_placeholder_native: 'io.logto://callback',
post_sign_out_redirect_uri: 'Post Sign-out Redirect URIs',
post_sign_out_redirect_uri_placeholder: 'https://myapp.com/sign-in',
post_sign_out_redirect_uri_placeholder: 'https://your.website.com/home',
cors_allowed_origins: 'CORS allowed origins',
cors_allowed_origins_placeholder: 'https://sign-in.mydomain.com',
cors_allowed_origins_placeholder: 'https://your.website.com',
add_another: 'Add Another',
id_token_expiration: 'ID Token expiration',
refresh_token_expiration: 'Refresh Token expiration',

7
packages/phrases/src/locales/zh-cn.ts
View file

@ -123,11 +123,12 @@ const translation = {
description_placeholder: '请输入应用描述',
authorization_endpoint: 'Authorization Endpoint',
redirect_uri: 'Redirect URIs',
redirect_uri_placeholder: 'https://myapp.com/sign-in',
redirect_uri_placeholder: 'https://your.website.com/app',
redirect_uri_placeholder_native: 'io.logto://callback',
post_sign_out_redirect_uri: 'Post sign out redirect URIs',
post_sign_out_redirect_uri_placeholder: 'https://myapp.com/sign-in',
post_sign_out_redirect_uri_placeholder: 'https://your.website.com/home',
cors_allowed_origins: 'CORS Allowed Origins',
cors_allowed_origins_placeholder: 'https://sign-in.mydomain.com',
cors_allowed_origins_placeholder: 'https://your.website.com',
add_another: '新增',
id_token_expiration: 'ID Token 过期时间',
refresh_token_expiration: 'Refresh Token 过期时间',