Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2025-02-03 21:48:55 -05:00
Code Issues Activity

chore: remove TODOs with linear issues (#1495)

Browse source 
* chore: remove TODOs with linear issues

* chore: remove simeng TODOs

* chore: remove simeng TODOs
This commit is contained in:
Darcy Ye 2022-07-08 22:47:55 +08:00 • committed by GitHub
parent 30314cc628
commit 82ed2fe169
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/console/src/pages/Connectors/components/Guide/index.tsx
View file

@ -32,7 +32,7 @@ const Guide = ({ connector, onClose }: Props) => {
const { id: connectorId, type: connectorType, name, configTemplate, readme } = connector; const { id: connectorId, type: connectorType, name, configTemplate, readme } = connector;
const locale = i18next.language; const locale = i18next.language;
// TODO: LOG-2393 should fix name[locale] syntax error
const foundName = Object.entries(name).find(([lang]) => lang === locale); const foundName = Object.entries(name).find(([lang]) => lang === locale);
const connectorName = foundName ? foundName[1] : name.en; const connectorName = foundName ? foundName[1] : name.en;
const isSocialConnector = const isSocialConnector =

1
packages/core/src/lib/passcode.ts
View file

@ -106,7 +106,6 @@ export const verifyPasscode = async (
} }
if (code !== passcode.code) { if (code !== passcode.code) {
// TODO use SQL's native +1
await updatePasscode({ await updatePasscode({
where: { id: passcode.id }, where: { id: passcode.id },
set: { tryCount: passcode.tryCount + 1 }, set: { tryCount: passcode.tryCount + 1 },

1
packages/core/src/routes/admin-user.ts
View file

@ -51,7 +51,6 @@ export default function adminUserRoutes<T extends AuthedRouter>(router: T) {
router.get( router.get(
'/users/:userId', '/users/:userId',
// TODO: No need to guard
koaGuard({ koaGuard({
params: object({ userId: string() }), params: object({ userId: string() }),
}), }),

2
packages/ui/src/utils/sign-in-experience.ts
View file

@ -1,6 +1,6 @@
/** /**
* Temp Solution for getting the sign in experience * Temp Solution for getting the sign in experience
* TODO: Remove this once we have a better way to get the sign in experience through SSR * Remove this once we have a better way to get the sign in experience through SSR
*/ */
import { SignInMethods } from '@logto/schemas'; import { SignInMethods } from '@logto/schemas';