Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2025-02-17 22:04:19 -05:00
Code Issues Activity

feat(core): log sending passcode with connector id (#824)

Browse source
This commit is contained in:
IceHe.xyz 2022-05-16 14:40:51 +08:00 • committed by GitHub
parent a85b9b6520
commit 82c7138683
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/core/src/routes/session.test.ts
View file

@ -76,12 +76,10 @@ jest.mock('@/queries/user', () => ({
hasUserWithPhone: async (phone: string) => phone === '13000000000',
hasUserWithEmail: async (email: string) => email === 'a@a.com',
}));
const sendPasscode = jest.fn();
const sendPasscode = jest.fn(async () => ({ connector: { id: 'connectorIdValue' } }));
jest.mock('@/lib/passcode', () => ({
createPasscode: async () => ({ id: 'id' }),
sendPasscode: () => {
sendPasscode();
},
sendPasscode: async () => sendPasscode(),
verifyPasscode: async (_a: unknown, _b: unknown, code: string) => {
if (code !== '1234') {
throw new RequestError('passcode.code_mismatch');

12
packages/core/src/routes/session.ts
View file

@ -103,7 +103,8 @@ export default function sessionRoutes<T extends AnonymousRouter>(router: T, prov
const passcode = await createPasscode(jti, PasscodeType.SignIn, { phone });
ctx.log(type, { passcode });
await sendPasscode(passcode);
const { connector } = await sendPasscode(passcode);
ctx.log(type, { connectorId: connector.id });
ctx.status = 204;
return next();
@ -152,7 +153,8 @@ export default function sessionRoutes<T extends AnonymousRouter>(router: T, prov
const passcode = await createPasscode(jti, PasscodeType.SignIn, { email });
ctx.log(type, { passcode });
await sendPasscode(passcode);
const { connector } = await sendPasscode(passcode);
ctx.log(type, { connectorId: connector.id });
ctx.status = 204;
return next();
@ -406,7 +408,8 @@ export default function sessionRoutes<T extends AnonymousRouter>(router: T, prov
const passcode = await createPasscode(jti, PasscodeType.Register, { phone });
ctx.log(type, { phone, passcode });
await sendPasscode(passcode);
const { connector } = await sendPasscode(passcode);
ctx.log(type, { connectorId: connector.id });
ctx.status = 204;
return next();
@ -456,7 +459,8 @@ export default function sessionRoutes<T extends AnonymousRouter>(router: T, prov
const passcode = await createPasscode(jti, PasscodeType.Register, { email });
ctx.log(type, { passcode });
await sendPasscode(passcode);
const { connector } = await sendPasscode(passcode);
ctx.log(type, { connectorId: connector.id });
ctx.status = 204;
return next();

4
packages/schemas/src/types/log.ts
View file

@ -24,6 +24,7 @@ interface RegisterUsernamePasswordLogPayload extends ArbitraryLogPayload {
interface RegisterEmailSendPasscodeLogPayload extends ArbitraryLogPayload {
email?: string;
passcode?: Passcode;
connectorId?: string;
}
interface RegisterEmailLogPayload extends ArbitraryLogPayload {
@ -35,6 +36,7 @@ interface RegisterEmailLogPayload extends ArbitraryLogPayload {
interface RegisterSmsSendPasscodeLogPayload extends ArbitraryLogPayload {
phone?: string;
passcode?: Passcode;
connectorId?: string;
}
interface RegisterSmsLogPayload extends ArbitraryLogPayload {
@ -64,6 +66,7 @@ interface SignInUsernamePasswordLogPayload extends ArbitraryLogPayload {
interface SignInEmailSendPasscodeLogPayload extends ArbitraryLogPayload {
email?: string;
passcode?: Passcode;
connectorId?: string;
}
interface SignInEmailLogPayload extends ArbitraryLogPayload {
@ -75,6 +78,7 @@ interface SignInEmailLogPayload extends ArbitraryLogPayload {
interface SignInSmsSendPasscodeLogPayload extends ArbitraryLogPayload {
phone?: string;
passcode?: Passcode;
connectorId?: string;
}
interface SignInSmsLogPayload extends ArbitraryLogPayload {