From 7d86bf323fb26ddd2acbded058f52bcc7f3c87a0 Mon Sep 17 00:00:00 2001
From: Xiao Yijun <xiaoyijun@silverhand.io>
Date: Mon, 25 Mar 2024 10:51:56 +0800
Subject: [PATCH] refactor(console): avoid nested modal content for role
 creation (#5544)

---
 .../components/CreateRoleModal/index.tsx      | 27 ++++++++++---------
 1 file changed, 15 insertions(+), 12 deletions(-)

diff --git a/packages/console/src/pages/Roles/components/CreateRoleModal/index.tsx b/packages/console/src/pages/Roles/components/CreateRoleModal/index.tsx
index 745b19cb6..1bc7e7525 100644
--- a/packages/console/src/pages/Roles/components/CreateRoleModal/index.tsx
+++ b/packages/console/src/pages/Roles/components/CreateRoleModal/index.tsx
@@ -32,6 +32,20 @@ function CreateRoleModal({ onClose }: Props) {
     onClose();
   };
 
+  // Show assign role modal after role is created
+  if (createdRole) {
+    return (
+      <AssignRoleModal
+        isRemindSkip
+        roleId={createdRole.id}
+        roleType={createdRole.type}
+        onClose={() => {
+          navigate(`/roles/${createdRole.id}`, { replace: true });
+        }}
+      />
+    );
+  }
+
   return (
     <ReactModal
       isOpen
@@ -40,18 +54,7 @@ function CreateRoleModal({ onClose }: Props) {
       overlayClassName={modalStyles.overlay}
       onRequestClose={onClose}
     >
-      {createdRole ? (
-        <AssignRoleModal
-          isRemindSkip
-          roleId={createdRole.id}
-          roleType={createdRole.type}
-          onClose={() => {
-            navigate(`/roles/${createdRole.id}`, { replace: true });
-          }}
-        />
-      ) : (
-        <CreateRoleForm onClose={onCreateFormClose} />
-      )}
+      <CreateRoleForm onClose={onCreateFormClose} />
     </ReactModal>
   );
 }