Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2025-04-07 23:01:25 -05:00
Code Issues Activity

chore: add changeset for the bug fix PR ()

Browse source 
add changeset for the bug fix PR
This commit is contained in:
simeng-li 2024-03-18 10:27:05 +08:00 • committed by GitHub
parent 82408b60c8
commit 7c22c50cbf
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 19 additions and 0 deletions

19
.changeset/thin-shoes-jog.md Normal file
View file

@ -0,0 +1,19 @@
---
"@logto/core": patch
---
Fix SSO connector new user authentication internal server error.
## Description
Thanks to the [issue](https://github.com/logto-io/logto/issues/5502) report, we found that the SSO connector new user authentication was causing an internal server error. Should return an 422 status code instead of 500. Frontend sign-in page can not handle the 500 error and complete the new user registration process.
### Root cause
When the SSO connector returns a new user that does not exist in the Logto database, the backend with throw a 422 error. Frontend relies the 422 error to redirect and complete the new user registration process.
However, the backend was throwing a 500 error instead. That is because we applied a strict API response status code guard at the koaGuard middleware level. The status code 422 was not listed. Therefore, the middleware threw a 500 error.
### Solution
We added the 422 status code to the koaGuard middleware. Now, the backend will return a 422 status code when the SSO connector returns a new user that does not exist in the Logto database. The frontend sign-in page can handle the 422 error and complete the new user registration process.