Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2025-02-17 22:04:19 -05:00
Code Issues Activity

refactor: apply suggestions from code review

Browse source 
Co-authored-by: Charles Zhao <charleszhao@silverhand.io>
This commit is contained in:
Gao Sun 2024-06-14 10:56:18 +08:00 • committed by GitHub
parent b50ba0b7e6
commit 6f0497d214
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/integration-tests/src/tests/console/backchannel-logout.test.ts
View file

@ -9,7 +9,7 @@
* - We cannot update demo app's OIDC client metadata via API, then it'll be tricky to add the * - We cannot update demo app's OIDC client metadata via API, then it'll be tricky to add the
* backchannel logout URI conditionally (use environment variables looks not right). * backchannel logout URI conditionally (use environment variables looks not right).
* - To trigger the backchannel logout on other apps, a [shared session](https://github.com/panva/node-oidc-provider/blob/f52140233146e77d0dcc34ee44fd2b95b488c8d9/lib/actions/end_session.js#L135) * - To trigger the backchannel logout on other apps, a [shared session](https://github.com/panva/node-oidc-provider/blob/f52140233146e77d0dcc34ee44fd2b95b488c8d9/lib/actions/end_session.js#L135)
* is required, which requires we to sign in with all the apps in the same browser session. This * is required, which requires us to sign in with all the apps in the same browser session. This
* sounds tricky. Since we can trust the `oidc-provider` library's implementation, we can just * sounds tricky. Since we can trust the `oidc-provider` library's implementation, we can just
* test the backchannel logout feature of the Console application. * test the backchannel logout feature of the Console application.
* *