Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2025-02-17 22:04:19 -05:00
Code Issues Activity

fix(core): sign in method requires at least one factor (#2384)

Browse source
This commit is contained in:
wangsijie 2022-11-10 15:45:21 +08:00 • committed by GitHub
parent 81aa4cd8ed
commit 697b84f3eb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 49 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
packages/core/src/lib/sign-in-experience/sign-in.test.ts
View file

@ -218,6 +218,7 @@ describe('validate sign-in', () => {
...mockSignInMethod,
identifier: SignInIdentifier.Email,
password: false,
verificationCode: true,
},
],
},
@ -261,4 +262,38 @@ describe('validate sign-in', () => {
})
);
});
it('throws when verification code and password are both disabled', () => {
expect(() => {
validateSignIn(
{
methods: [
{
...mockSignInMethod,
identifier: SignInIdentifier.Email,
verificationCode: false,
password: false,
},
{
...mockSignInMethod,
identifier: SignInIdentifier.Sms,
verificationCode: true,
password: false,
},
],
},
{
...mockSignUp,
identifier: SignUpIdentifier.Sms,
password: false,
verify: true,
},
enabledConnectors
);
}).toMatchError(
new RequestError({
code: 'sign_in_experiences.at_least_one_authentication_factor',
})
);
});
});

7
packages/core/src/lib/sign-in-experience/sign-in.ts
View file

@ -31,6 +31,13 @@ export const validateSignIn = (
);
}
assertThat(
signIn.methods.every(({ password, verificationCode }) => password || verificationCode),
new RequestError({
code: 'sign_in_experiences.at_least_one_authentication_factor',
})
);
switch (signUp.identifier) {
case SignUpIdentifier.Username: {
assertThat(

1
packages/phrases/src/locales/de/errors.ts
View file

@ -128,6 +128,7 @@ const errors = {
code_sign_in_must_be_enabled:
'Verification code sign in must be enabled when set a password is not required in sign up.', // UNTRANSLATED
unsupported_default_language: 'Die Sprache - {{language}} wird momentan nicht unterstützt.',
at_least_one_authentication_factor: 'You have to select at least one authentication factor.', // UNTRANSLATED
},
localization: {
cannot_delete_default_language:

1
packages/phrases/src/locales/en/errors.ts
View file

@ -126,6 +126,7 @@ const errors = {
code_sign_in_must_be_enabled:
'Verification code sign in must be enabled when set a password is not required in sign up.',
unsupported_default_language: 'This language - {{language}} is not supported at the moment.',
at_least_one_authentication_factor: 'You have to select at least one authentication factor.',
},
localization: {
cannot_delete_default_language:

1
packages/phrases/src/locales/fr/errors.ts
View file

@ -134,6 +134,7 @@ const errors = {
code_sign_in_must_be_enabled:
'Verification code sign in must be enabled when set a password is not required in sign up.', // UNTRANSLATED
unsupported_default_language: 'This language - {{language}} is not supported at the moment.', // UNTRANSLATED
at_least_one_authentication_factor: 'You have to select at least one authentication factor.', // UNTRANSLATED
},
localization: {
cannot_delete_default_language:

1
packages/phrases/src/locales/ko/errors.ts
View file

@ -123,6 +123,7 @@ const errors = {
code_sign_in_must_be_enabled:
'Verification code sign in must be enabled when set a password is not required in sign up.', // UNTRANSLATED
unsupported_default_language: 'This language - {{language}} is not supported at the moment.', // UNTRANSLATED
at_least_one_authentication_factor: 'You have to select at least one authentication factor.', // UNTRANSLATED
},
localization: {
cannot_delete_default_language:

1
packages/phrases/src/locales/pt-pt/errors.ts
View file

@ -129,6 +129,7 @@ const errors = {
code_sign_in_must_be_enabled:
'Verification code sign in must be enabled when set a password is not required in sign up.', // UNTRANSLATED
unsupported_default_language: 'This language - {{language}} is not supported at the moment.', // UNTRANSLATED
at_least_one_authentication_factor: 'You have to select at least one authentication factor.', // UNTRANSLATED
},
localization: {
cannot_delete_default_language:

1
packages/phrases/src/locales/tr-tr/errors.ts
View file

@ -127,6 +127,7 @@ const errors = {
code_sign_in_must_be_enabled:
'Verification code sign in must be enabled when set a password is not required in sign up.', // UNTRANSLATED
unsupported_default_language: 'This language - {{language}} is not supported at the moment.', // UNTRANSLATED
at_least_one_authentication_factor: 'You have to select at least one authentication factor.', // UNTRANSLATED
},
localization: {
cannot_delete_default_language:

1
packages/phrases/src/locales/zh-cn/errors.ts
View file

@ -119,6 +119,7 @@ const errors = {
code_sign_in_must_be_enabled:
'Verification code sign in must be enabled when set a password is not required in sign up.', // UNTRANSLATED
unsupported_default_language: '{{language}}无法选择为默认语言。',
at_least_one_authentication_factor: '至少要选择一个登录要素',
},
localization: {
cannot_delete_default_language: '你已设置{{languageTag}}为你的默认语言，你无法删除默认语言。',