fix(core): scope name cannot contain any spaces (#3007)

packages/core/src/routes/resource.test.ts

@@ -174,6 +174,17 @@ describe('resource routes', () => {
     });
   });
 
+  it('POST /resources/:id/scopes should throw with spaces in name', async () => {
+    const name = 'write users';
+    const description = 'description';
+
+    const response = await resourceRequest
+      .post('/resources/foo/scopes')
+      .send({ name, description });
+
+    expect(response.status).toEqual(400);
+  });
+
   it('PATCH /resources/:id/scopes/:scopeId', async () => {
     const name = 'write:users';
     const description = 'description';

packages/core/src/routes/resource.ts

@@ -186,6 +186,8 @@ export default function resourceRoutes<T extends AuthedRouter>(
         body,
       } = ctx.guard;
 
+      assertThat(!/\s/.test(body.name), 'scope.name_with_space');
+
       assertThat(
         !(await findScopeByNameAndResourceId(body.name, resourceId)),
         new RequestError({
@@ -218,6 +220,7 @@ export default function resourceRoutes<T extends AuthedRouter>(
       } = ctx.guard;
 
       if (body.name) {
+        assertThat(!/\s/.test(body.name), 'scope.name_with_space');
         assertThat(
           !(await findScopeByNameAndResourceId(body.name, resourceId, scopeId)),
           new RequestError({

packages/phrases/src/locales/de/errors.ts

@@ -184,6 +184,7 @@ const errors = {
   },
   scope: {
     name_exists: 'The scope name {{name}} is already in use', // UNTRANSLATED
+    name_with_space: 'The name of the scope cannot contain any spaces.', // UNTRANSLATED
   },
 };
 

packages/phrases/src/locales/en/errors.ts

@@ -183,6 +183,7 @@ const errors = {
   },
   scope: {
     name_exists: 'The scope name {{name}} is already in use',
+    name_with_space: 'The name of the scope cannot contain any spaces.',
   },
 };
 

packages/phrases/src/locales/fr/errors.ts

@@ -190,6 +190,7 @@ const errors = {
   },
   scope: {
     name_exists: 'The scope name {{name}} is already in use', // UNTRANSLATED
+    name_with_space: 'The name of the scope cannot contain any spaces.', // UNTRANSLATED
   },
 };
 

packages/phrases/src/locales/ko/errors.ts

@@ -177,6 +177,7 @@ const errors = {
   },
   scope: {
     name_exists: 'The scope name {{name}} is already in use', // UNTRANSLATED
+    name_with_space: 'The name of the scope cannot contain any spaces.', // UNTRANSLATED
   },
 };
 

packages/phrases/src/locales/pt-br/errors.ts

@@ -191,6 +191,7 @@ const errors = {
   },
   scope: {
     name_exists: 'The scope name {{name}} is already in use', // UNTRANSLATED
+    name_with_space: 'The name of the scope cannot contain any spaces.', // UNTRANSLATED
   },
 };
 

packages/phrases/src/locales/pt-pt/errors.ts

@@ -185,6 +185,7 @@ const errors = {
   },
   scope: {
     name_exists: 'The scope name {{name}} is already in use', // UNTRANSLATED
+    name_with_space: 'The name of the scope cannot contain any spaces.', // UNTRANSLATED
   },
 };
 

packages/phrases/src/locales/tr-tr/errors.ts

@@ -185,6 +185,7 @@ const errors = {
   },
   scope: {
     name_exists: 'The scope name {{name}} is already in use', // UNTRANSLATED
+    name_with_space: 'The name of the scope cannot contain any spaces.', // UNTRANSLATED
   },
 };
 

packages/phrases/src/locales/zh-cn/errors.ts

@@ -166,6 +166,7 @@ const errors = {
   },
   scope: {
     name_exists: 'The scope name {{name}} is already in use', // UNTRANSLATED
+    name_with_space: 'The name of the scope cannot contain any spaces.', // UNTRANSLATED
   },
 };