Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2024-12-16 20:26:19 -05:00
Code Issues Activity

chore(core): skip supplement validation in unit test

Browse source
This commit is contained in:
Gao Sun 2023-12-03 18:28:22 +08:00
parent f1150eca30
commit 5fa377dd24
No known key found for this signature in database
GPG key ID: 13EBE123E4773688
2 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/core/src/routes/swagger/index.test.ts
View file

@ -72,6 +72,7 @@ describe('GET /swagger.json', () => {
const testTagRouter = new Router(); const testTagRouter = new Router();
testTagRouter.get('/mock', () => ({})); testTagRouter.get('/mock', () => ({}));
testTagRouter.put('/.well-known', () => ({})); testTagRouter.put('/.well-known', () => ({}));
testTagRouter.put('/sso-connectors', () => ({}));
const swaggerRequest = createSwaggerRequest([testTagRouter]); const swaggerRequest = createSwaggerRequest([testTagRouter]);
const response = await swaggerRequest.get('/swagger.json'); const response = await swaggerRequest.get('/swagger.json');
@ -80,7 +81,10 @@ describe('GET /swagger.json', () => {
get: { tags: ['Mock'] }, get: { tags: ['Mock'] },
}, },
'/api/.well-known': { '/api/.well-known': {
put: { tags: ['Well known'] }, put: { tags: ['Well-known'] },
},
'/api/sso-connectors': {
put: { tags: ['SSO connectors'] },
}, },
}); });
}); });

9
packages/core/src/routes/swagger/index.ts
View file

@ -15,6 +15,7 @@ import type { WithGuardConfig } from '#src/middleware/koa-guard.js';
import { isGuardMiddleware } from '#src/middleware/koa-guard.js'; import { isGuardMiddleware } from '#src/middleware/koa-guard.js';
import { isPaginationMiddleware } from '#src/middleware/koa-pagination.js'; import { isPaginationMiddleware } from '#src/middleware/koa-pagination.js';
import assertThat from '#src/utils/assert-that.js'; import assertThat from '#src/utils/assert-that.js';
import { consoleLog } from '#src/utils/console.js';
import { translationSchemas, zodTypeToSwagger } from '#src/utils/zod.js'; import { translationSchemas, zodTypeToSwagger } from '#src/utils/zod.js';
import type { AnonymousRouter } from '../types.js'; import type { AnonymousRouter } from '../types.js';
@ -219,8 +220,12 @@ export default function swaggerRoutes<T extends AnonymousRouter, R extends Route
tags: [...tags].map((tag) => ({ name: tag })), tags: [...tags].map((tag) => ({ name: tag })),
}; };
for (const document of supplementDocuments) { if (EnvSet.values.isUnitTest) {
validateSupplement(baseDocument, document); consoleLog.warn('Skip validating supplement documents in unit test.');
} else {
for (const document of supplementDocuments) {
validateSupplement(baseDocument, document);
}
} }
const data = supplementDocuments.reduce( const data = supplementDocuments.reduce(