Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2025-01-27 21:39:16 -05:00
Code Issues Activity

refactor(core,schemas): remove passcode in logs (#916)

Browse source
This commit is contained in:
IceHe.xyz 2022-05-21 01:04:22 +08:00 • committed by GitHub
parent 9ccda932a4
commit 5d7f2e436c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/core/src/routes/session.ts
View file

@ -101,8 +101,6 @@ export default function sessionRoutes<T extends AnonymousRouter>(router: T, prov
);
const passcode = await createPasscode(jti, PasscodeType.SignIn, { phone });
ctx.log(type, { passcode });
const { connector } = await sendPasscode(passcode);
ctx.log(type, { connectorId: connector.id });
ctx.status = 204;
@ -151,8 +149,6 @@ export default function sessionRoutes<T extends AnonymousRouter>(router: T, prov
);
const passcode = await createPasscode(jti, PasscodeType.SignIn, { email });
ctx.log(type, { passcode });
const { connector } = await sendPasscode(passcode);
ctx.log(type, { connectorId: connector.id });
ctx.status = 204;
@ -403,8 +399,6 @@ export default function sessionRoutes<T extends AnonymousRouter>(router: T, prov
);
const passcode = await createPasscode(jti, PasscodeType.Register, { phone });
ctx.log(type, { phone, passcode });
const { connector } = await sendPasscode(passcode);
ctx.log(type, { connectorId: connector.id });
ctx.status = 204;
@ -454,8 +448,6 @@ export default function sessionRoutes<T extends AnonymousRouter>(router: T, prov
);
const passcode = await createPasscode(jti, PasscodeType.Register, { email });
ctx.log(type, { passcode });
const { connector } = await sendPasscode(passcode);
ctx.log(type, { connectorId: connector.id });
ctx.status = 204;

6
packages/schemas/src/types/log.ts
View file

@ -1,5 +1,3 @@
import { Passcode } from '../db-entries';
export enum LogResult {
Success = 'Success',
Error = 'Error',
@ -23,7 +21,6 @@ interface RegisterUsernamePasswordLogPayload extends ArbitraryLogPayload {
interface RegisterEmailSendPasscodeLogPayload extends ArbitraryLogPayload {
email?: string;
passcode?: Passcode;
connectorId?: string;
}
@ -35,7 +32,6 @@ interface RegisterEmailLogPayload extends ArbitraryLogPayload {
interface RegisterSmsSendPasscodeLogPayload extends ArbitraryLogPayload {
phone?: string;
passcode?: Passcode;
connectorId?: string;
}
@ -65,7 +61,6 @@ interface SignInUsernamePasswordLogPayload extends ArbitraryLogPayload {
interface SignInEmailSendPasscodeLogPayload extends ArbitraryLogPayload {
email?: string;
passcode?: Passcode;
connectorId?: string;
}
@ -77,7 +72,6 @@ interface SignInEmailLogPayload extends ArbitraryLogPayload {
interface SignInSmsSendPasscodeLogPayload extends ArbitraryLogPayload {
phone?: string;
passcode?: Passcode;
connectorId?: string;
}