mirror of
https://github.com/logto-io/logto.git
synced 2024-12-30 20:33:54 -05:00
Merge pull request #2704 from logto-io/gao-log-4638-core-koahooks-middleware-function
feat(core): interaction hooks
This commit is contained in:
commit
5bd2b31eb6
25 changed files with 442 additions and 167 deletions
|
@ -44,6 +44,7 @@
|
|||
"dotenv": "^16.0.0",
|
||||
"etag": "^1.8.1",
|
||||
"find-up": "^6.3.0",
|
||||
"got": "^12.5.3",
|
||||
"hash-wasm": "^4.9.0",
|
||||
"i18next": "^21.8.16",
|
||||
"iconv-lite": "0.6.3",
|
||||
|
|
|
@ -87,6 +87,9 @@ function createEnvSet() {
|
|||
|
||||
return queryClient;
|
||||
},
|
||||
get queryClientSafe() {
|
||||
return queryClient;
|
||||
},
|
||||
get oidc() {
|
||||
if (!oidc) {
|
||||
return throwNotLoadedError();
|
||||
|
|
|
@ -18,7 +18,7 @@ export const grantListener = (
|
|||
const { params } = ctx.oidc;
|
||||
|
||||
const log = ctx.createLog(
|
||||
`${token.Flow.ExchangeTokenBy}.${getExchangeByType(params?.grant_type)}`
|
||||
`${token.Type.ExchangeTokenBy}.${getExchangeByType(params?.grant_type)}`
|
||||
);
|
||||
|
||||
const { access_token, refresh_token, id_token, scope } = ctx.body;
|
||||
|
|
|
@ -1,23 +1,24 @@
|
|||
import { noop } from '@silverhand/essentials';
|
||||
import Koa from 'koa';
|
||||
|
||||
import initApp from './app/init.js';
|
||||
import { configDotEnv } from './env-set/dot-env.js';
|
||||
import envSet from './env-set/index.js';
|
||||
import initI18n from './i18n/init.js';
|
||||
|
||||
// Update after we migrate to ESM
|
||||
// eslint-disable-next-line unicorn/prefer-top-level-await
|
||||
(async () => {
|
||||
try {
|
||||
try {
|
||||
await configDotEnv();
|
||||
await envSet.load();
|
||||
const app = new Koa({
|
||||
proxy: envSet.values.trustProxyHeader,
|
||||
});
|
||||
await initI18n();
|
||||
|
||||
// Import last until init completed
|
||||
const { default: initApp } = await import('./app/init.js');
|
||||
await initApp(app);
|
||||
} catch (error: unknown) {
|
||||
console.log('Error while initializing app', error);
|
||||
await envSet.poolSafe?.end();
|
||||
}
|
||||
})();
|
||||
} catch (error: unknown) {
|
||||
console.error('Error while initializing app:');
|
||||
console.error(error);
|
||||
|
||||
await Promise.all([envSet.poolSafe?.end(), envSet.queryClientSafe?.end()]).catch(noop);
|
||||
}
|
||||
|
|
89
packages/core/src/libraries/hook.test.ts
Normal file
89
packages/core/src/libraries/hook.test.ts
Normal file
|
@ -0,0 +1,89 @@
|
|||
import { Event } from '@logto/schemas';
|
||||
import { HookEvent } from '@logto/schemas/lib/models/hooks.js';
|
||||
import { mockEsm, mockEsmDefault } from '@logto/shared/esm';
|
||||
import type { InferModelType } from '@withtyped/server';
|
||||
import { got } from 'got';
|
||||
|
||||
import modelRouters from '#src/model-routers/index.js';
|
||||
import { MockQueryClient } from '#src/test-utils/query-client.js';
|
||||
|
||||
import type { Interaction } from './hook.js';
|
||||
|
||||
const { jest } = import.meta;
|
||||
|
||||
const queryClient = new MockQueryClient();
|
||||
const queryFunction = jest.fn();
|
||||
|
||||
const url = 'https://logto.gg';
|
||||
const hook: InferModelType<typeof modelRouters.hook.model> = {
|
||||
id: 'foo',
|
||||
event: HookEvent.PostSignIn,
|
||||
config: { headers: { bar: 'baz' }, url, retries: 3 },
|
||||
createdAt: new Date(),
|
||||
};
|
||||
const readAll = jest
|
||||
.spyOn(modelRouters.hook.client, 'readAll')
|
||||
.mockResolvedValue({ rows: [hook], rowCount: 1 });
|
||||
|
||||
// @ts-expect-error for testing
|
||||
const post = jest.spyOn(got, 'post').mockImplementation(jest.fn(() => ({ json: jest.fn() })));
|
||||
|
||||
mockEsm('#src/queries/user.js', () => ({
|
||||
findUserById: () => ({ id: 'user_id', username: 'user', extraField: 'not_ok' }),
|
||||
}));
|
||||
mockEsm('#src/queries/application.js', () => ({
|
||||
findApplicationById: () => ({ id: 'app_id', extraField: 'not_ok' }),
|
||||
}));
|
||||
|
||||
// eslint-disable-next-line unicorn/consistent-function-scoping
|
||||
mockEsmDefault('#src/env-set/create-query-client-by-env.js', () => () => queryClient);
|
||||
jest.spyOn(queryClient, 'query').mockImplementation(queryFunction);
|
||||
|
||||
const { triggerInteractionHooksIfNeeded } = await import('./hook.js');
|
||||
|
||||
describe('triggerInteractionHooksIfNeeded()', () => {
|
||||
afterEach(() => {
|
||||
jest.clearAllMocks();
|
||||
});
|
||||
|
||||
it('should return if no user ID found', async () => {
|
||||
await triggerInteractionHooksIfNeeded();
|
||||
|
||||
expect(queryFunction).not.toBeCalled();
|
||||
});
|
||||
|
||||
it('should set correct payload when hook triggered', async () => {
|
||||
jest.useFakeTimers().setSystemTime(100_000);
|
||||
|
||||
await triggerInteractionHooksIfNeeded(
|
||||
// @ts-expect-error for testing
|
||||
{
|
||||
jti: 'some_jti',
|
||||
result: {
|
||||
login: { accountId: '123' },
|
||||
event: Event.SignIn,
|
||||
identifier: { connectorId: 'bar' },
|
||||
},
|
||||
params: { client_id: 'some_client' },
|
||||
} as Interaction
|
||||
);
|
||||
|
||||
expect(readAll).toHaveBeenCalled();
|
||||
expect(post).toHaveBeenCalledWith(url, {
|
||||
headers: { 'user-agent': 'Logto (https://logto.io)', bar: 'baz' },
|
||||
json: {
|
||||
hookId: 'foo',
|
||||
event: 'PostSignIn',
|
||||
interactionEvent: 'SignIn',
|
||||
sessionId: 'some_jti',
|
||||
userId: '123',
|
||||
user: { id: 'user_id', username: 'user' },
|
||||
application: { id: 'app_id' },
|
||||
createdAt: new Date(100_000).toISOString(),
|
||||
},
|
||||
retry: { limit: 3 },
|
||||
timeout: { request: 10_000 },
|
||||
});
|
||||
jest.useRealTimers();
|
||||
});
|
||||
});
|
72
packages/core/src/libraries/hook.ts
Normal file
72
packages/core/src/libraries/hook.ts
Normal file
|
@ -0,0 +1,72 @@
|
|||
import { Event, userInfoSelectFields } from '@logto/schemas';
|
||||
import { HookEventPayload, HookEvent } from '@logto/schemas/models';
|
||||
import { trySafe } from '@logto/shared';
|
||||
import { conditional, pick } from '@silverhand/essentials';
|
||||
import { got } from 'got';
|
||||
import type { Provider } from 'oidc-provider';
|
||||
|
||||
import modelRouters from '#src/model-routers/index.js';
|
||||
import { findApplicationById } from '#src/queries/application.js';
|
||||
import { findUserById } from '#src/queries/user.js';
|
||||
import { getInteractionStorage } from '#src/routes/interaction/utils/interaction.js';
|
||||
|
||||
const eventToHook: Record<Event, HookEvent> = {
|
||||
[Event.Register]: HookEvent.PostRegister,
|
||||
[Event.SignIn]: HookEvent.PostSignIn,
|
||||
[Event.ForgotPassword]: HookEvent.PostResetPassword,
|
||||
};
|
||||
|
||||
export type Interaction = Awaited<ReturnType<Provider['interactionDetails']>>;
|
||||
|
||||
export const triggerInteractionHooksIfNeeded = async (
|
||||
details?: Interaction,
|
||||
userAgent?: string
|
||||
) => {
|
||||
const userId = details?.result?.login?.accountId;
|
||||
const sessionId = details?.jti;
|
||||
const applicationId = details?.params.client_id;
|
||||
|
||||
if (!userId) {
|
||||
return;
|
||||
}
|
||||
|
||||
const interactionPayload = getInteractionStorage(details.result);
|
||||
const { event } = interactionPayload;
|
||||
|
||||
const hookEvent = eventToHook[event];
|
||||
const { rows } = await modelRouters.hook.client.readAll();
|
||||
|
||||
const [user, application] = await Promise.all([
|
||||
trySafe(findUserById(userId)),
|
||||
trySafe(async () =>
|
||||
conditional(typeof applicationId === 'string' && (await findApplicationById(applicationId)))
|
||||
),
|
||||
]);
|
||||
|
||||
const payload = {
|
||||
event: hookEvent,
|
||||
interactionEvent: event,
|
||||
createdAt: new Date().toISOString(),
|
||||
sessionId,
|
||||
userAgent,
|
||||
userId,
|
||||
user: user && pick(user, ...userInfoSelectFields),
|
||||
application: application && pick(application, 'id', 'type', 'name', 'description'),
|
||||
} satisfies Omit<HookEventPayload, 'hookId'>;
|
||||
|
||||
await Promise.all(
|
||||
rows
|
||||
.filter(({ event }) => event === hookEvent)
|
||||
.map(async ({ config: { url, headers, retries }, id }) => {
|
||||
const json: HookEventPayload = { hookId: id, ...payload };
|
||||
await got
|
||||
.post(url, {
|
||||
headers: { 'user-agent': 'Logto (https://logto.io)', ...headers },
|
||||
json,
|
||||
retry: { limit: retries },
|
||||
timeout: { request: 10_000 },
|
||||
})
|
||||
.json();
|
||||
})
|
||||
);
|
||||
};
|
10
packages/core/src/model-routers/index.ts
Normal file
10
packages/core/src/model-routers/index.ts
Normal file
|
@ -0,0 +1,10 @@
|
|||
import { Hooks } from '@logto/schemas/lib/models/hooks.js';
|
||||
import { createModelRouter } from '@withtyped/postgres';
|
||||
|
||||
import envSet from '#src/env-set/index.js';
|
||||
|
||||
const modelRouters = {
|
||||
hook: createModelRouter(Hooks, envSet.queryClient).withCrud(),
|
||||
};
|
||||
|
||||
export default modelRouters;
|
|
@ -59,7 +59,7 @@ export const getDailyActiveUserCountsByTimeInterval = async (
|
|||
from ${table}
|
||||
where ${fields.createdAt} > to_timestamp(${startTimeExclusive}::double precision / 1000)
|
||||
and ${fields.createdAt} <= to_timestamp(${endTimeInclusive}::double precision / 1000)
|
||||
and ${fields.key} like ${`${token.Flow.ExchangeTokenBy}.%`}
|
||||
and ${fields.key} like ${`${token.Type.ExchangeTokenBy}.%`}
|
||||
and ${fields.payload}->>'result' = 'Success'
|
||||
group by date(${fields.createdAt})
|
||||
`);
|
||||
|
@ -73,6 +73,6 @@ export const countActiveUsersByTimeInterval = async (
|
|||
from ${table}
|
||||
where ${fields.createdAt} > to_timestamp(${startTimeExclusive}::double precision / 1000)
|
||||
and ${fields.createdAt} <= to_timestamp(${endTimeInclusive}::double precision / 1000)
|
||||
and ${fields.key} like ${`${token.Flow.ExchangeTokenBy}.%`}
|
||||
and ${fields.key} like ${`${token.Type.ExchangeTokenBy}.%`}
|
||||
and ${fields.payload}->>'result' = 'Success'
|
||||
`);
|
||||
|
|
|
@ -1,11 +1,9 @@
|
|||
import { Hooks } from '@logto/schemas/models';
|
||||
import { createModelRouter } from '@withtyped/postgres';
|
||||
import { koaAdapter, RequestError } from '@withtyped/server';
|
||||
import type { MiddlewareType } from 'koa';
|
||||
import koaBody from 'koa-body';
|
||||
|
||||
import envSet from '#src/env-set/index.js';
|
||||
import LogtoRequestError from '#src/errors/RequestError/index.js';
|
||||
import modelRouters from '#src/model-routers/index.js';
|
||||
|
||||
import type { AuthedRouter } from './types.js';
|
||||
|
||||
|
@ -26,7 +24,5 @@ const errorHandler: MiddlewareType = async (_, next) => {
|
|||
};
|
||||
|
||||
export default function hookRoutes<T extends AuthedRouter>(router: T) {
|
||||
const modelRouter = createModelRouter(Hooks, envSet.queryClient).withCrud();
|
||||
|
||||
router.all('/hooks/(.*)?', koaBody(), errorHandler, koaAdapter(modelRouter.routes()));
|
||||
router.all('/hooks/(.*)?', koaBody(), errorHandler, koaAdapter(modelRouters.hook.routes()));
|
||||
}
|
||||
|
|
|
@ -45,21 +45,22 @@ await mockEsmWithActual('#src/connectors/index.js', () => ({
|
|||
}),
|
||||
}));
|
||||
|
||||
await mockEsmWithActual('#src/libraries/sign-in-experience/index.js', () => ({
|
||||
getSignInExperienceForApplication: jest.fn().mockResolvedValue(mockSignInExperience),
|
||||
}));
|
||||
|
||||
const { assignInteractionResults } = await mockEsmWithActual('#src/libraries/session.js', () => ({
|
||||
assignInteractionResults: jest.fn(),
|
||||
}));
|
||||
|
||||
const {
|
||||
getSignInExperience,
|
||||
verifySignInModeSettings,
|
||||
verifyIdentifierSettings,
|
||||
verifyProfileSettings,
|
||||
} = mockEsm('./utils/sign-in-experience-validation.js', () => ({
|
||||
getSignInExperience: jest.fn(async () => mockSignInExperience),
|
||||
const { verifySignInModeSettings, verifyIdentifierSettings, verifyProfileSettings } = mockEsm(
|
||||
'./utils/sign-in-experience-validation.js',
|
||||
() => ({
|
||||
verifySignInModeSettings: jest.fn(),
|
||||
verifyIdentifierSettings: jest.fn(),
|
||||
verifyProfileSettings: jest.fn(),
|
||||
}));
|
||||
})
|
||||
);
|
||||
|
||||
const submitInteraction = mockEsmDefault('./actions/submit-interaction.js', () => jest.fn());
|
||||
|
||||
|
@ -133,7 +134,6 @@ describe('session -> interactionRoutes', () => {
|
|||
profile: { phone: '1234567890' },
|
||||
};
|
||||
const response = await sessionRequest.put(path).send(body);
|
||||
expect(getSignInExperience).toBeCalled();
|
||||
expect(verifySignInModeSettings).toBeCalled();
|
||||
expect(verifyIdentifierSettings).toBeCalled();
|
||||
expect(verifyProfileSettings).toBeCalled();
|
||||
|
@ -154,7 +154,7 @@ describe('session -> interactionRoutes', () => {
|
|||
const path = `${interactionPrefix}/event`;
|
||||
|
||||
it('should call verifySignInModeSettings properly', async () => {
|
||||
getInteractionStorage.mockResolvedValueOnce({
|
||||
getInteractionStorage.mockReturnValueOnce({
|
||||
event: Event.SignIn,
|
||||
});
|
||||
const body = {
|
||||
|
@ -169,7 +169,7 @@ describe('session -> interactionRoutes', () => {
|
|||
});
|
||||
|
||||
it('should reject if switch sign-in event to forgot-password directly', async () => {
|
||||
getInteractionStorage.mockResolvedValueOnce({
|
||||
getInteractionStorage.mockReturnValueOnce({
|
||||
event: Event.SignIn,
|
||||
});
|
||||
|
||||
|
@ -184,7 +184,7 @@ describe('session -> interactionRoutes', () => {
|
|||
});
|
||||
|
||||
it('should reject if switch forgot-password to sign-in directly', async () => {
|
||||
getInteractionStorage.mockResolvedValueOnce({
|
||||
getInteractionStorage.mockReturnValueOnce({
|
||||
event: Event.ForgotPassword,
|
||||
});
|
||||
|
||||
|
@ -272,7 +272,7 @@ describe('session -> interactionRoutes', () => {
|
|||
});
|
||||
|
||||
it('should not call validateMandatoryUserProfile for forgot password request', async () => {
|
||||
getInteractionStorage.mockResolvedValueOnce({
|
||||
getInteractionStorage.mockReturnValueOnce({
|
||||
event: Event.ForgotPassword,
|
||||
});
|
||||
|
||||
|
|
|
@ -1,6 +1,6 @@
|
|||
import type { LogtoErrorCode } from '@logto/phrases';
|
||||
import { Event, eventGuard, identifierPayloadGuard, profileGuard } from '@logto/schemas';
|
||||
import { conditional } from '@silverhand/essentials';
|
||||
import type Router from 'koa-router';
|
||||
import type { Provider } from 'oidc-provider';
|
||||
import { z } from 'zod';
|
||||
|
||||
|
@ -12,6 +12,10 @@ import assertThat from '#src/utils/assert-that.js';
|
|||
|
||||
import type { AnonymousRouter } from '../types.js';
|
||||
import submitInteraction from './actions/submit-interaction.js';
|
||||
import koaInteractionDetails from './middleware/koa-interaction-details.js';
|
||||
import type { WithInteractionDetailsContext } from './middleware/koa-interaction-details.js';
|
||||
import koaInteractionHooks from './middleware/koa-interaction-hooks.js';
|
||||
import koaInteractionSie from './middleware/koa-interaction-sie.js';
|
||||
import { sendPasscodePayloadGuard, socialAuthorizationUrlPayloadGuard } from './types/guard.js';
|
||||
import {
|
||||
getInteractionStorage,
|
||||
|
@ -20,7 +24,6 @@ import {
|
|||
} from './utils/interaction.js';
|
||||
import { sendPasscodeToIdentifier } from './utils/passcode-validation.js';
|
||||
import {
|
||||
getSignInExperience,
|
||||
verifySignInModeSettings,
|
||||
verifyIdentifierSettings,
|
||||
verifyProfileSettings,
|
||||
|
@ -36,27 +39,19 @@ import {
|
|||
export const interactionPrefix = '/interaction';
|
||||
export const verificationPath = 'verification';
|
||||
|
||||
type RouterContext<T> = T extends Router<unknown, infer Context> ? Context : never;
|
||||
|
||||
export default function interactionRoutes<T extends AnonymousRouter>(
|
||||
router: T,
|
||||
anonymousRouter: T,
|
||||
provider: Provider
|
||||
) {
|
||||
router.use(koaAuditLog(), async (ctx, next) => {
|
||||
await next();
|
||||
|
||||
// Prepend interaction context to log entries
|
||||
try {
|
||||
const {
|
||||
jti,
|
||||
params: { client_id },
|
||||
} = await provider.interactionDetails(ctx.req, ctx.res);
|
||||
ctx.prependAllLogEntries({
|
||||
sessionId: jti,
|
||||
applicationId: conditional(typeof client_id === 'string' && client_id),
|
||||
});
|
||||
} catch (error: unknown) {
|
||||
console.error(`Failed to get oidc provider interaction details`, error);
|
||||
}
|
||||
});
|
||||
const router =
|
||||
// @ts-expect-error for good koa types
|
||||
// eslint-disable-next-line no-restricted-syntax
|
||||
(anonymousRouter as Router<unknown, WithInteractionDetailsContext<RouterContext<T>>>).use(
|
||||
koaAuditLog(),
|
||||
koaInteractionDetails(provider)
|
||||
);
|
||||
|
||||
// Create a new interaction
|
||||
router.put(
|
||||
|
@ -68,18 +63,19 @@ export default function interactionRoutes<T extends AnonymousRouter>(
|
|||
profile: profileGuard.optional(),
|
||||
}),
|
||||
}),
|
||||
koaInteractionSie(),
|
||||
async (ctx, next) => {
|
||||
const { event, identifier, profile } = ctx.guard.body;
|
||||
const experience = await getSignInExperience(ctx, provider);
|
||||
const { signInExperience } = ctx;
|
||||
|
||||
verifySignInModeSettings(event, experience);
|
||||
verifySignInModeSettings(event, signInExperience);
|
||||
|
||||
if (identifier) {
|
||||
verifyIdentifierSettings(identifier, experience);
|
||||
verifyIdentifierSettings(identifier, signInExperience);
|
||||
}
|
||||
|
||||
if (profile) {
|
||||
verifyProfileSettings(profile, experience);
|
||||
verifyProfileSettings(profile, signInExperience);
|
||||
}
|
||||
|
||||
const verifiedIdentifier = identifier && [
|
||||
|
@ -102,7 +98,6 @@ export default function interactionRoutes<T extends AnonymousRouter>(
|
|||
|
||||
// Delete Interaction
|
||||
router.delete(interactionPrefix, async (ctx, next) => {
|
||||
await provider.interactionDetails(ctx.req, ctx.res);
|
||||
const error: LogtoErrorCode = 'oidc.aborted';
|
||||
await assignInteractionResults(ctx, provider, { error });
|
||||
|
||||
|
@ -113,11 +108,14 @@ export default function interactionRoutes<T extends AnonymousRouter>(
|
|||
router.put(
|
||||
`${interactionPrefix}/event`,
|
||||
koaGuard({ body: z.object({ event: eventGuard }) }),
|
||||
koaInteractionSie(),
|
||||
async (ctx, next) => {
|
||||
const { event } = ctx.guard.body;
|
||||
verifySignInModeSettings(event, await getSignInExperience(ctx, provider));
|
||||
const { signInExperience, interactionDetails } = ctx;
|
||||
|
||||
const interactionStorage = await getInteractionStorage(ctx, provider);
|
||||
verifySignInModeSettings(event, signInExperience);
|
||||
|
||||
const interactionStorage = getInteractionStorage(interactionDetails.result);
|
||||
|
||||
// Forgot Password specific event interaction storage can't be shared with other types of interactions
|
||||
assertThat(
|
||||
|
@ -143,11 +141,13 @@ export default function interactionRoutes<T extends AnonymousRouter>(
|
|||
koaGuard({
|
||||
body: identifierPayloadGuard,
|
||||
}),
|
||||
koaInteractionSie(),
|
||||
async (ctx, next) => {
|
||||
const identifierPayload = ctx.guard.body;
|
||||
verifyIdentifierSettings(identifierPayload, await getSignInExperience(ctx, provider));
|
||||
const { signInExperience, interactionDetails } = ctx;
|
||||
verifyIdentifierSettings(identifierPayload, signInExperience);
|
||||
|
||||
const interactionStorage = await getInteractionStorage(ctx, provider);
|
||||
const interactionStorage = getInteractionStorage(interactionDetails.result);
|
||||
|
||||
const verifiedIdentifier = await verifyIdentifierPayload(
|
||||
ctx,
|
||||
|
@ -172,11 +172,13 @@ export default function interactionRoutes<T extends AnonymousRouter>(
|
|||
koaGuard({
|
||||
body: profileGuard,
|
||||
}),
|
||||
koaInteractionSie(),
|
||||
async (ctx, next) => {
|
||||
const profilePayload = ctx.guard.body;
|
||||
verifyProfileSettings(profilePayload, await getSignInExperience(ctx, provider));
|
||||
const { signInExperience, interactionDetails } = ctx;
|
||||
verifyProfileSettings(profilePayload, signInExperience);
|
||||
|
||||
const interactionStorage = await getInteractionStorage(ctx, provider);
|
||||
const interactionStorage = getInteractionStorage(interactionDetails.result);
|
||||
|
||||
await storeInteractionResult(
|
||||
{
|
||||
|
@ -198,7 +200,8 @@ export default function interactionRoutes<T extends AnonymousRouter>(
|
|||
|
||||
// Delete Interaction Profile
|
||||
router.delete(`${interactionPrefix}/profile`, async (ctx, next) => {
|
||||
const interactionStorage = await getInteractionStorage(ctx, provider);
|
||||
const { interactionDetails } = ctx;
|
||||
const interactionStorage = getInteractionStorage(interactionDetails.result);
|
||||
const { profile, ...rest } = interactionStorage;
|
||||
await storeInteractionResult(rest, ctx, provider);
|
||||
|
||||
|
@ -208,8 +211,13 @@ export default function interactionRoutes<T extends AnonymousRouter>(
|
|||
});
|
||||
|
||||
// Submit Interaction
|
||||
router.post(`${interactionPrefix}/submit`, async (ctx, next) => {
|
||||
const interactionStorage = await getInteractionStorage(ctx, provider);
|
||||
router.post(
|
||||
`${interactionPrefix}/submit`,
|
||||
koaInteractionSie(),
|
||||
koaInteractionHooks(),
|
||||
async (ctx, next) => {
|
||||
const { interactionDetails } = ctx;
|
||||
const interactionStorage = getInteractionStorage(interactionDetails.result);
|
||||
|
||||
const { event } = interactionStorage;
|
||||
|
||||
|
@ -218,13 +226,14 @@ export default function interactionRoutes<T extends AnonymousRouter>(
|
|||
const verifiedInteraction = await verifyProfile(accountVerifiedInteraction);
|
||||
|
||||
if (event !== Event.ForgotPassword) {
|
||||
await validateMandatoryUserProfile(ctx, provider, verifiedInteraction);
|
||||
await validateMandatoryUserProfile(ctx, verifiedInteraction);
|
||||
}
|
||||
|
||||
await submitInteraction(verifiedInteraction, ctx, provider);
|
||||
|
||||
return next();
|
||||
});
|
||||
}
|
||||
);
|
||||
|
||||
// Create social authorization url interaction verification
|
||||
router.post(
|
||||
|
@ -232,7 +241,7 @@ export default function interactionRoutes<T extends AnonymousRouter>(
|
|||
koaGuard({ body: socialAuthorizationUrlPayloadGuard }),
|
||||
async (ctx, next) => {
|
||||
// Check interaction exists
|
||||
await getInteractionStorage(ctx, provider);
|
||||
getInteractionStorage(ctx.interactionDetails.result);
|
||||
|
||||
const { body: payload } = ctx.guard;
|
||||
|
||||
|
@ -251,11 +260,11 @@ export default function interactionRoutes<T extends AnonymousRouter>(
|
|||
body: sendPasscodePayloadGuard,
|
||||
}),
|
||||
async (ctx, next) => {
|
||||
const { interactionDetails, guard, createLog } = ctx;
|
||||
// Check interaction exists
|
||||
await getInteractionStorage(ctx, provider);
|
||||
getInteractionStorage(interactionDetails.result);
|
||||
|
||||
const { jti } = await provider.interactionDetails(ctx.req, ctx.res);
|
||||
await sendPasscodeToIdentifier(ctx.guard.body, jti, ctx.createLog);
|
||||
await sendPasscodeToIdentifier(guard.body, interactionDetails.jti, createLog);
|
||||
|
||||
ctx.status = 204;
|
||||
|
||||
|
|
|
@ -0,0 +1,18 @@
|
|||
import type { MiddlewareType } from 'koa';
|
||||
import type { Provider } from 'oidc-provider';
|
||||
|
||||
import type { WithLogContext } from '#src/middleware/koa-audit-log.js';
|
||||
|
||||
export type WithInteractionDetailsContext<ContextT = WithLogContext> = ContextT & {
|
||||
interactionDetails: Awaited<ReturnType<Provider['interactionDetails']>>;
|
||||
};
|
||||
|
||||
export default function koaInteractionDetails<StateT, ContextT>(
|
||||
provider: Provider
|
||||
): MiddlewareType<StateT, WithInteractionDetailsContext<ContextT>> {
|
||||
return async (ctx, next) => {
|
||||
ctx.interactionDetails = await provider.interactionDetails(ctx.req, ctx.res);
|
||||
|
||||
return next();
|
||||
};
|
||||
}
|
|
@ -0,0 +1,18 @@
|
|||
import type { MiddlewareType } from 'koa';
|
||||
import type { IRouterParamContext } from 'koa-router';
|
||||
|
||||
import { triggerInteractionHooksIfNeeded } from '#src/libraries/hook.js';
|
||||
|
||||
import type { WithInteractionDetailsContext } from './koa-interaction-details.js';
|
||||
|
||||
export default function koaInteractionHooks<
|
||||
StateT,
|
||||
ContextT extends WithInteractionDetailsContext<IRouterParamContext>,
|
||||
ResponseT
|
||||
>(): MiddlewareType<StateT, ContextT, ResponseT> {
|
||||
return async (ctx, next) => {
|
||||
await next();
|
||||
|
||||
void triggerInteractionHooksIfNeeded(ctx.interactionDetails, ctx.header['user-agent']);
|
||||
};
|
||||
}
|
|
@ -0,0 +1,32 @@
|
|||
import type { SignInExperience } from '@logto/schemas';
|
||||
import { conditional } from '@silverhand/essentials';
|
||||
import type { MiddlewareType } from 'koa';
|
||||
|
||||
import { getSignInExperienceForApplication } from '#src/libraries/sign-in-experience/index.js';
|
||||
|
||||
import type { WithInteractionDetailsContext } from './koa-interaction-details.js';
|
||||
|
||||
export type WithInteractionSieContext<ContextT> = WithInteractionDetailsContext<ContextT> & {
|
||||
signInExperience: SignInExperience;
|
||||
};
|
||||
|
||||
export default function koaInteractionSie<StateT, ContextT, ResponseT>(): MiddlewareType<
|
||||
StateT,
|
||||
WithInteractionSieContext<ContextT>,
|
||||
ResponseT
|
||||
> {
|
||||
return async (ctx, next) => {
|
||||
const { interactionDetails } = ctx;
|
||||
|
||||
const signInExperience = await getSignInExperienceForApplication(
|
||||
conditional(
|
||||
typeof interactionDetails.params.client_id === 'string' &&
|
||||
interactionDetails.params.client_id
|
||||
)
|
||||
);
|
||||
|
||||
ctx.signInExperience = signInExperience;
|
||||
|
||||
return next();
|
||||
};
|
||||
}
|
|
@ -2,7 +2,7 @@ import type { ConnectorSession } from '@logto/connector-kit';
|
|||
import { connectorSessionGuard } from '@logto/connector-kit';
|
||||
import type { Event, Profile } from '@logto/schemas';
|
||||
import type { Context } from 'koa';
|
||||
import type { Provider } from 'oidc-provider';
|
||||
import type { Provider, InteractionResults } from 'oidc-provider';
|
||||
import { z } from 'zod';
|
||||
|
||||
import RequestError from '#src/errors/RequestError/index.js';
|
||||
|
@ -83,10 +83,6 @@ export const isAccountVerifiedInteractionResult = (
|
|||
interaction: AnonymousInteractionResult
|
||||
): interaction is AccountVerifiedInteractionResult => Boolean(interaction.accountId);
|
||||
|
||||
type Options = {
|
||||
merge?: boolean;
|
||||
};
|
||||
|
||||
export const storeInteractionResult = async (
|
||||
interaction: Omit<AnonymousInteractionResult, 'event'> & { event?: Event },
|
||||
ctx: Context,
|
||||
|
@ -107,12 +103,10 @@ export const storeInteractionResult = async (
|
|||
);
|
||||
};
|
||||
|
||||
export const getInteractionStorage = async (
|
||||
ctx: Context,
|
||||
provider: Provider
|
||||
): Promise<AnonymousInteractionResult> => {
|
||||
const { result } = await provider.interactionDetails(ctx.req, ctx.res);
|
||||
const parseResult = anonymousInteractionResultGuard.safeParse(result);
|
||||
export const getInteractionStorage = (
|
||||
interaction?: InteractionResults
|
||||
): AnonymousInteractionResult => {
|
||||
const parseResult = anonymousInteractionResultGuard.safeParse(interaction);
|
||||
|
||||
assertThat(
|
||||
parseResult.success,
|
||||
|
|
|
@ -1,10 +1,7 @@
|
|||
import type { SignInExperience, Profile, IdentifierPayload } from '@logto/schemas';
|
||||
import { SignInMode, SignInIdentifier, Event } from '@logto/schemas';
|
||||
import type { Context } from 'koa';
|
||||
import type { Provider } from 'oidc-provider';
|
||||
|
||||
import RequestError from '#src/errors/RequestError/index.js';
|
||||
import { getSignInExperienceForApplication } from '#src/libraries/sign-in-experience/index.js';
|
||||
import assertThat from '#src/utils/assert-that.js';
|
||||
|
||||
const forbiddenEventError = new RequestError({ code: 'auth.forbidden', status: 403 });
|
||||
|
@ -122,11 +119,3 @@ export const verifyProfileSettings = (profile: Profile, { signUp }: SignInExperi
|
|||
assertThat(signUp.password, forbiddenIdentifierError);
|
||||
}
|
||||
};
|
||||
|
||||
export const getSignInExperience = async (ctx: Context, provider: Provider) => {
|
||||
const interaction = await provider.interactionDetails(ctx.req, ctx.res);
|
||||
|
||||
return getSignInExperienceForApplication(
|
||||
typeof interaction.params.client_id === 'string' ? interaction.params.client_id : undefined
|
||||
);
|
||||
};
|
||||
|
|
|
@ -1,5 +1,6 @@
|
|||
import { Event, MissingProfile, SignInIdentifier } from '@logto/schemas';
|
||||
import { mockEsm, mockEsmWithActual, pickDefault } from '@logto/shared/esm';
|
||||
import type { Provider } from 'oidc-provider';
|
||||
|
||||
import { mockSignInExperience } from '#src/__mocks__/sign-in-experience.js';
|
||||
import RequestError from '#src/errors/RequestError/index.js';
|
||||
|
@ -18,24 +19,25 @@ const { isUserPasswordSet } = mockEsm('../utils/index.js', () => ({
|
|||
isUserPasswordSet: jest.fn(),
|
||||
}));
|
||||
|
||||
const { getSignInExperience } = mockEsm('../utils/sign-in-experience-validation.js', () => ({
|
||||
getSignInExperience: jest.fn().mockReturnValue(mockSignInExperience),
|
||||
}));
|
||||
|
||||
const validateMandatoryUserProfile = await pickDefault(
|
||||
import('./mandatory-user-profile-validation.js')
|
||||
);
|
||||
|
||||
describe('validateMandatoryUserProfile', () => {
|
||||
const provider = createMockProvider();
|
||||
const baseCtx = createContextWithRouteParameters();
|
||||
const baseCtx = {
|
||||
...createContextWithRouteParameters(),
|
||||
// eslint-disable-next-line @typescript-eslint/consistent-type-assertions
|
||||
interactionDetails: {} as Awaited<ReturnType<Provider['interactionDetails']>>,
|
||||
signInExperience: mockSignInExperience,
|
||||
};
|
||||
const interaction: IdentifierVerifiedInteractionResult = {
|
||||
event: Event.SignIn,
|
||||
accountId: 'foo',
|
||||
};
|
||||
|
||||
it('username and password missing but required', async () => {
|
||||
await expect(validateMandatoryUserProfile(baseCtx, provider, interaction)).rejects.toMatchError(
|
||||
await expect(validateMandatoryUserProfile(baseCtx, interaction)).rejects.toMatchError(
|
||||
new RequestError(
|
||||
{ code: 'user.missing_profile', status: 422 },
|
||||
{ missingProfile: [MissingProfile.password, MissingProfile.username] }
|
||||
|
@ -43,7 +45,7 @@ describe('validateMandatoryUserProfile', () => {
|
|||
);
|
||||
|
||||
await expect(
|
||||
validateMandatoryUserProfile(baseCtx, provider, {
|
||||
validateMandatoryUserProfile(baseCtx, {
|
||||
...interaction,
|
||||
profile: {
|
||||
username: 'username',
|
||||
|
@ -59,18 +61,19 @@ describe('validateMandatoryUserProfile', () => {
|
|||
});
|
||||
isUserPasswordSet.mockResolvedValueOnce(true);
|
||||
|
||||
await expect(
|
||||
validateMandatoryUserProfile(baseCtx, provider, interaction)
|
||||
).resolves.not.toThrow();
|
||||
await expect(validateMandatoryUserProfile(baseCtx, interaction)).resolves.not.toThrow();
|
||||
});
|
||||
|
||||
it('email missing but required', async () => {
|
||||
getSignInExperience.mockResolvedValueOnce({
|
||||
const ctx = {
|
||||
...baseCtx,
|
||||
signInExperience: {
|
||||
...mockSignInExperience,
|
||||
signUp: { identifiers: [SignInIdentifier.Email], password: false, verify: true },
|
||||
});
|
||||
},
|
||||
};
|
||||
|
||||
await expect(validateMandatoryUserProfile(baseCtx, provider, interaction)).rejects.toMatchError(
|
||||
await expect(validateMandatoryUserProfile(ctx, interaction)).rejects.toMatchError(
|
||||
new RequestError(
|
||||
{ code: 'user.missing_profile', status: 422 },
|
||||
{ missingProfile: [MissingProfile.email] }
|
||||
|
@ -83,23 +86,27 @@ describe('validateMandatoryUserProfile', () => {
|
|||
primaryEmail: 'email',
|
||||
});
|
||||
|
||||
getSignInExperience.mockResolvedValueOnce({
|
||||
const ctx = {
|
||||
...baseCtx,
|
||||
signInExperience: {
|
||||
...mockSignInExperience,
|
||||
signUp: { identifiers: [SignInIdentifier.Email], password: false, verify: true },
|
||||
});
|
||||
},
|
||||
};
|
||||
|
||||
await expect(
|
||||
validateMandatoryUserProfile(baseCtx, provider, interaction)
|
||||
).resolves.not.toThrow();
|
||||
await expect(validateMandatoryUserProfile(ctx, interaction)).resolves.not.toThrow();
|
||||
});
|
||||
|
||||
it('phone missing but required', async () => {
|
||||
getSignInExperience.mockResolvedValueOnce({
|
||||
const ctx = {
|
||||
...baseCtx,
|
||||
signInExperience: {
|
||||
...mockSignInExperience,
|
||||
signUp: { identifiers: [SignInIdentifier.Sms], password: false, verify: true },
|
||||
});
|
||||
},
|
||||
};
|
||||
|
||||
await expect(validateMandatoryUserProfile(baseCtx, provider, interaction)).rejects.toMatchError(
|
||||
await expect(validateMandatoryUserProfile(ctx, interaction)).rejects.toMatchError(
|
||||
new RequestError(
|
||||
{ code: 'user.missing_profile', status: 422 },
|
||||
{ missingProfile: [MissingProfile.phone] }
|
||||
|
@ -112,27 +119,31 @@ describe('validateMandatoryUserProfile', () => {
|
|||
primaryPhone: 'phone',
|
||||
});
|
||||
|
||||
getSignInExperience.mockResolvedValueOnce({
|
||||
const ctx = {
|
||||
...baseCtx,
|
||||
signInExperience: {
|
||||
...mockSignInExperience,
|
||||
signUp: { identifiers: [SignInIdentifier.Sms], password: false, verify: true },
|
||||
});
|
||||
},
|
||||
};
|
||||
|
||||
await expect(
|
||||
validateMandatoryUserProfile(baseCtx, provider, interaction)
|
||||
).resolves.not.toThrow();
|
||||
await expect(validateMandatoryUserProfile(ctx, interaction)).resolves.not.toThrow();
|
||||
});
|
||||
|
||||
it('email or Phone required', async () => {
|
||||
getSignInExperience.mockResolvedValue({
|
||||
const ctx = {
|
||||
...baseCtx,
|
||||
signInExperience: {
|
||||
...mockSignInExperience,
|
||||
signUp: {
|
||||
identifiers: [SignInIdentifier.Email, SignInIdentifier.Sms],
|
||||
password: false,
|
||||
verify: true,
|
||||
},
|
||||
});
|
||||
},
|
||||
};
|
||||
|
||||
await expect(validateMandatoryUserProfile(baseCtx, provider, interaction)).rejects.toMatchError(
|
||||
await expect(validateMandatoryUserProfile(ctx, interaction)).rejects.toMatchError(
|
||||
new RequestError(
|
||||
{ code: 'user.missing_profile', status: 422 },
|
||||
{ missingProfile: [MissingProfile.emailOrPhone] }
|
||||
|
@ -140,14 +151,14 @@ describe('validateMandatoryUserProfile', () => {
|
|||
);
|
||||
|
||||
await expect(
|
||||
validateMandatoryUserProfile(baseCtx, provider, {
|
||||
validateMandatoryUserProfile(ctx, {
|
||||
...interaction,
|
||||
profile: { email: 'email' },
|
||||
})
|
||||
).resolves.not.toThrow();
|
||||
|
||||
await expect(
|
||||
validateMandatoryUserProfile(baseCtx, provider, {
|
||||
validateMandatoryUserProfile(ctx, {
|
||||
...interaction,
|
||||
profile: { phone: '123456' },
|
||||
})
|
||||
|
|
|
@ -2,15 +2,14 @@ import type { Profile, SignInExperience, User } from '@logto/schemas';
|
|||
import { Event, MissingProfile, SignInIdentifier } from '@logto/schemas';
|
||||
import type { Nullable } from '@silverhand/essentials';
|
||||
import type { Context } from 'koa';
|
||||
import type { Provider } from 'oidc-provider';
|
||||
|
||||
import RequestError from '#src/errors/RequestError/index.js';
|
||||
import { findUserById } from '#src/queries/user.js';
|
||||
import assertThat from '#src/utils/assert-that.js';
|
||||
|
||||
import type { WithInteractionSieContext } from '../middleware/koa-interaction-sie.js';
|
||||
import type { IdentifierVerifiedInteractionResult } from '../types/index.js';
|
||||
import { isUserPasswordSet } from '../utils/index.js';
|
||||
import { getSignInExperience } from '../utils/sign-in-experience-validation.js';
|
||||
|
||||
// eslint-disable-next-line complexity
|
||||
const getMissingProfileBySignUpIdentifiers = ({
|
||||
|
@ -71,11 +70,10 @@ const getMissingProfileBySignUpIdentifiers = ({
|
|||
};
|
||||
|
||||
export default async function validateMandatoryUserProfile(
|
||||
ctx: Context,
|
||||
provider: Provider,
|
||||
ctx: WithInteractionSieContext<Context>,
|
||||
interaction: IdentifierVerifiedInteractionResult
|
||||
) {
|
||||
const { signUp } = await getSignInExperience(ctx, provider);
|
||||
const { signUp } = ctx.signInExperience;
|
||||
const { event, accountId, profile } = interaction;
|
||||
|
||||
const user = event === Event.Register ? null : await findUserById(accountId);
|
||||
|
|
|
@ -6,7 +6,7 @@ import type { WithLogContext } from '#src/middleware/koa-audit-log.js';
|
|||
import type { WithAuthContext } from '#src/middleware/koa-auth.js';
|
||||
import type { WithI18nContext } from '#src/middleware/koa-i18next.js';
|
||||
|
||||
export type AnonymousRouter = Router<unknown, WithLogContext & WithI18nContext & ExtendableContext>;
|
||||
export type AnonymousRouter = Router<unknown, WithLogContext & WithI18nContext>;
|
||||
|
||||
/** @deprecated This will be removed soon. Use `kua-log-session.js` instead. */
|
||||
export type AnonymousRouterLegacy = Router<unknown, WithLogContextLegacy & WithI18nContext>;
|
||||
|
|
|
@ -2,12 +2,26 @@ import { generateStandardId } from '@logto/core-kit';
|
|||
import { createModel } from '@withtyped/server';
|
||||
import { z } from 'zod';
|
||||
|
||||
import type { Application, User } from '../db-entries/index.js';
|
||||
import type { userInfoSelectFields } from '../types/index.js';
|
||||
|
||||
export enum HookEvent {
|
||||
PostRegister = 'PostRegister',
|
||||
PostSignIn = 'PostSignIn',
|
||||
PostForgotPassword = 'PostForgotPassword',
|
||||
PostResetPassword = 'PostResetPassword',
|
||||
}
|
||||
|
||||
export type HookEventPayload = {
|
||||
hookId: string;
|
||||
event: HookEvent;
|
||||
createdAt: string;
|
||||
sessionId?: string;
|
||||
userAgent?: string;
|
||||
userId?: string;
|
||||
user?: Pick<User, typeof userInfoSelectFields[number]>;
|
||||
application?: Pick<Application, 'id' | 'type' | 'name' | 'description'>;
|
||||
} & Record<string, unknown>;
|
||||
|
||||
export type HookConfig = {
|
||||
/** We don't need `type` since v1 only has web hook */
|
||||
// type: 'web';
|
||||
|
|
8
packages/schemas/src/types/log/hook.ts
Normal file
8
packages/schemas/src/types/log/hook.ts
Normal file
|
@ -0,0 +1,8 @@
|
|||
import type { HookEvent } from '../../models/hooks.js';
|
||||
|
||||
/** The type of a hook event. */
|
||||
export enum Type {
|
||||
ExchangeTokenBy = 'TriggerHook',
|
||||
}
|
||||
|
||||
export type LogKey = `${Type}.${HookEvent}`;
|
|
@ -1,11 +1,13 @@
|
|||
import type { ZodType } from 'zod';
|
||||
import { z } from 'zod';
|
||||
|
||||
import type * as hook from './hook.js';
|
||||
import type * as interaction from './interaction.js';
|
||||
import type * as token from './token.js';
|
||||
|
||||
export * as interaction from './interaction.js';
|
||||
export * as token from './token.js';
|
||||
export * as hook from './hook.js';
|
||||
|
||||
/** Fallback for empty or unrecognized log keys. */
|
||||
export const LogKeyUnknown = 'Unknown';
|
||||
|
@ -17,7 +19,7 @@ export const LogKeyUnknown = 'Unknown';
|
|||
* @see {@link interaction.LogKey} for interaction log keys.
|
||||
* @see {@link token.LogKey} for token log keys.
|
||||
**/
|
||||
export type LogKey = typeof LogKeyUnknown | interaction.LogKey | token.LogKey;
|
||||
export type LogKey = typeof LogKeyUnknown | interaction.LogKey | token.LogKey | hook.LogKey;
|
||||
|
||||
export enum LogResult {
|
||||
Success = 'Success',
|
||||
|
|
|
@ -1,5 +1,5 @@
|
|||
/** The type of a token flow. */
|
||||
export enum Flow {
|
||||
/** The type of a token event. */
|
||||
export enum Type {
|
||||
ExchangeTokenBy = 'ExchangeTokenBy',
|
||||
RevokeToken = 'RevokeToken',
|
||||
}
|
||||
|
@ -22,4 +22,4 @@ export enum ExchangeByType {
|
|||
ClientCredentials = 'ClientCredentials',
|
||||
}
|
||||
|
||||
export type LogKey = `${Flow.ExchangeTokenBy}.${ExchangeByType}` | `${Flow.RevokeToken}`;
|
||||
export type LogKey = `${Type.ExchangeTokenBy}.${ExchangeByType}` | `${Type.RevokeToken}`;
|
||||
|
|
|
@ -14,3 +14,11 @@ export const tryThat = async <T, E extends Error>(
|
|||
return onError(error);
|
||||
}
|
||||
};
|
||||
|
||||
export const trySafe = async <T>(exec: Promise<T> | (() => Promise<T>)): Promise<T | undefined> => {
|
||||
try {
|
||||
return await (typeof exec === 'function' ? exec() : exec);
|
||||
} catch (error: unknown) {
|
||||
console.error('trySafe() caught error', error);
|
||||
}
|
||||
};
|
||||
|
|
|
@ -282,6 +282,7 @@ importers:
|
|||
eslint: ^8.21.0
|
||||
etag: ^1.8.1
|
||||
find-up: ^6.3.0
|
||||
got: ^12.5.3
|
||||
hash-wasm: ^4.9.0
|
||||
http-errors: ^1.6.3
|
||||
i18next: ^21.8.16
|
||||
|
@ -336,6 +337,7 @@ importers:
|
|||
dotenv: 16.0.0
|
||||
etag: 1.8.1
|
||||
find-up: 6.3.0
|
||||
got: 12.5.3
|
||||
hash-wasm: 4.9.0
|
||||
i18next: 21.8.16
|
||||
iconv-lite: 0.6.3
|
||||
|
|
Loading…
Reference in a new issue