From 533d68193933a3f627b066ab1507774ccc962930 Mon Sep 17 00:00:00 2001
From: Xiao Yijun <xiaoyijun@silverhand.io>
Date: Mon, 4 Sep 2023 19:03:15 +0800
Subject: [PATCH] refactor(console): remove add connectors tip when no social
 connector is set up (#4422)

---
 .../SocialConnectorEditBox/index.tsx          | 24 ++++++++++---------
 1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/packages/console/src/pages/SignInExperience/tabs/SignUpAndSignIn/components/SocialConnectorEditBox/index.tsx b/packages/console/src/pages/SignInExperience/tabs/SignUpAndSignIn/components/SocialConnectorEditBox/index.tsx
index b1ae37174..ee8c41821 100644
--- a/packages/console/src/pages/SignInExperience/tabs/SignUpAndSignIn/components/SocialConnectorEditBox/index.tsx
+++ b/packages/console/src/pages/SignInExperience/tabs/SignUpAndSignIn/components/SocialConnectorEditBox/index.tsx
@@ -48,14 +48,14 @@ function SocialConnectorEditBox({ value, onChange }: Props) {
     );
   };
 
+  const socialConnectors = connectorData.filter(({ type }) => type === ConnectorType.Social);
+
   const selectedConnectorItems = value
-    .map((connectorTarget) => connectorData.find(({ target }) => target === connectorTarget))
+    .map((connectorTarget) => socialConnectors.find(({ target }) => target === connectorTarget))
     // eslint-disable-next-line unicorn/prefer-native-coercion-functions
     .filter((item): item is ConnectorGroup => Boolean(item));
 
-  const connectorOptions = connectorData.filter(
-    ({ target, type }) => !value.includes(target) && type === ConnectorType.Social
-  );
+  const connectorOptions = socialConnectors.filter(({ target }) => !value.includes(target));
 
   return (
     <div>
@@ -85,13 +85,15 @@ function SocialConnectorEditBox({ value, onChange }: Props) {
         }}
       />
       <ConnectorSetupWarning requiredConnectors={[ConnectorType.Social]} />
-      <div className={styles.setUpHint}>
-        {t('sign_in_exp.sign_up_and_sign_in.social_sign_in.set_up_hint.not_in_list')}
-        <TextLink to="/connectors/social" className={styles.setup}>
-          {t('sign_in_exp.sign_up_and_sign_in.social_sign_in.set_up_hint.set_up_more')}
-        </TextLink>
-        {t('sign_in_exp.sign_up_and_sign_in.social_sign_in.set_up_hint.go_to')}
-      </div>
+      {socialConnectors.length > 0 && (
+        <div className={styles.setUpHint}>
+          {t('sign_in_exp.sign_up_and_sign_in.social_sign_in.set_up_hint.not_in_list')}
+          <TextLink to="/connectors/social" className={styles.setup}>
+            {t('sign_in_exp.sign_up_and_sign_in.social_sign_in.set_up_hint.set_up_more')}
+          </TextLink>
+          {t('sign_in_exp.sign_up_and_sign_in.social_sign_in.set_up_hint.go_to')}
+        </div>
+      )}
     </div>
   );
 }