Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2025-01-20 21:32:31 -05:00
Code Issues Activity

refactor(test): remove unnecessary expect.objectContaining (#1659)

Browse source
This commit is contained in:
IceHe.life 2022-07-22 18:10:30 +08:00 • committed by GitHub
parent 7dfbc300b0
commit 379410e090
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 109 additions and 137 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

182
packages/core/src/routes/swagger.test.ts
View file

@ -44,10 +44,10 @@ describe('GET /swagger.json', () => {
expect(response.body).toMatchObject({
/* eslint-disable @typescript-eslint/no-unsafe-assignment */
openapi: expect.any(String),
info: expect.objectContaining({
info: {
title: expect.any(String),
version: expect.any(String),
}),
},
paths: expect.any(Object),
/* eslint-enable @typescript-eslint/no-unsafe-assignment */
});
@ -79,18 +79,14 @@ describe('GET /swagger.json', () => {
const swaggerRequest = createSwaggerRequest([testTagRouter]);
const response = await swaggerRequest.get('/swagger.json');
expect(response.body.paths).toMatchObject(
expect.objectContaining({
/* eslint-disable @typescript-eslint/no-unsafe-assignment */
'/api/mock': expect.objectContaining({
get: expect.objectContaining({ tags: ['Mock'] }),
}),
'/api/.well-known': expect.objectContaining({
put: expect.objectContaining({ tags: ['.well-known'] }),
}),
/* eslint-enable @typescript-eslint/no-unsafe-assignment */
})
);
expect(response.body.paths).toMatchObject({
'/api/mock': {
get: { tags: ['Mock'] },
},
'/api/.well-known': {
put: { tags: ['.well-known'] },
},
});
});
it('should parse the path parameters', async () => {
@ -108,30 +104,26 @@ describe('GET /swagger.json', () => {
const swaggerRequest = createSwaggerRequest([queryParametersRouter]);
const response = await swaggerRequest.get('/swagger.json');
expect(response.body.paths).toMatchObject(
expect.objectContaining({
/* eslint-disable @typescript-eslint/no-unsafe-assignment */
'/api/mock/:id/:field': {
get: expect.objectContaining({
parameters: [
{
name: 'id',
in: 'path',
required: true,
schema: { type: 'number' },
},
{
name: 'field',
in: 'path',
required: true,
schema: { type: 'string' },
},
],
}),
expect(response.body.paths).toMatchObject({
'/api/mock/:id/:field': {
get: {
parameters: [
{
name: 'id',
in: 'path',
required: true,
schema: { type: 'number' },
},
{
name: 'field',
in: 'path',
required: true,
schema: { type: 'string' },
},
],
},
/* eslint-enable @typescript-eslint/no-unsafe-assignment */
})
);
},
});
});
describe('parse query parameters', () => {
@ -149,34 +141,30 @@ describe('GET /swagger.json', () => {
);
const swaggerRequest = createSwaggerRequest([queryParametersRouter]);
const response = await swaggerRequest.get('/swagger.json');
expect(response.body.paths).toMatchObject(
expect.objectContaining({
/* eslint-disable @typescript-eslint/no-unsafe-assignment */
'/api/mock': {
get: expect.objectContaining({
parameters: [
{
name: 'id',
in: 'query',
required: true,
schema: {
type: 'number',
},
expect(response.body.paths).toMatchObject({
'/api/mock': {
get: {
parameters: [
{
name: 'id',
in: 'query',
required: true,
schema: {
type: 'number',
},
{
name: 'name',
in: 'query',
required: false,
schema: {
type: 'string',
},
},
{
name: 'name',
in: 'query',
required: false,
schema: {
type: 'string',
},
],
}),
},
],
},
/* eslint-enable @typescript-eslint/no-unsafe-assignment */
})
);
},
});
});
it('should append page and page_size to the query parameters when the route uses pagination', async () => {
@ -184,17 +172,13 @@ describe('GET /swagger.json', () => {
queryParametersRouter.get('/mock', koaPagination(), () => ({}));
const swaggerRequest = createSwaggerRequest([queryParametersRouter]);
const response = await swaggerRequest.get('/swagger.json');
expect(response.body.paths).toMatchObject(
expect.objectContaining({
/* eslint-disable @typescript-eslint/no-unsafe-assignment */
'/api/mock': {
get: expect.objectContaining({
parameters: paginationParameters,
}),
expect(response.body.paths).toMatchObject({
'/api/mock': {
get: {
parameters: paginationParameters,
},
/* eslint-enable @typescript-eslint/no-unsafe-assignment */
})
);
},
});
});
});
@ -211,32 +195,28 @@ describe('GET /swagger.json', () => {
);
const swaggerRequest = createSwaggerRequest([queryParametersRouter]);
const response = await swaggerRequest.get('/swagger.json');
expect(response.body.paths).toMatchObject(
expect.objectContaining({
/* eslint-disable @typescript-eslint/no-unsafe-assignment */
'/api/mock': {
post: expect.objectContaining({
requestBody: {
required: true,
content: {
'application/json': {
schema: {
type: 'object',
required: ['name'],
properties: {
name: {
type: 'string',
},
expect(response.body.paths).toMatchObject({
'/api/mock': {
post: {
requestBody: {
required: true,
content: {
'application/json': {
schema: {
type: 'object',
required: ['name'],
properties: {
name: {
type: 'string',
},
},
},
},
},
}),
},
},
/* eslint-enable @typescript-eslint/no-unsafe-assignment */
})
);
},
});
});
describe('should use correct responses', () => {
@ -248,11 +228,9 @@ describe('GET /swagger.json', () => {
const swaggerRequest = createSwaggerRequest([mockRouter]);
const response = await swaggerRequest.get('/swagger.json');
expect(response.body.paths).toMatchObject({
/* eslint-disable @typescript-eslint/no-unsafe-assignment */
'/api/mock': expect.objectContaining({
delete: expect.objectContaining({ responses: defaultResponses }),
}),
/* eslint-enable @typescript-eslint/no-unsafe-assignment */
'/api/mock': {
delete: { responses: defaultResponses },
},
});
});
@ -277,20 +255,18 @@ describe('GET /swagger.json', () => {
const swaggerRequest = createSwaggerRequest([mockRouter]);
const response = await swaggerRequest.get('/swagger.json');
expect(response.body.paths).toMatchObject({
/* eslint-disable @typescript-eslint/no-unsafe-assignment */
'/api/mock': {
get: expect.objectContaining({
get: {
responses: {
'204': { description: 'No Content' },
},
}),
patch: expect.objectContaining({
},
patch: {
responses: {
'202': { description: 'Accepted' },
},
}),
},
},
/* eslint-enable @typescript-eslint/no-unsafe-assignment */
});
});
});

64
packages/core/src/routes/well-known.test.ts
View file

@ -88,29 +88,27 @@ describe('GET /.well-known/sign-in-exp', () => {
const response = await sessionRequest.get('/.well-known/sign-in-exp');
expect(signInExperienceQuerySpyOn).toHaveBeenCalledTimes(1);
expect(response.status).toEqual(200);
expect(response.body).toMatchObject(
expect.objectContaining({
...mockSignInExperience,
socialConnectors: [
{
...mockGithubConnectorInstance.metadata,
id: mockGithubConnectorInstance.connector.id,
},
{
...mockFacebookConnectorInstance.metadata,
id: mockFacebookConnectorInstance.connector.id,
},
{
...mockWechatConnectorInstance.metadata,
id: mockWechatConnectorInstance.connector.id,
},
{
...mockWechatNativeConnectorInstance.metadata,
id: mockWechatNativeConnectorInstance.connector.id,
},
],
})
);
expect(response.body).toMatchObject({
...mockSignInExperience,
socialConnectors: [
{
...mockGithubConnectorInstance.metadata,
id: mockGithubConnectorInstance.connector.id,
},
{
...mockFacebookConnectorInstance.metadata,
id: mockFacebookConnectorInstance.connector.id,
},
{
...mockWechatConnectorInstance.metadata,
id: mockWechatConnectorInstance.connector.id,
},
{
...mockWechatNativeConnectorInstance.metadata,
id: mockWechatNativeConnectorInstance.connector.id,
},
],
});
});
it('should return admin console settings', async () => {
@ -119,16 +117,14 @@ describe('GET /.well-known/sign-in-exp', () => {
expect(signInExperienceQuerySpyOn).not.toBeCalled();
expect(response.status).toEqual(200);
expect(response.body).toMatchObject(
expect.objectContaining({
...adminConsoleSignInExperience,
branding: {
...adminConsoleSignInExperience.branding,
slogan: 'admin_console.welcome.title',
},
socialConnectors: [],
signInMode: SignInMode.SignIn,
})
);
expect(response.body).toMatchObject({
...adminConsoleSignInExperience,
branding: {
...adminConsoleSignInExperience.branding,
slogan: 'admin_console.welcome.title',
},
socialConnectors: [],
signInMode: SignInMode.SignIn,
});
});
});