Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2025-01-27 21:39:16 -05:00
Code Issues Activity

refactor(console): make the inline connector setup warning display only once (#2380)

Browse source
This commit is contained in:
Xiao Yijun 2022-11-10 16:24:02 +08:00 • committed by GitHub
parent 55ca9e5a92
commit 3137450ccf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/console/src/pages/SignInExperience/tabs/SignUpAndSignInTab/SignInForm.tsx
View file

@ -5,7 +5,10 @@ import FormField from '@/components/FormField';
import type { SignInExperienceForm } from '../../types'; import type { SignInExperienceForm } from '../../types';
import SignInMethodEditBox from './components/SignInMethodEditBox'; import SignInMethodEditBox from './components/SignInMethodEditBox';
import { signUpToSignInIdentifierMapping } from './constants'; import {
signUpIdentifierToRequiredConnectorMapping,
signUpToSignInIdentifierMapping,
} from './constants';
import * as styles from './index.module.scss'; import * as styles from './index.module.scss';
const SignInForm = () => { const SignInForm = () => {
@ -41,6 +44,9 @@ const SignInForm = () => {
<SignInMethodEditBox <SignInMethodEditBox
value={value} value={value}
requiredSignInIdentifiers={signUpToSignInIdentifierMapping[signUpIdentifier]} requiredSignInIdentifiers={signUpToSignInIdentifierMapping[signUpIdentifier]}
ignoredWarningConnectors={
signUpIdentifierToRequiredConnectorMapping[signUpIdentifier]
}
isSignUpPasswordRequired={setupPasswordAtSignUp} isSignUpPasswordRequired={setupPasswordAtSignUp}
isSignUpVerificationRequired={setupVerificationAtSignUp} isSignUpVerificationRequired={setupVerificationAtSignUp}
onChange={onChange} onChange={onChange}

11
packages/console/src/pages/SignInExperience/tabs/SignUpAndSignInTab/components/SignInMethodEditBox/index.tsx
View file

@ -23,6 +23,7 @@ type Props = {
value: SignInMethod[]; value: SignInMethod[];
onChange: (value: SignInMethod[]) => void; onChange: (value: SignInMethod[]) => void;
requiredSignInIdentifiers: SignInIdentifier[]; requiredSignInIdentifiers: SignInIdentifier[];
ignoredWarningConnectors: ConnectorType[];
isSignUpPasswordRequired: boolean; isSignUpPasswordRequired: boolean;
isSignUpVerificationRequired: boolean; isSignUpVerificationRequired: boolean;
}; };
@ -31,6 +32,7 @@ const SignInMethodEditBox = ({
value, value,
onChange, onChange,
requiredSignInIdentifiers, requiredSignInIdentifiers,
ignoredWarningConnectors,
isSignUpPasswordRequired, isSignUpPasswordRequired,
isSignUpVerificationRequired, isSignUpVerificationRequired,
}: Props) => { }: Props) => {
@ -153,12 +155,11 @@ const SignInMethodEditBox = ({
))} ))}
</DragDropProvider> </DragDropProvider>
<ConnectorSetupWarning <ConnectorSetupWarning
requiredConnectors={value.reduce<ConnectorType[]>( requiredConnectors={value
(connectors, { identifier: signInIdentifier }) => { .reduce<ConnectorType[]>((connectors, { identifier: signInIdentifier }) => {
return [...connectors, ...signInIdentifierToRequiredConnectorMapping[signInIdentifier]]; return [...connectors, ...signInIdentifierToRequiredConnectorMapping[signInIdentifier]];
}, }, [])
[] .filter((connector) => !ignoredWarningConnectors.includes(connector))}
)}
/> />
<AddButton <AddButton
options={signInIdentifierOptions} options={signInIdentifierOptions}