Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2025-03-24 22:41:28 -05:00
Code Issues Activity

fix: clone error for AppInsights (#3985)

Browse source
This commit is contained in:
Gao Sun 2023-06-06 22:56:57 +08:00 • committed by GitHub
parent be43ecd49b
commit 2e2ba5daf3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
packages/app-insights/src/node.ts
View file

@ -2,7 +2,7 @@ import { trySafe } from '@silverhand/essentials';
import type { TelemetryClient } from 'applicationinsights';
export const normalizeError = (error: unknown) => {
const normalized = error instanceof Error ? error : new Error(String(error));
const errorObject = error instanceof Error ? error : new Error(String(error));
/**
* - Ensure the message if not empty otherwise Application Insights will respond 400
@ -10,13 +10,22 @@ export const normalizeError = (error: unknown) => {
* - We stringify error object here since other error properties won't show on the
* ApplicationInsights details page.
*/
// eslint-disable-next-line @silverhand/fp/no-mutation
normalized.message = JSON.stringify(
error,
const message = JSON.stringify(
errorObject,
// ApplicationInsights shows call stack, no need to stringify
Object.getOwnPropertyNames(error).filter((value) => value !== 'stack')
Object.getOwnPropertyNames(errorObject).filter((value) => value !== 'stack')
);
// Ensure we don't mutate the original error
const normalized = new Error(message);
// Manually clone key fields of the error for AppInsights display
/* eslint-disable @silverhand/fp/no-mutation */
normalized.name = errorObject.name;
normalized.stack = errorObject.stack;
normalized.cause = errorObject.cause;
/* eslint-enable @silverhand/fp/no-mutation */
return normalized;
};