From 1ef04bd45d4eab70f571b7bc68d94ce78b80022e Mon Sep 17 00:00:00 2001 From: "IceHe.xyz" Date: Mon, 18 Apr 2022 12:50:49 +0800 Subject: [PATCH] refactor(core): clear mocks after each test (#559) --- packages/core/src/middleware/koa-error-handler.test.ts | 5 ++++- packages/core/src/middleware/koa-spa-proxy.test.ts | 3 +++ packages/core/src/middleware/koa-user-log.test.ts | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/core/src/middleware/koa-error-handler.test.ts b/packages/core/src/middleware/koa-error-handler.test.ts index 80b540f1a..90bf725e2 100644 --- a/packages/core/src/middleware/koa-error-handler.test.ts +++ b/packages/core/src/middleware/koa-error-handler.test.ts @@ -16,11 +16,14 @@ describe('koaErrorHandler middleware', () => { const next = jest.fn().mockReturnValue(Promise.resolve()); beforeEach(() => { - jest.clearAllMocks(); ctx.body = mockBody; ctx.status = 200; }); + afterEach(() => { + jest.clearAllMocks(); + }); + it('expect to return error response if error type is RequestError', async () => { const error = new RequestError('auth.unauthorized'); next.mockRejectedValueOnce(error); diff --git a/packages/core/src/middleware/koa-spa-proxy.test.ts b/packages/core/src/middleware/koa-spa-proxy.test.ts index 596f210f2..6ad359d52 100644 --- a/packages/core/src/middleware/koa-spa-proxy.test.ts +++ b/packages/core/src/middleware/koa-spa-proxy.test.ts @@ -19,6 +19,9 @@ describe('koaSpaProxy middleware', () => { beforeEach(() => { process.env = { ...envBackup }; + }); + + afterEach(() => { jest.clearAllMocks(); jest.resetModules(); }); diff --git a/packages/core/src/middleware/koa-user-log.test.ts b/packages/core/src/middleware/koa-user-log.test.ts index 9b18307dd..ab742110c 100644 --- a/packages/core/src/middleware/koa-user-log.test.ts +++ b/packages/core/src/middleware/koa-user-log.test.ts @@ -26,7 +26,7 @@ describe('koaUserLog middleware', () => { payload: { applicationId: 'foo' }, }; - beforeEach(() => { + afterEach(() => { jest.clearAllMocks(); });