Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2024-12-16 20:26:19 -05:00
Code Issues Activity

chore(core): add response guard for user roles APIs (#3773)

Browse source 
refactor(core): add response and status guards to admin user role APIs
This commit is contained in:
Charles Zhao 2023-05-17 11:50:53 +08:00 committed by GitHub
parent 05b3729260
commit 1cd854a63c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
packages/core/src/routes/admin-user-role.ts
View file

@ -1,6 +1,7 @@
import { Roles } from '@logto/schemas';
import { generateStandardId } from '@logto/shared';
import { tryThat } from '@silverhand/essentials';
import { object, string } from 'zod';
import { array, object, string } from 'zod';
import RequestError from '#src/errors/RequestError/index.js';
import koaGuard from '#src/middleware/koa-guard.js';
@ -27,19 +28,19 @@ export default function adminUserRoleRoutes<T extends AuthedRouter>(
koaPagination(),
koaGuard({
params: object({ userId: string() }),
response: array(Roles.guard),
status: [200, 400, 404],
}),
async (ctx, next) => {
const {
params: { userId },
} = ctx.guard;
const { userId } = ctx.guard.params;
const { limit, offset } = ctx.pagination;
const { searchParams } = ctx.request.URL;
await findUserById(userId);
return tryThat(
async () => {
const search = parseSearchParamsForSearch(searchParams);
const usersRoles = await findUsersRolesByUserId(userId);
const roleIds = usersRoles.map(({ roleId }) => roleId);
const [{ count }, roles] = await Promise.all([
@ -71,6 +72,7 @@ export default function adminUserRoleRoutes<T extends AuthedRouter>(
koaGuard({
params: object({ userId: string() }),
body: object({ roleIds: string().min(1).array() }),
status: [201, 404, 422],
}),
async (ctx, next) => {
const {
@ -107,6 +109,7 @@ export default function adminUserRoleRoutes<T extends AuthedRouter>(
koaGuard({
params: object({ userId: string() }),
body: object({ roleIds: string().min(1).array() }),
status: [200, 404],
}),
async (ctx, next) => {
const {
@ -144,6 +147,7 @@ export default function adminUserRoleRoutes<T extends AuthedRouter>(
'/users/:userId/roles/:roleId',
koaGuard({
params: object({ userId: string(), roleId: string() }),
status: [204, 404],
}),
async (ctx, next) => {
const {