Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2024-12-16 20:26:19 -05:00
Code Issues Activity

fix(console): react-markdown rendering error in parcel dev mode (#4319)

Browse source
This commit is contained in:
Charles Zhao 2023-08-14 11:09:06 +08:00 committed by GitHub
parent 7bb60eeff8
commit 1b983c8c89
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 30 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/console/package.json
View file

@ -93,6 +93,7 @@
"prettier": "^3.0.0", "prettier": "^3.0.0",
"process": "^0.11.10", "process": "^0.11.10",
"prop-types": "^15.8.1", "prop-types": "^15.8.1",
"property-information": "^6.2.0",
"react": "^18.0.0", "react": "^18.0.0",
"react-animate-height": "^3.0.4", "react-animate-height": "^3.0.4",
"react-color": "^2.19.3", "react-color": "^2.19.3",
@ -104,7 +105,7 @@
"react-hook-form": "^7.43.9", "react-hook-form": "^7.43.9",
"react-hot-toast": "^2.2.0", "react-hot-toast": "^2.2.0",
"react-i18next": "^12.3.1", "react-i18next": "^12.3.1",
"react-markdown": "^8.0.0", "react-markdown": "^8.0.7",
"react-modal": "^3.15.1", "react-modal": "^3.15.1",
"react-paginate": "^8.1.3", "react-paginate": "^8.1.3",
"react-router-dom": "^6.10.0", "react-router-dom": "^6.10.0",

9
packages/console/src/components/Markdown/index.tsx
View file

@ -4,6 +4,15 @@ import classNames from 'classnames';
import { memo, useRef } from 'react'; import { memo, useRef } from 'react';
import ReactMarkdown from 'react-markdown'; import ReactMarkdown from 'react-markdown';
import remarkGfm from 'remark-gfm'; import remarkGfm from 'remark-gfm';
/**
* Workaround for the markdown crash issue in the parcel dev build. It seems parcel does
* something clever in dev mode and messing up the `hastToReact` module. Manually adding
* the `property-information` import somehow keeps the reference and makes dev build work.
* @see https://github.com/remarkjs/react-markdown/issues/747
* @see https://github.com/parcel-bundler/parcel/discussions/9113
*/
// eslint-disable-next-line import/no-unassigned-import
import 'property-information';
import CodeEditor from '@/ds-components/CodeEditor'; import CodeEditor from '@/ds-components/CodeEditor';

28
pnpm-lock.yaml
View file

@ -3034,6 +3034,9 @@ importers:
prop-types: prop-types:
specifier: ^15.8.1 specifier: ^15.8.1
version: 15.8.1 version: 15.8.1
property-information:
specifier: ^6.2.0
version: 6.2.0
react: react:
specifier: ^18.0.0 specifier: ^18.0.0
version: 18.2.0 version: 18.2.0
@ -3068,8 +3071,8 @@ importers:
specifier: ^12.3.1 specifier: ^12.3.1
version: 12.3.1(i18next@22.4.15)(react-dom@18.2.0)(react@18.2.0) version: 12.3.1(i18next@22.4.15)(react-dom@18.2.0)(react@18.2.0)
react-markdown: react-markdown:
specifier: ^8.0.0 specifier: ^8.0.7
version: 8.0.0(@types/react@18.0.31)(react@18.2.0) version: 8.0.7(@types/react@18.0.31)(react@18.2.0)
react-modal: react-modal:
specifier: ^3.15.1 specifier: ^3.15.1
version: 3.15.1(react-dom@18.2.0)(react@18.2.0) version: 3.15.1(react-dom@18.2.0)(react@18.2.0)
@ -17500,8 +17503,8 @@ packages:
xtend: 4.0.2 xtend: 4.0.2
dev: true dev: true
/property-information@6.1.1: /property-information@6.2.0:
resolution: {integrity: sha512-hrzC564QIl0r0vy4l6MvRLhafmUowhO/O3KgVSoXIbbA2Sz4j8HGpJc6T2cubRVwMwpdiG/vKGfhT4IixmKN9w==} resolution: {integrity: sha512-kma4U7AFCTwpqq5twzC1YVIDXSqg6qQK6JN0smOw8fgRy1OkMi0CYSzFmsy6dnqSenamAtj0CyXMUJ1Mf6oROg==}
dev: true dev: true
/proto-props@2.0.0: /proto-props@2.0.0:
@ -17835,25 +17838,26 @@ packages:
resolution: {integrity: sha512-fBASbA6LnOU9dOU2eW7aQ8xmYBSXUIWr+UmF9b1efZBazGNO+rcXT/icdKnYm2pTwcRylVUYwW7H1PHfLekVzA==} resolution: {integrity: sha512-fBASbA6LnOU9dOU2eW7aQ8xmYBSXUIWr+UmF9b1efZBazGNO+rcXT/icdKnYm2pTwcRylVUYwW7H1PHfLekVzA==}
dev: true dev: true
/react-markdown@8.0.0(@types/react@18.0.31)(react@18.2.0): /react-markdown@8.0.7(@types/react@18.0.31)(react@18.2.0):
resolution: {integrity: sha512-qbrWpLny6Ef2xHqnYqtot948LXP+4FtC+MWIuaN1kvSnowM+r1qEeEHpSaU0TDBOisQuj+Qe6eFY15cNL3gLAw==} resolution: {integrity: sha512-bvWbzG4MtOU62XqBx3Xx+zB2raaFFsq4mYiAzfjXJMEz2sixgeAfraA3tvzULF02ZdOMUOKTBFFaZJDDrq+BJQ==}
peerDependencies: peerDependencies:
'@types/react': '>=16' '@types/react': '>=16'
react: '>=16 || ^18.0.0' react: '>=16 || ^18.0.0'
dependencies: dependencies:
'@types/hast': 2.3.4 '@types/hast': 2.3.4
'@types/prop-types': 15.7.4
'@types/react': 18.0.31 '@types/react': 18.0.31
'@types/unist': 2.0.6 '@types/unist': 2.0.6
comma-separated-tokens: 2.0.2 comma-separated-tokens: 2.0.2
hast-util-whitespace: 2.0.0 hast-util-whitespace: 2.0.0
prop-types: 15.8.1 prop-types: 15.8.1
property-information: 6.1.1 property-information: 6.2.0
react: 18.2.0 react: 18.2.0
react-is: 17.0.2 react-is: 18.2.0
remark-parse: 10.0.1 remark-parse: 10.0.1
remark-rehype: 10.1.0 remark-rehype: 10.1.0
space-separated-tokens: 2.0.1 space-separated-tokens: 2.0.1
style-to-object: 0.3.0 style-to-object: 0.4.2
unified: 10.1.2 unified: 10.1.2
unist-util-visit: 4.1.0 unist-util-visit: 4.1.0
vfile: 5.3.2 vfile: 5.3.2
@ -19213,6 +19217,12 @@ packages:
inline-style-parser: 0.1.1 inline-style-parser: 0.1.1
dev: true dev: true
/style-to-object@0.4.2:
resolution: {integrity: sha512-1JGpfPB3lo42ZX8cuPrheZbfQ6kqPPnPHlKMyeRYtfKD+0jG+QsXgXN57O/dvJlzlB2elI6dGmrPnl5VPQFPaA==}
dependencies:
inline-style-parser: 0.1.1
dev: true
/stylelint-config-xo-scss@0.15.0(postcss@8.4.14)(stylelint@15.0.0): /stylelint-config-xo-scss@0.15.0(postcss@8.4.14)(stylelint@15.0.0):
resolution: {integrity: sha512-X9WD8cDofWFWy3uaKdwwm+DjEvgI/+h7AtlaPagkhNAeOWH/GFQoeciBvNvyJ8tB1p00SoIzCn2IIOIKXCbxYA==} resolution: {integrity: sha512-X9WD8cDofWFWy3uaKdwwm+DjEvgI/+h7AtlaPagkhNAeOWH/GFQoeciBvNvyJ8tB1p00SoIzCn2IIOIKXCbxYA==}
engines: {node: '>=12'} engines: {node: '>=12'}