Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2025-01-06 20:40:08 -05:00
Code Issues Activity

fix(console): add page level loading for SSO details page (#4981)

Browse source
This commit is contained in:
Darcy Ye 2023-11-28 12:14:27 +08:00 committed by GitHub
parent bd2e5bf4b8
commit 0aa70cd5a7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
packages/console/src/pages/EnterpriseSsoDetails/index.tsx
View file

@ -11,6 +11,7 @@ import Delete from '@/assets/icons/delete.svg';
import File from '@/assets/icons/file.svg';
import DetailsPage from '@/components/DetailsPage';
import DetailsPageHeader from '@/components/DetailsPage/DetailsPageHeader';
import Skeleton from '@/components/DetailsPage/Skeleton';
import Drawer from '@/components/Drawer';
import Markdown from '@/components/Markdown';
import PageMeta from '@/components/PageMeta';
@ -21,6 +22,7 @@ import TabNav, { TabNavItem } from '@/ds-components/TabNav';
import type { RequestError } from '@/hooks/use-api';
import useApi from '@/hooks/use-api';
import useTenantPathname from '@/hooks/use-tenant-pathname';
import useUserAssetsService from '@/hooks/use-user-assets-service';
import SsoConnectorLogo from '../EnterpriseSso/SsoConnectorLogo';
import {
@ -44,11 +46,14 @@ function EnterpriseSsoConnectorDetails<T extends SsoProviderName>() {
const [isDeleted, setIsDeleted] = useState(false);
const [isReadmeOpen, setIsReadmeOpen] = useState(false);
const { isLoading: isUserAssetServiceLoading } = useUserAssetsService();
const { t } = useTranslation(undefined, { keyPrefix: 'admin_console' });
const {
data: ssoConnector,
error: requestError,
mutate,
isLoading: isSsoConnectorLoading,
} = useSWR<SsoConnectorWithProviderConfigWithGeneric<T>, RequestError>(
ssoConnectorId && `api/sso-connectors/${ssoConnectorId}`,
{ keepPreviousData: true }
@ -67,7 +72,7 @@ function EnterpriseSsoConnectorDetails<T extends SsoProviderName>() {
.identityProvider
));
const isLoading = !ssoConnector && !requestError;
const isLoading = isSsoConnectorLoading || isUserAssetServiceLoading;
const api = useApi();
const { navigate } = useTenantPathname();
@ -108,14 +113,14 @@ function EnterpriseSsoConnectorDetails<T extends SsoProviderName>() {
<DetailsPage
backLink={enterpriseSsoPathname}
backLinkTitle="enterprise_sso_details.back_to_sso_connectors"
isLoading={isLoading}
error={requestError}
onRetry={() => {
void mutate();
}}
>
<PageMeta titleKey="enterprise_sso_details.page_title" />
{ssoConnector && (
{isLoading && <Skeleton />}
{!isLoading && ssoConnector && (
<>
<DetailsPageHeader
icon={