From 5a59cd38e50f1524529a0a4db1707fd498c50237 Mon Sep 17 00:00:00 2001 From: wangsijie Date: Thu, 18 May 2023 11:28:10 +0800 Subject: [PATCH 1/2] feat: disable pkce requirement for traditional app --- .changeset/purple-birds-retire.md | 5 +++++ packages/core/src/oidc/init.ts | 6 ++++++ 2 files changed, 11 insertions(+) create mode 100644 .changeset/purple-birds-retire.md diff --git a/.changeset/purple-birds-retire.md b/.changeset/purple-birds-retire.md new file mode 100644 index 000000000..e8608d0ca --- /dev/null +++ b/.changeset/purple-birds-retire.md @@ -0,0 +1,5 @@ +--- +"@logto/core": patch +--- + +Disable pkce requirement for traditional web app diff --git a/packages/core/src/oidc/init.ts b/packages/core/src/oidc/init.ts index 8ef6ea3d5..18042abbd 100644 --- a/packages/core/src/oidc/init.ts +++ b/packages/core/src/oidc/init.ts @@ -254,6 +254,12 @@ export default function initOidc( Session: 1_209_600 /* 14 days in seconds */, Grant: 1_209_600 /* 14 days in seconds */, }, + pkce: { + required: (ctx, client) => { + return client.tokenEndpointAuthMethod !== 'client_secret_basic'; + }, + methods: ['S256'], + }, }); addOidcEventListeners(oidc); From dc41d5d3dc1dc935d69efe75b6f24c565327e9f9 Mon Sep 17 00:00:00 2001 From: Gao Sun Date: Thu, 18 May 2023 22:26:11 +0800 Subject: [PATCH 2/2] release: version packages --- .changeset/purple-birds-retire.md | 5 ----- packages/cli/CHANGELOG.md | 6 ++++++ packages/cli/package.json | 4 ++-- packages/core/CHANGELOG.md | 8 ++++++++ packages/core/package.json | 6 +++--- packages/create/CHANGELOG.md | 6 ++++++ packages/create/package.json | 4 ++-- packages/schemas/CHANGELOG.md | 2 ++ packages/schemas/package.json | 2 +- pnpm-lock.yaml | 8 ++++---- 10 files changed, 34 insertions(+), 17 deletions(-) delete mode 100644 .changeset/purple-birds-retire.md diff --git a/.changeset/purple-birds-retire.md b/.changeset/purple-birds-retire.md deleted file mode 100644 index e8608d0ca..000000000 --- a/.changeset/purple-birds-retire.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -"@logto/core": patch ---- - -Disable pkce requirement for traditional web app diff --git a/packages/cli/CHANGELOG.md b/packages/cli/CHANGELOG.md index 1348dfdb1..461652ea2 100644 --- a/packages/cli/CHANGELOG.md +++ b/packages/cli/CHANGELOG.md @@ -1,5 +1,11 @@ # Change Log +## 1.3.1 + +### Patch Changes + +- @logto/schemas@1.3.1 + ## 1.3.0 ### Patch Changes diff --git a/packages/cli/package.json b/packages/cli/package.json index ef0c3d798..256ea1d0f 100644 --- a/packages/cli/package.json +++ b/packages/cli/package.json @@ -1,6 +1,6 @@ { "name": "@logto/cli", - "version": "1.3.0", + "version": "1.3.1", "description": "Logto CLI.", "author": "Silverhand Inc. ", "homepage": "https://github.com/logto-io/logto#readme", @@ -48,7 +48,7 @@ "@logto/language-kit": "workspace:^1.0.0", "@logto/phrases": "workspace:^1.2.0", "@logto/phrases-ui": "workspace:^1.2.0", - "@logto/schemas": "workspace:1.3.0", + "@logto/schemas": "workspace:1.3.1", "@logto/shared": "workspace:^2.0.0", "@silverhand/essentials": "^2.5.0", "chalk": "^5.0.0", diff --git a/packages/core/CHANGELOG.md b/packages/core/CHANGELOG.md index 7b5751a2a..6edad8eb7 100644 --- a/packages/core/CHANGELOG.md +++ b/packages/core/CHANGELOG.md @@ -1,5 +1,13 @@ # Change Log +## 1.3.1 + +### Patch Changes + +- 5a59cd38e: Disable pkce requirement for traditional web app + - @logto/schemas@1.3.1 + - @logto/cli@1.3.1 + ## 1.3.0 ### Minor Changes diff --git a/packages/core/package.json b/packages/core/package.json index 02f0002f6..e27de20b6 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -1,6 +1,6 @@ { "name": "@logto/core", - "version": "1.3.0", + "version": "1.3.1", "description": "The open source identity solution.", "main": "build/index.js", "author": "Silverhand Inc. ", @@ -29,7 +29,7 @@ "@azure/storage-blob": "^12.13.0", "@koa/cors": "^4.0.0", "@logto/app-insights": "workspace:^1.2.0", - "@logto/cli": "workspace:^1.3.0", + "@logto/cli": "workspace:^1.3.1", "@logto/connector-kit": "workspace:^1.1.1", "@logto/console": "workspace:*", "@logto/core-kit": "workspace:^2.0.0", @@ -37,7 +37,7 @@ "@logto/language-kit": "workspace:^1.0.0", "@logto/phrases": "workspace:^1.2.0", "@logto/phrases-ui": "workspace:^1.2.0", - "@logto/schemas": "workspace:^1.3.0", + "@logto/schemas": "workspace:^1.3.1", "@logto/shared": "workspace:^2.0.0", "@logto/ui": "workspace:*", "@silverhand/essentials": "^2.5.0", diff --git a/packages/create/CHANGELOG.md b/packages/create/CHANGELOG.md index b70a35ff4..ff03c692e 100644 --- a/packages/create/CHANGELOG.md +++ b/packages/create/CHANGELOG.md @@ -1,5 +1,11 @@ # Change Log +## 1.3.1 + +### Patch Changes + +- @logto/cli@1.3.1 + ## 1.3.0 ### Minor Changes diff --git a/packages/create/package.json b/packages/create/package.json index a008032f2..ff1f13860 100644 --- a/packages/create/package.json +++ b/packages/create/package.json @@ -1,6 +1,6 @@ { "name": "@logto/create", - "version": "1.3.0", + "version": "1.3.1", "author": "Silverhand Inc. ", "license": "MPL-2.0", "type": "module", @@ -15,6 +15,6 @@ "node": "^18.12.0" }, "dependencies": { - "@logto/cli": "workspace:^1.3.0" + "@logto/cli": "workspace:^1.3.1" } } diff --git a/packages/schemas/CHANGELOG.md b/packages/schemas/CHANGELOG.md index e316ffa87..4d084225d 100644 --- a/packages/schemas/CHANGELOG.md +++ b/packages/schemas/CHANGELOG.md @@ -1,5 +1,7 @@ # Change Log +## 1.3.1 + ## 1.3.0 ### Patch Changes diff --git a/packages/schemas/package.json b/packages/schemas/package.json index 2ec5605c6..507fbd69e 100644 --- a/packages/schemas/package.json +++ b/packages/schemas/package.json @@ -1,6 +1,6 @@ { "name": "@logto/schemas", - "version": "1.3.0", + "version": "1.3.1", "author": "Silverhand Inc. ", "license": "MPL-2.0", "type": "module", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index cb3daec85..1d45412fc 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -109,7 +109,7 @@ importers: specifier: workspace:^1.2.0 version: link:../phrases-ui '@logto/schemas': - specifier: workspace:1.3.0 + specifier: workspace:1.3.1 version: link:../schemas '@logto/shared': specifier: workspace:^2.0.0 @@ -3054,7 +3054,7 @@ importers: specifier: workspace:^1.2.0 version: link:../app-insights '@logto/cli': - specifier: workspace:^1.3.0 + specifier: workspace:^1.3.1 version: link:../cli '@logto/connector-kit': specifier: workspace:^1.1.1 @@ -3078,7 +3078,7 @@ importers: specifier: workspace:^1.2.0 version: link:../phrases-ui '@logto/schemas': - specifier: workspace:^1.3.0 + specifier: workspace:^1.3.1 version: link:../schemas '@logto/shared': specifier: workspace:^2.0.0 @@ -3292,7 +3292,7 @@ importers: packages/create: dependencies: '@logto/cli': - specifier: workspace:^1.3.0 + specifier: workspace:^1.3.1 version: link:../cli packages/demo-app: