0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2025-03-25 02:41:37 -05:00
immich/mobile/lib
Tom Graham efbc0cb192
fix(mobile): 14983 Images upload to shared album with common name (#15127)
* Initial look at fixing issue where images are uploaded to the wrong album if a shared album conflicts with a local users album.

* Use owner instead of shared flag when fetching albums.

* Fix issue with refreshRemoteAlbums getting shared items twice and removed incorrect isShared comment.

Using `getAll(shared: true)` gets all shared albums the user can access (regardless of owner, despite the previous comment).

Using `getAll(shared: null)` gets all albums (incuding shared = true and shared = false). I presume the intent here was to get albums that were shared (and not mine), and not shared (ie: mine), but the logic is way off. It also just then combines them - so makes more sense to just get them in a single call.

* Fix formatting.

* Fixed tests.

* Revert "Fixed tests."

This reverts commit c38f5af5ac.

* Revert "Fix issue with refreshRemoteAlbums getting shared items twice and removed incorrect isShared comment."

This reverts commit 979ce90abf.

* Added comments to explain why filters behave the way they do for getAll() albums.

---------

Co-authored-by: Tom graham <tomg@questps.com.au>
Co-authored-by: Alex <alex.tran1502@gmail.com>
2025-01-16 21:24:09 -06:00
..
constants feat(mobile): share to mechanism (#15229) 2025-01-16 21:20:44 -06:00
entities feat(mobile): add ability to force view original videos (#15094) 2025-01-06 15:29:47 -05:00
extensions feat(mobile): Auto switching server URLs (#14437) 2024-12-05 09:11:48 -06:00
interfaces fix(mobile): 14983 Images upload to shared album with common name (#15127) 2025-01-16 21:24:09 -06:00
mixins refactor(mobile): move error details to separate DB column (#6898) 2024-02-23 21:38:57 -06:00
models feat(mobile): share to mechanism (#15229) 2025-01-16 21:20:44 -06:00
pages feat(mobile): share to mechanism (#15229) 2025-01-16 21:20:44 -06:00
providers fix(mobile): 14983 Images upload to shared album with common name (#15127) 2025-01-16 21:24:09 -06:00
repositories fix(mobile): 14983 Images upload to shared album with common name (#15127) 2025-01-16 21:24:09 -06:00
routing feat(mobile): share to mechanism (#15229) 2025-01-16 21:20:44 -06:00
services fix(mobile): 14983 Images upload to shared album with common name (#15127) 2025-01-16 21:24:09 -06:00
theme refactor(mobile): refactor theme management (#14415) 2024-12-11 16:30:56 +00:00
utils feat(mobile): share to mechanism (#15229) 2025-01-16 21:20:44 -06:00
widgets feat(mobile): share to mechanism (#15229) 2025-01-16 21:20:44 -06:00
main.dart feat(mobile): share to mechanism (#15229) 2025-01-16 21:20:44 -06:00