0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2025-02-04 01:09:14 -05:00
immich/mobile
Tom Graham efbc0cb192
fix(mobile): 14983 Images upload to shared album with common name (#15127)
* Initial look at fixing issue where images are uploaded to the wrong album if a shared album conflicts with a local users album.

* Use owner instead of shared flag when fetching albums.

* Fix issue with refreshRemoteAlbums getting shared items twice and removed incorrect isShared comment.

Using `getAll(shared: true)` gets all shared albums the user can access (regardless of owner, despite the previous comment).

Using `getAll(shared: null)` gets all albums (incuding shared = true and shared = false). I presume the intent here was to get albums that were shared (and not mine), and not shared (ie: mine), but the logic is way off. It also just then combines them - so makes more sense to just get them in a single call.

* Fix formatting.

* Fixed tests.

* Revert "Fixed tests."

This reverts commit c38f5af5ac.

* Revert "Fix issue with refreshRemoteAlbums getting shared items twice and removed incorrect isShared comment."

This reverts commit 979ce90abf.

* Added comments to explain why filters behave the way they do for getAll() albums.

---------

Co-authored-by: Tom graham <tomg@questps.com.au>
Co-authored-by: Alex <alex.tran1502@gmail.com>
2025-01-16 21:24:09 -06:00
..
.isar@6643d064ab
.vscode feat: serve map tile styles from tiles.immich.cloud (#12858) 2024-09-23 20:30:23 +00:00
android feat(mobile): share to mechanism (#15229) 2025-01-16 21:20:44 -06:00
assets feat(mobile): share to mechanism (#15229) 2025-01-16 21:20:44 -06:00
fonts
immich_lint fix(deps): update dependency analyzer to v7 (#14673) 2024-12-14 13:43:31 -06:00
integration_test
ios feat(mobile): share to mechanism (#15229) 2025-01-16 21:20:44 -06:00
lib fix(mobile): 14983 Images upload to shared album with common name (#15127) 2025-01-16 21:24:09 -06:00
openapi refactor(server): use kysely (#12857) 2025-01-09 11:15:41 -05:00
scripts chore(mobile): update isar build (#13987) 2024-11-07 09:54:19 -06:00
test fix(mobile): fix text search (#14873) 2025-01-07 16:26:14 +00:00
.fvmrc chore(deps): update dependency flutter to v3.24.5 (#14332) 2024-11-25 04:20:00 +00:00
.gitignore
.isar-cargo.lock chore(mobile): add isar lock file (#12705) 2024-09-15 19:20:09 +00:00
.metadata
analysis_options.yaml fix(mobile): fix text search (#14873) 2025-01-07 16:26:14 +00:00
dart_test.yaml
devtools_options.yaml chore(mobile): refactor detail panel (#11662) 2024-08-09 13:43:47 +00:00
flutter_native_splash.yaml
makefile
pubspec.lock feat(mobile): share to mechanism (#15229) 2025-01-16 21:20:44 -06:00
pubspec.yaml feat(mobile): share to mechanism (#15229) 2025-01-16 21:20:44 -06:00
README.md

Immich Mobile Application - Flutter

The Immich mobile app is a Flutter-based solution leveraging the Isar Database for local storage and Riverpod for state management. This structure optimizes functionality and maintainability, allowing for efficient development and robust performance.

Setup

You must set up Flutter toolchain in your machine before you can perform any of the development.

Immich-Flutter Directory Structure

Below are the directory inside the lib directory:

  • constants: Store essential constants utilized across the application, like colors and locale.

  • extensions: Extensions enhancing various existing functionalities within the app, such as asset_extensions.dart, string_extensions.dart, and more.

  • module_template: Provides a template structure for different modules within the app, including subdivisions like models, providers, services, UI, and views.

    • models: Placeholder for storing module-specific models.
    • providers: Section to define module-specific Riverpod providers.
    • services: Houses services tailored to the module's functionality.
    • ui: Contains UI components and widgets for the module.
    • views: Placeholder for module-specific views.
  • modules: Organizes different functional modules of the app, each containing subdivisions for models, providers, services, UI, and views. This structure promotes modular development and scalability.

  • routing: Includes guards like auth_guard.dart, backup_permission_guard.dart, and routers like router.dart and router.gr.dart for streamlined navigation and permission management.

  • shared: cache, models, providers, services, ui, views: Encapsulates shared functionalities, such as caching mechanisms, common models, providers, services, UI components, and views accessible across the application.

  • utils: A collection of utility classes and functions catering to different app functionalities, including async_mutex.dart, bytes_units.dart, debounce.dart, migration.dart, and more.

Immich Architectural Pattern

The Immich Flutter app embraces a well-defined architectural pattern inspired by the Model-View-ViewModel (MVVM) approach. This layout organizes modules for models, providers, services, UI, and views, creating a modular development approach that strongly emphasizes a clean separation of concerns.

Please use the module_template provided to create a new module.

Architecture Breakdown

Below is how your code needs to be structured:

  • Models: In Immich, Models are like the app's blueprint—they're essential for organizing and using information. Imagine them as containers that hold data the app needs to function. They also handle basic rules and logic for managing and interacting with this data across the app.

  • Providers (Riverpod): Providers in Immich are a bit like traffic managers. They help different parts of the app communicate and share information effectively. They ensure that the right data gets to the right places at the right time. These providers use Riverpod, a tool that helps with managing and organizing how the app's information flows. Everything related to the state goes here.

  • Services: Services are the helpful behind-the-scenes workers in Immich. They handle important tasks like handling network requests or managing other essential functions. These services work independently and focus on supporting the app's main functionalities.

  • UI: In Immich, the UI focuses solely on how things appear and feel without worrying about the app's complex inner workings. You can slot in your reusable widget here.

  • Views: Views use Providers to get the needed information and handle actions without dealing with the technical complexities behind the scenes. Normally Flutter's screen & pages goes here.

Contributing

Please refer to the architecture for contributing to the mobile app!