Infrastructure/immich
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2025-01-21 00:52:43 -05:00
Code Issues Activity

fix(web): update unauthorized share link handling (#7126)

Browse source
This commit is contained in:
Ben McCann 2024-02-14 20:01:01 -08:00 • committed by GitHub
parent 9b814354a4
commit dabbd63a02
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
web/src/lib/utils.ts
View file

@ -13,7 +13,6 @@ import {
unlinkOAuthAccount,
type UserResponseDto,
} from '@immich/sdk';
import { common } from '@immich/sdk/axios';
import { get } from 'svelte/store';
interface UpdateParamAction {
@ -91,7 +90,7 @@ const createUrl = (path: string, parameters?: Record<string, unknown>) => {
const url = new URL(path, 'https://example.com');
url.search = searchParameters.toString();
return defaults.baseUrl + common.toPathString(url);
return defaults.baseUrl + url.pathname + url.search + url.hash;
};
export const getAssetFileUrl = (...[assetId, isWeb, isThumb]: [string, boolean, boolean]) => {

5
web/src/routes/(user)/share/[key]/+page.ts
View file

@ -1,8 +1,7 @@
import { getAssetThumbnailUrl } from '$lib/utils';
import { authenticate } from '$lib/utils/auth';
import { ThumbnailFormat, getMySharedLink } from '@immich/sdk';
import { error as throwError } from '@sveltejs/kit';
import type { AxiosError } from 'axios';
import { error as throwError, type HttpError } from '@sveltejs/kit';
import type { PageLoad } from './$types';
export const load = (async ({ params }) => {
@ -25,7 +24,7 @@ export const load = (async ({ params }) => {
} catch (error) {
// handle unauthorized error
// TODO this doesn't allow for 404 shared links anymore
if ((error as AxiosError).response?.status === 401) {
if ((error as HttpError).status === 401) {
return {
passwordRequired: true,
sharedLinkKey: key,