From a97e0caeb9e60f075cca53f2c4d23cd9ed9cbcdd Mon Sep 17 00:00:00 2001
From: Nicholas Flamy <30300649+NicholasFlamy@users.noreply.github.com>
Date: Sun, 12 May 2024 14:08:17 -0400
Subject: [PATCH] cho(web): Icon consistency and improvements (#9403)

* Add change from outline to regular icon in sidebar when page selected to more icons. Also change Favorites to single heart consistent with mobile app.

* Forgot to remove a few unused lines. Fixed.
---
 .../side-bar/side-bar.svelte                  | 42 +++++++++++++++----
 1 file changed, 35 insertions(+), 7 deletions(-)

diff --git a/web/src/lib/components/shared-components/side-bar/side-bar.svelte b/web/src/lib/components/shared-components/side-bar/side-bar.svelte
index cfb0a6bde3..31943dd0f0 100644
--- a/web/src/lib/components/shared-components/side-bar/side-bar.svelte
+++ b/web/src/lib/components/shared-components/side-bar/side-bar.svelte
@@ -4,16 +4,20 @@
   import { getAlbumCount, getAssetStatistics } from '@immich/sdk';
   import {
     mdiAccount,
+    mdiAccountOutline,
     mdiAccountMultiple,
     mdiAccountMultipleOutline,
+    mdiArchiveArrowDown,
     mdiArchiveArrowDownOutline,
-    mdiHeartMultiple,
-    mdiHeartMultipleOutline,
+    mdiHeart,
+    mdiHeartOutline,
     mdiImageAlbum,
     mdiImageMultiple,
     mdiImageMultipleOutline,
     mdiMagnify,
     mdiMap,
+    mdiMapOutline,
+    mdiTrashCan,
     mdiTrashCanOutline,
   } from '@mdi/js';
   import LoadingSpinner from '../loading-spinner.svelte';
@@ -31,9 +35,13 @@
     }
   };
 
+  let isArchiveSelected: boolean;
   let isFavoritesSelected: boolean;
+  let isMapSelected: boolean;
+  let isPeopleSelected: boolean;
   let isPhotosSelected: boolean;
   let isSharingSelected: boolean;
+  let isTrashSelected: boolean;
 </script>
 
 <SideBarSection>
@@ -60,11 +68,21 @@
     {/if}
 
     {#if $featureFlags.map}
-      <SideBarLink title="Map" routeId="/(user)/map" icon={mdiMap} />
+      <SideBarLink
+        title="Map"
+        routeId="/(user)/map"
+        bind:isSelected={isMapSelected}
+        icon={isMapSelected ? mdiMap : mdiMapOutline}
+      />
     {/if}
 
     {#if $sidebarSettings.people}
-      <SideBarLink title="People" routeId="/(user)/people" icon={mdiAccount} />
+      <SideBarLink
+        title="People"
+        routeId="/(user)/people"
+        bind:isSelected={isPeopleSelected}
+        icon={isPeopleSelected ? mdiAccount : mdiAccountOutline}
+      />
     {/if}
     {#if $sidebarSettings.sharing}
       <SideBarLink
@@ -92,7 +110,7 @@
     <SideBarLink
       title="Favorites"
       routeId="/(user)/favorites"
-      icon={isFavoritesSelected ? mdiHeartMultiple : mdiHeartMultipleOutline}
+      icon={isFavoritesSelected ? mdiHeart : mdiHeartOutline}
       bind:isSelected={isFavoritesSelected}
     >
       <svelte:fragment slot="moreInformation">
@@ -118,7 +136,12 @@
       </svelte:fragment>
     </SideBarLink>
 
-    <SideBarLink title="Archive" routeId="/(user)/archive" icon={mdiArchiveArrowDownOutline}>
+    <SideBarLink
+      title="Archive"
+      routeId="/(user)/archive"
+      bind:isSelected={isArchiveSelected}
+      icon={isArchiveSelected ? mdiArchiveArrowDown : mdiArchiveArrowDownOutline}
+    >
       <svelte:fragment slot="moreInformation">
         {#await getStats({ isArchived: true })}
           <LoadingSpinner />
@@ -132,7 +155,12 @@
     </SideBarLink>
 
     {#if $featureFlags.trash}
-      <SideBarLink title="Trash" routeId="/(user)/trash" icon={mdiTrashCanOutline}>
+      <SideBarLink
+        title="Trash"
+        routeId="/(user)/trash"
+        bind:isSelected={isTrashSelected}
+        icon={isTrashSelected ? mdiTrashCan : mdiTrashCanOutline}
+      >
         <svelte:fragment slot="moreInformation">
           {#await getStats({ isTrashed: true })}
             <LoadingSpinner />