Infrastructure/immich
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2025-01-07 00:50:23 -05:00
Code Issues Activity

refactor(web): harden video can play method (#3745)

Browse source
This commit is contained in:
Jason Rasmussen 2023-08-17 11:02:12 -04:00 committed by GitHub
parent ce84f9c755
commit 8ba338fbe1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
web/src/lib/components/asset-viewer/video-viewer.svelte
View file

@ -4,21 +4,25 @@
import { createEventDispatcher } from 'svelte'; import { createEventDispatcher } from 'svelte';
import { videoViewerVolume } from '$lib/stores/preferences.store'; import { videoViewerVolume } from '$lib/stores/preferences.store';
import LoadingSpinner from '../shared-components/loading-spinner.svelte'; import LoadingSpinner from '../shared-components/loading-spinner.svelte';
import { handleError } from '../../utils/handle-error';
export let assetId: string; export let assetId: string;
export let publicSharedKey: string | undefined = undefined; export let publicSharedKey: string | undefined = undefined;
let isVideoLoading = true; let isVideoLoading = true;
const dispatch = createEventDispatcher(); const dispatch = createEventDispatcher<{ onVideoEnded: void }>();
const handleCanPlay = (ev: Event & { currentTarget: HTMLVideoElement }) => { const handleCanPlay = async (event: Event) => {
const playerNode = ev.currentTarget; try {
const video = event.currentTarget as HTMLVideoElement;
video.muted = true;
await video.play();
video.muted = false;
playerNode.muted = true; isVideoLoading = false;
playerNode.play(); } catch (error) {
playerNode.muted = false; handleError(error, 'Unable to play video');
}
isVideoLoading = false;
}; };
</script> </script>