From 60c521101a0db1c37115343756a2c6325df961e5 Mon Sep 17 00:00:00 2001 From: Daniel Dietzler <36593685+danieldietzler@users.noreply.github.com> Date: Sun, 10 Mar 2024 00:18:25 +0100 Subject: [PATCH] chore(server): type checks for e2e (#7800) type checks for e2e --- .github/workflows/test.yml | 4 ++++ e2e/package.json | 3 ++- e2e/src/api/specs/album.e2e-spec.ts | 2 +- e2e/src/api/specs/shared-link.e2e-spec.ts | 2 +- 4 files changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 9adcfe7373..d704aa6295 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -196,6 +196,10 @@ jobs: run: npm run format if: ${{ !cancelled() }} + - name: Run tsc + run: npm run check + if: ${{ !cancelled() }} + - name: Install Playwright Browsers run: npx playwright install --with-deps chromium if: ${{ !cancelled() }} diff --git a/e2e/package.json b/e2e/package.json index 1e66fd579c..42862d67fb 100644 --- a/e2e/package.json +++ b/e2e/package.json @@ -12,7 +12,8 @@ "format": "prettier --check .", "format:fix": "prettier --write .", "lint": "eslint \"src/**/*.ts\" --max-warnings 0", - "lint:fix": "npm run lint -- --fix" + "lint:fix": "npm run lint -- --fix", + "check": "tsc --noEmit" }, "keywords": [], "author": "", diff --git a/e2e/src/api/specs/album.e2e-spec.ts b/e2e/src/api/specs/album.e2e-spec.ts index 4faa5eac3d..2310b4718c 100644 --- a/e2e/src/api/specs/album.e2e-spec.ts +++ b/e2e/src/api/specs/album.e2e-spec.ts @@ -92,7 +92,7 @@ describe('/album', () => { }), ]); - await deleteUser({ id: user3.userId }, { headers: asBearerAuth(admin.accessToken) }); + await deleteUser({ id: user3.userId, deleteUserDto: {} }, { headers: asBearerAuth(admin.accessToken) }); }); describe('GET /album', () => { diff --git a/e2e/src/api/specs/shared-link.e2e-spec.ts b/e2e/src/api/specs/shared-link.e2e-spec.ts index 8b854eda00..3c3fd79269 100644 --- a/e2e/src/api/specs/shared-link.e2e-spec.ts +++ b/e2e/src/api/specs/shared-link.e2e-spec.ts @@ -86,7 +86,7 @@ describe('/shared-link', () => { }), ]); - await deleteUser({ id: user2.userId }, { headers: asBearerAuth(admin.accessToken) }); + await deleteUser({ id: user2.userId, deleteUserDto: {} }, { headers: asBearerAuth(admin.accessToken) }); }); describe('GET /shared-link', () => {