Infrastructure/immich
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2025-01-07 00:50:23 -05:00
Code Issues Activity

fix(web): show focus outline for asset thumbnails again (#12382)

Browse source 
* fix(web): show focus outline for asset thumbnails again

* fix e2e test
This commit is contained in:
Michel Heusschen 2024-09-06 15:18:45 +02:00 committed by GitHub
parent a653d9d29f
commit 529b7fe748
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
e2e/src/web/specs/shared-link.e2e-spec.ts
View file

@ -44,7 +44,7 @@ test.describe('Shared Links', () => {
test('download from a shared link', async ({ page }) => { test('download from a shared link', async ({ page }) => {
await page.goto(`/share/${sharedLink.key}`); await page.goto(`/share/${sharedLink.key}`);
await page.getByRole('heading', { name: 'Test Album' }).waitFor(); await page.getByRole('heading', { name: 'Test Album' }).waitFor();
await page.locator('.group').first().hover(); await page.locator(`[data-asset-id="${asset.id}"]`).hover();
await page.waitForSelector('#asset-group-by-date svg'); await page.waitForSelector('#asset-group-by-date svg');
await page.getByRole('checkbox').click(); await page.getByRole('checkbox').click();
await page.getByRole('button', { name: 'Download' }).click(); await page.getByRole('button', { name: 'Download' }).click();

3
web/src/lib/components/assets/thumbnail/thumbnail.svelte
View file

@ -175,7 +175,7 @@
data-int={intersecting} data-int={intersecting}
style:width="{width}px" style:width="{width}px"
style:height="{height}px" style:height="{height}px"
class="group focus-visible:outline-none flex overflow-hidden {disabled class="focus-visible:outline-none flex overflow-hidden {disabled
? 'bg-gray-300' ? 'bg-gray-300'
: 'bg-immich-primary/20 dark:bg-immich-dark-primary/20'}" : 'bg-immich-primary/20 dark:bg-immich-dark-primary/20'}"
> >
@ -193,6 +193,7 @@
<!-- svelte queries for all links on afterNavigate, leading to performance problems in asset-grid which updates <!-- svelte queries for all links on afterNavigate, leading to performance problems in asset-grid which updates
the navigation url on scroll. Replace this with button for now. --> the navigation url on scroll. Replace this with button for now. -->
<div <div
class="group"
class:cursor-not-allowed={disabled} class:cursor-not-allowed={disabled}
class:cursor-pointer={!disabled} class:cursor-pointer={!disabled}
on:mouseenter={onMouseEnter} on:mouseenter={onMouseEnter}