Infrastructure/immich
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2025-01-28 00:59:18 -05:00
Code Issues Activity

pr feedback

Browse source
This commit is contained in:
martabal 2024-02-02 17:59:15 +01:00
parent 5aa05e4630
commit 3e93b46c8b
No known key found for this signature in database
GPG key ID: C00196E3148A52BD
1 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
server/src/domain/person/person.service.ts
View file

@ -105,13 +105,17 @@ export class PersonService {
await this.access.requirePermission(auth, Permission.PERSON_CREATE, faceId); await this.access.requirePermission(auth, Permission.PERSON_CREATE, faceId);
const face = await this.repository.getFaceById(faceId); const face = await this.repository.getFaceById(faceId);
const person = await this.findOrFail(dto.personId); const person = await this.findOrFail(dto.personId);
const refreshIds = [];
await this.repository.reassignFace(face.id, dto.personId); await this.repository.reassignFace(face.id, dto.personId);
if (person.faceAssetId === null) { if (person.faceAssetId === null) {
await this.createNewFeaturePhoto([person.id]); refreshIds.push(person.id);
} }
if (face.person && face.person.faceAssetId === face.id) { if (face.person && face.person.faceAssetId === face.id) {
await this.createNewFeaturePhoto([face.person.id]); refreshIds.push(face.person.id);
}
if (refreshIds.length > 0) {
await this.createNewFeaturePhoto(refreshIds);
} }
return this.findOrFail(dto.personId).then(mapPerson); return this.findOrFail(dto.personId).then(mapPerson);
@ -124,9 +128,12 @@ export class PersonService {
const changeFeaturePhoto: string[] = []; const changeFeaturePhoto: string[] = [];
for (const data of dto.data) { for (const data of dto.data) {
const faces = await this.repository.getFacesByIds([{ personId: data.personId, assetId: data.assetId }]); const faces = await this.repository.getFacesByIds([{ personId: data.personId, assetId: data.assetId }]);
await this.access.requirePermission(
auth,
Permission.PERSON_CREATE,
faces.map((face) => face.id),
);
for (const face of faces) { for (const face of faces) {
await this.access.requirePermission(auth, Permission.PERSON_CREATE, face.id);
if (person.faceAssetId === null) { if (person.faceAssetId === null) {
changeFeaturePhoto.push(person.id); changeFeaturePhoto.push(person.id);
} }