fix(mobile): validate response code from download file (#4543)

Co-authored-by: shalong-tanwen <139912620+shalong-tanwen@users.noreply.github.com>

mobile/assets/i18n/en-US.json

@@ -164,6 +164,7 @@
   "home_page_favorite_err_local": "Can not favorite local assets yet, skipping",
   "home_page_first_time_notice": "If this is your first time using the app, please make sure to choose a backup album(s) so that the timeline can populate photos and videos in the album(s).",
   "image_viewer_page_state_provider_download_error": "Download Error",
+  "image_viewer_page_state_provider_share_error": "Share Error",
   "image_viewer_page_state_provider_download_success": "Download Success",
   "library_page_albums": "Albums",
   "library_page_archive": "Archive",

mobile/lib/modules/asset_viewer/providers/image_viewer_page_state.provider.dart

@@ -57,9 +57,19 @@ class ImageViewerStateNotifier extends StateNotifier<ImageViewerPageState> {
     showDialog(
       context: context,
       builder: (BuildContext buildContext) {
-        _shareService
+        _shareService.shareAsset(asset).then(
-            .shareAsset(asset)
+          (bool status) {
-            .then((_) => Navigator.of(buildContext).pop());
+            if (!status) {
+              ImmichToast.show(
+                context: context,
+                msg: 'image_viewer_page_state_provider_share_error'.tr(),
+                toastType: ToastType.error,
+                gravity: ToastGravity.BOTTOM,
+              );
+            }
+            Navigator.of(buildContext).pop();
+          },
+        );
         return const ShareDialog();
       },
       barrierDismissible: false,

mobile/lib/modules/asset_viewer/services/image_viewer.service.dart

@@ -5,6 +5,7 @@ import 'package:hooks_riverpod/hooks_riverpod.dart';
 import 'package:immich_mobile/shared/models/asset.dart';
 import 'package:immich_mobile/shared/providers/api.provider.dart';
 import 'package:immich_mobile/shared/services/api.service.dart';
+import 'package:logging/logging.dart';
 
 import 'package:photo_manager/photo_manager.dart';
 import 'package:path_provider/path_provider.dart';
@@ -14,6 +15,7 @@ final imageViewerServiceProvider =
 
 class ImageViewerService {
   final ApiService _apiService;
+  final Logger _log = Logger("ImageViewerService");
 
   ImageViewerService(this._apiService);
 
@@ -29,6 +31,16 @@ class ImageViewerService {
           asset.livePhotoVideoId!,
         );
 
+        if (imageResponse.statusCode != 200 ||
+            motionReponse.statusCode != 200) {
+          final failedResponse =
+              imageResponse.statusCode != 200 ? imageResponse : motionReponse;
+          _log.severe(
+            "Motion asset download failed with status - ${failedResponse.statusCode} and response - ${failedResponse.body}",
+          );
+          return false;
+        }
+
         final AssetEntity? entity;
 
         final tempDir = await getTemporaryDirectory();
@@ -48,6 +60,13 @@ class ImageViewerService {
         var res = await _apiService.assetApi
             .downloadFileWithHttpInfo(asset.remoteId!);
 
+        if (res.statusCode != 200) {
+          _log.severe(
+            "Asset download failed with status - ${res.statusCode} and response - ${res.body}",
+          );
+          return false;
+        }
+
         final AssetEntity? entity;
 
         if (asset.isImage) {

mobile/lib/shared/services/share.service.dart

@@ -4,6 +4,7 @@ import 'package:flutter/material.dart';
 import 'package:hooks_riverpod/hooks_riverpod.dart';
 import 'package:immich_mobile/shared/models/asset.dart';
 import 'package:immich_mobile/shared/providers/api.provider.dart';
+import 'package:logging/logging.dart';
 import 'package:path_provider/path_provider.dart';
 import 'package:share_plus/share_plus.dart';
 import 'api.service.dart';
@@ -13,32 +14,60 @@ final shareServiceProvider =
 
 class ShareService {
   final ApiService _apiService;
+  final Logger _log = Logger("ShareService");
 
   ShareService(this._apiService);
 
-  Future<void> shareAsset(Asset asset) async {
+  Future<bool> shareAsset(Asset asset) async {
-    await shareAssets([asset]);
+    return await shareAssets([asset]);
   }
 
-  Future<void> shareAssets(List<Asset> assets) async {
+  Future<bool> shareAssets(List<Asset> assets) async {
-    final downloadedXFiles = assets.map<Future<XFile>>((asset) async {
+    try {
-      if (asset.isRemote) {
+      final downloadedXFiles = <XFile>[];
-        final tempDir = await getTemporaryDirectory();
-        final fileName = asset.fileName;
-        final tempFile = await File('${tempDir.path}/$fileName').create();
-        final res = await _apiService.assetApi
-            .downloadFileWithHttpInfo(asset.remoteId!);
-        tempFile.writeAsBytesSync(res.bodyBytes);
-        return XFile(tempFile.path);
-      } else {
-        File? f = await asset.local!.file;
-        return XFile(f!.path);
-      }
-    });
 
-    Share.shareXFiles(
+      for (var asset in assets) {
-      await Future.wait(downloadedXFiles),
+        if (asset.isRemote) {
-      sharePositionOrigin: Rect.zero,
+          final tempDir = await getTemporaryDirectory();
-    );
+          final fileName = asset.fileName;
+          final tempFile = await File('${tempDir.path}/$fileName').create();
+          final res = await _apiService.assetApi
+              .downloadFileWithHttpInfo(asset.remoteId!);
+
+          if (res.statusCode != 200) {
+            _log.severe(
+              "Asset download failed with status - ${res.statusCode} and response - ${res.body}",
+            );
+            continue;
+          }
+
+          tempFile.writeAsBytesSync(res.bodyBytes);
+          downloadedXFiles.add(XFile(tempFile.path));
+        } else {
+          File? f = await asset.local!.file;
+          downloadedXFiles.add(XFile(f!.path));
+        }
+      }
+
+      if (downloadedXFiles.isEmpty) {
+        _log.warning("No asset can be retrieved for share");
+        return false;
+      }
+
+      if (downloadedXFiles.length != assets.length) {
+        _log.warning(
+          "Partial share - Requested: ${assets.length}, Sharing: ${downloadedXFiles.length}",
+        );
+      }
+
+      Share.shareXFiles(
+        downloadedXFiles,
+        sharePositionOrigin: Rect.zero,
+      );
+      return true;
+    } catch (error) {
+      _log.severe("Share failed with error $error");
+    }
+    return false;
   }
 }

mobile/lib/utils/selection_handlers.dart

@@ -1,3 +1,4 @@
+import 'package:easy_localization/easy_localization.dart';
 import 'package:flutter/material.dart';
 import 'package:fluttertoast/fluttertoast.dart';
 import 'package:hooks_riverpod/hooks_riverpod.dart';
@@ -15,10 +16,19 @@ void handleShareAssets(
   showDialog(
     context: context,
     builder: (BuildContext buildContext) {
-      ref
+      ref.watch(shareServiceProvider).shareAssets(selection.toList()).then(
-          .watch(shareServiceProvider)
+        (bool status) {
-          .shareAssets(selection.toList())
+          if (!status) {
-          .then((_) => Navigator.of(buildContext).pop());
+            ImmichToast.show(
+              context: context,
+              msg: 'image_viewer_page_state_provider_share_error'.tr(),
+              toastType: ToastType.error,
+              gravity: ToastGravity.BOTTOM,
+            );
+          }
+          Navigator.of(buildContext).pop();
+        },
+      );
       return const ShareDialog();
     },
     barrierDismissible: false,