mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-02-03 23:00:14 -05:00
a2aa66ca73
closes #10595 * Added breaking test for img-url helper Input from the content API was absolute, adding this test to verify my fix * Updated existing test to breaking test for img-url Had made a dumb assumption when building images sizes, this updates the test to fail so we can verify the fix * Refactored img-url to return as early as possible This makes it a little easier to parse what's going on, and it also allows us to remove the check for existence of the image url in the getImageSizes function * Refactored img-url config parsing to clean up core logic Superficial refactor to make future changes able to focus on what rather than how. * Refactored internal image detection into helper We're gonna need to know if the image is internal or not, when we force the path to relative, if we pull this out now, we have access in the top level logic * Removed duplicate checks for internal image Cleaning up and moving "higher-level" logic into the main function of the module * Renamed attr -> requestedImageUrl Superficial refactor, trying to be more explicit about identifiers * 🐛 Fixed img-url to output relative url by default Includes a check to isInternalImage as we never want to make external images relative. * Returned early if img-url recieves external url After realising we never want to deal with external urls, we can continue to return as early as possible, letting us remove checks and simplify the more complex logic for internal images. * Cleaned up the internal image logic Defining the three functions in order helps to see what operations are going to happen and in which order, we can then return the result of each operation applied to the next operation. |
||
|---|---|---|
| .. | ||
| test_tpl | ||
| asset_spec.js | ||
| author_spec.js | ||
| authors_spec.js | ||
| body_class_spec.js | ||
| content_spec.js | ||
| date_spec.js | ||
| encode_spec.js | ||
| excerpt_spec.js | ||
| facebook_url_spec.js | ||
| foreach_spec.js | ||
| get_spec.js | ||
| ghost_foot_spec.js | ||
| ghost_head_spec.js | ||
| has_spec.js | ||
| img_url_spec.js | ||
| index_spec.js | ||
| is_spec.js | ||
| lang_spec.js | ||
| meta_description_spec.js | ||
| meta_title_spec.js | ||
| navigation_spec.js | ||
| next_post_spec.js | ||
| page_url_spec.js | ||
| pagination_spec.js | ||
| plural_spec.js | ||
| post_class_spec.js | ||
| prev_post_spec.js | ||
| reading_time_spec.js | ||
| t_spec.js | ||
| tags_spec.js | ||
| template_spec.js | ||
| title_spec.js | ||
| twitter_url_spec.js | ||
| url_spec.js | ||
| utils_spec.js | ||